Bug 140374 - HTML Gallery export fails to parse xml from non-UTF8 metadata in jpeg
Summary: HTML Gallery export fails to parse xml from non-UTF8 metadata in jpeg
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Generic-HTMLGallery (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-21 00:56 UTC by Mark Purcell
Modified: 2018-07-18 20:37 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In: 6.0.0
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Purcell 2007-01-21 00:56:25 UTC
Version:           0.1.2 (using KDE KDE 3.5.5)
Installed from:    Debian testing/unstable Packages
OS:                Linux

Forwarded from: http://bugs.debian.org/407751

Subject: [Pkg-kde-extras] Bug#407751: kipi-plugins: HTML Gallery export fails parsing xml on non-UTF8 meta-info in jpeg
Date: Saturday 20 January 2007 23:29
From: Nieko Woets <news@linsign.com>
To: Debian Bug Tracking System <submit@bugs.debian.org>

Package: kipi-plugins
Version: 0.1.2-3
Severity: normal

When using the kipi-plugin HTML Gallery it fails when one or more jpeg images contain non-UTF8 meta-info. The 
meta-info is used in the gallery.xml file in the <description> tags. Xsltproc cannot parse this if this is 
non-UTF8. The plugin aborts with the message "Could not load XML file /path/gallery.xml".

Command to generate error messages in a terminal:
xsltproc --param i18nNext next --param i18nPrevious previous --param i18nCollectionList collection 
simple/template.xsl gallery.xml

Sample error:
gallery.xml:153: parser error : Input is not proper UTF-8, indicate encoding !
Bytes: 0xA8 0x20 0x34 0x2E
   <description>File written by Adobe Photoshop¨ 4.0</description>

This is something for upstream. Either parse the meta-info or perhaps an option to ignore the meta-info 
entirely.


-- System Information:
Debian Release: 4.0
  APT prefers testing
  APT policy: (500, 'testing'), (30, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.18-3
Locale: LANG=en_GB, LC_CTYPE=en_GB (charmap=ISO-8859-1)

Versions of packages kipi-plugins depends on:
ii  kdelibs4c2a         4:3.5.5a.dfsg.1-5    core libraries and binaries for al
ii  libc6               2.3.6.ds1-8          GNU C Library: Shared libraries
ii  libgcc1             1:4.1.1-19           GCC support library
ii  libgl1-mesa-glx [li 6.5.1-0.4            A free implementation of the OpenG
ii  libgphoto2-2        2.2.1-12             gphoto2 digital camera library
ii  libgphoto2-port0    2.2.1-12             gphoto2 digital camera port librar
ii  libimlib2           1.3.0.0debian1-4     powerful image loading and renderi
ii  libjpeg62           6b-13                The Independent JPEG Group's JPEG 
ii  libkexif1           0.2.3-2              library for KDE to read/display/ed
ii  libkipi0            0.1.4-1              library for apps that want to use 
ii  libmagick++9c2a     7:6.2.4.5.dfsg1-0.13 The object-oriented C++ API to the
ii  libpng12-0          1.2.15~beta5-1       PNG library - runtime
ii  libqt3-mt           3:3.3.7-2            Qt GUI Library (Threaded runtime v
ii  libstdc++6          4.1.1-19             The GNU Standard C++ Library v3
ii  libtiff4            3.8.2-7              Tag Image File Format (TIFF) libra
ii  libx11-6            2:1.0.3-4            X11 client-side library
ii  libxml2             2.6.27.dfsg-1        GNOME XML library
ii  libxslt1.1          1.1.19-1             XSLT processing library - runtime 

Versions of packages kipi-plugins recommends:
pn  dcraw               <none>               (no description available)
ii  imagemagick         7:6.2.4.5.dfsg1-0.13 Image manipulation programs
ii  k3b                 0.12.17-8            A sophisticated KDE CD burning app
ii  kdeprint            4:3.5.5a.dfsg.1-5    print system for KDE
pn  kmail               <none>               (no description available)
ii  konqueror           4:3.5.5a.dfsg.1-5    KDE's advanced file manager, web b
pn  kooka               <none>               (no description available)
pn  sane-utils          <none>               (no description available)

-- no debconf information
Comment 1 Adrian Petrescu 2007-06-29 02:05:41 UTC
I think this is most likely a duplicate of bug #146517: http://bugs.kde.org/show_bug.cgi?id=146517

But your report is more detailed so instead I will mark my bug as a duplicate of this one.

Thanks for finding out the root cause here, Mark!
Comment 2 caulier.gilles 2008-12-07 20:41:31 UTC
Mark,

This file still valid using kipi-plugins 0.1.6 ?

Gilles Caulier
Comment 3 caulier.gilles 2008-12-07 21:50:02 UTC
*** Bug 146517 has been marked as a duplicate of this bug. ***
Comment 4 caulier.gilles 2011-12-21 10:00:23 UTC
Mark,

This file still valid using kipi-plugins 2.4 ?

Gilles Caulier
Comment 5 caulier.gilles 2015-05-19 17:58:11 UTC
Mark,

This file still valid using kipi-plugins 4.10.0 ?

Gilles Caulier
Comment 6 caulier.gilles 2015-06-29 17:52:28 UTC
New Kipiplugins 4.11.0 is available :

https://www.digikam.org/node/740

Can you reproduce the problem with this release ?

Gilles Caulier
Comment 7 caulier.gilles 2017-07-08 22:49:42 UTC
Problem is not reproducible with current HTML Gallery tool implemented in digiKam core version 5.7.0

Gilles Caulier
Comment 8 Alan Aversa 2018-06-29 21:03:13 UTC
I get this "Could not load XML file 'gallery.xml'" issue with 5.9.0 and with master.
Comment 9 caulier.gilles 2018-06-30 07:51:53 UTC
Can you provide a full debug trace generated by DK on the console ?

Which HTML gallery theme do you use exactly ?

Gilles Caulier
Comment 10 caulier.gilles 2018-06-30 07:57:21 UTC
Which files naming scheme do you use with your image ?

Gilles Caulier
Comment 11 Alan Aversa 2018-06-30 18:58:59 UTC
(In reply to caulier.gilles from comment #9)
> Can you provide a full debug trace generated by DK on the console ?
I get plenty of these errors:

gallery.xml:5414: parser error : PCDATA invalid Char value 29
   <description></description>
                     ^

> Which HTML gallery theme do you use exactly ?
I've tried various themes, and they all produce the same error.

(In reply to caulier.gilles from comment #10)
> Which files naming scheme do you use with your image ?
How do I determine this?

I do not get the bug when using the "Images" image selection method.
The "Albums" image selection method always produces this bug.
Comment 12 Maik Qualmann 2018-07-02 11:36:35 UTC
Did you save the metadata like comments or description in the images? If so, can you upload a image to test? I can not reproduce the problem here on Windows or Linux.

Maik
Comment 13 Maik Qualmann 2018-07-18 20:32:43 UTC
Git commit 4219435ac9f10b8061f7658bbefbb85516a9ec31 by Maik Qualmann.
Committed on 18/07/2018 at 20:31.
Pushed by mqualmann into branch 'master'.

fix broken JFIF comment, remove non printable characters from the string
Related: bug 396170
FIXED-IN: 6.0.0

M  +3    -1    NEWS
M  +18   -1    core/libs/dmetadata/metaengine_p.cpp

https://commits.kde.org/digikam/4219435ac9f10b8061f7658bbefbb85516a9ec31
Comment 14 Maik Qualmann 2018-07-18 20:37:35 UTC
Note: To fix the problem with the gallery, you still have to re-read the metadata of the images.

Maik