Bug 139803 - [PATCH] EBN#1 - Check for TRUE and FALSE macros...
Summary: [PATCH] EBN#1 - Check for TRUE and FALSE macros...
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: Playback (show other bugs)
Version: unspecified
Platform: Ubuntu Linux
: VHI minor (vote)
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-09 08:31 UTC by Andrew Ash
Modified: 2008-06-16 14:20 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments
Mentioned Patch (14.46 KB, patch)
2007-01-09 08:32 UTC, Andrew Ash
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Ash 2007-01-09 08:31:34 UTC
Version:           svn (using KDE KDE 3.5.5)
Installed from:    Ubuntu Packages0

http://www.englishbreakfastnetwork.org/krazy/reports/extragear/multimedia/amarok/index.html

"" The TRUE and FALSE macros are obsolete and should be replaced with true and false (all lower case) respectively. ""

I wrote a script to do just that through the files mentioned on EBN.  The helix engine code had most of these cases and I'm using xine, so I haven't tested that portion of the code.  Amarok compiles and runs just fine with the changes made.

amarok/src/engine/helix/helix-sp/helix-include/common/include/hxtypes.h
Check the preprocessor definitions in this file.  I think they can be safely removed now that macros aren't being used for true and false.


Andrew Ash
Comment 1 Andrew Ash 2007-01-09 08:32:37 UTC
Created attachment 19205 [details]
Mentioned Patch

against current svn 621579
Comment 2 Edward Hades 2008-06-16 14:20:32 UTC
*** Bug has been marked as fixed ***.