Bug 139781 - Add new option to add audio track to Video Slide Show tool.
Summary: Add new option to add audio track to Video Slide Show tool.
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Plugin-Generic-VideoSlideshow (show other bugs)
Version: 8.2.0
Platform: Slackware Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-08 17:53 UTC by Wennael Lemonnier
Modified: 2024-01-31 07:02 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 8.3.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Wennael Lemonnier 2007-01-08 17:53:45 UTC
Version:            (using KDE KDE 3.5.4)
Installed from:    Slackware Packages
Compiler:          gcc 3.4 slackware i686
OS:                Linux

It will be very fine, if a checkbox is added to the mpegencoder UI, because if I build an MPEG video longer than the song duration, the end of the video will be without sound, that is very boring when watching it.

and/or why not to add ability to select multiple soundtracks, to play them all if the total duration is significant.
Comment 1 caulier.gilles 2017-06-30 08:59:11 UTC
digiKam has a new Video Slideshow tool based on QtAV and ffmpeg which do not
have this problem.

Gilles Caulier
Comment 2 caulier.gilles 2024-01-03 16:19:11 UTC
Git commit 5c0ce6aa787931b22bde21c50c6fa492883ae564 by Gilles Caulier.
Committed on 03/01/2024 at 16:56.
Pushed by cgilles into branch 'master'.

Add ffmpeg CLI binary finder for Video Slideshow.
Prepare to port the plugin to use the FFmpeg CLI tool instead QtAV (Qt6Multimedia cannot be used here).
NOTE: VideoSlideshow plugin is the last part of the Qt6 port of digiKam using QtAV.
Related: bug 472503, bug 425284, bug 427221, bug 462810, bug 448681

M  +1    -1    core/dplugins/generic/tools/videoslideshow/videoslideshowplugin.cpp
M  +1    -0    core/libs/video/CMakeLists.txt
A  +43   -0    core/libs/video/manager/ffmpegbinary.cpp     [License: GPL(v2.0+)]
A  +38   -0    core/libs/video/manager/ffmpegbinary.h     [License: GPL(v2.0+)]

https://invent.kde.org/graphics/digikam/-/commit/5c0ce6aa787931b22bde21c50c6fa492883ae564
Comment 3 caulier.gilles 2024-01-03 17:17:15 UTC
Git commit 420608c891d65372095db103bf8e795ffb289359 by Gilles Caulier.
Committed on 03/01/2024 at 18:16.
Pushed by cgilles into branch 'master'.

restore previous videoslideshow settings including audio track support
Related: bug 472503, bug 425284, bug 427221, bug 462810, bug 448681

M  +173  -10   core/libs/video/manager/qtav/vidslidetask.cpp
M  +1    -1    core/libs/video/manager/qtav/vidslidetask.h
M  +5    -1    core/libs/video/manager/vidslidesettings.cpp
M  +3    -1    core/libs/video/manager/vidslidesettings.h

https://invent.kde.org/graphics/digikam/-/commit/420608c891d65372095db103bf8e795ffb289359
Comment 4 caulier.gilles 2024-01-03 22:34:49 UTC
Git commit 4ff9e0d9fedf3189f62cbd3f0de64657bcc64116 by Gilles Caulier.
Committed on 03/01/2024 at 23:34.
Pushed by cgilles into branch 'master'.

add ffmpeg path tp the settings
Related: bug 472503, bug 425284, bug 427221, bug 462810, bug 448681

M  +1    -0    core/libs/video/manager/vidslidesettings.h

https://invent.kde.org/graphics/digikam/-/commit/4ff9e0d9fedf3189f62cbd3f0de64657bcc64116
Comment 5 caulier.gilles 2024-01-03 22:47:37 UTC
Git commit 982a06b8e1973a8447cac2ab92503f20a3f4fdfc by Gilles Caulier.
Committed on 03/01/2024 at 23:46.
Pushed by cgilles into branch 'master'.

add FFMpeg binary search in the wizard
Related: bug 472503, bug 425284, bug 427221, bug 462810, bug 448681

M  +12   -9    core/dplugins/generic/tools/videoslideshow/wizard/vidslidefinalpage.cpp
M  +45   -9    core/dplugins/generic/tools/videoslideshow/wizard/vidslideintropage.cpp
M  +3    -8    core/dplugins/generic/tools/videoslideshow/wizard/vidslideoutputpage.cpp
M  +3    -8    core/dplugins/generic/tools/videoslideshow/wizard/vidslidevideopage.cpp

https://invent.kde.org/graphics/digikam/-/commit/982a06b8e1973a8447cac2ab92503f20a3f4fdfc
Comment 6 caulier.gilles 2024-01-04 10:30:31 UTC
Git commit 2eb84eeb93994d93c4b3f4bdb001cba2fba67fb1 by Gilles Caulier.
Committed on 04/01/2024 at 11:26.
Pushed by cgilles into branch 'master'.

Complete isolation of QtAv code.
Tested with Qt5 and Qt5.
Tested with and without mediaplayer cmake option.
The linking problem with QtAv was the auto reccursive parsing of header file in whole source repository. QtAv was always parsed and add to the compilation rules.
Not qtav and qtmm are removed from the parse and add at the demand when necessary.
Continue to port VideoSlideshw to FFmpeg CLI tool to drop QtAV (Qt5 and Qt6).
Related: bug 472503, bug 425284, bug 427221, bug 462810, bug 448681

M  +6    -2    core/CMakeLists.txt
M  +27   -0    core/cmake/rules/RulesMediaPlayer.cmake
M  +1    -1    core/dplugins/generic/tools/CMakeLists.txt
M  +3    -4    core/dplugins/generic/tools/videoslideshow/wizard/vidslidefinalpage.cpp
M  +6    -8    core/libs/video/CMakeLists.txt

https://invent.kde.org/graphics/digikam/-/commit/2eb84eeb93994d93c4b3f4bdb001cba2fba67fb1
Comment 7 caulier.gilles 2024-01-04 12:43:40 UTC
Git commit 002af12bc3aad5cdfff34f2e6dd4eed71310df66 by Gilles Caulier.
Committed on 04/01/2024 at 13:42.
Pushed by cgilles into branch 'master'.

add C++17 support
use QString instead QUrl for the video output path
Related: bug 472503, bug 425284, bug 427221, bug 462810, bug 448681

M  +5    -9    core/dplugins/generic/tools/videoslideshow/wizard/vidslidealbumspage.cpp
M  +8    -15   core/dplugins/generic/tools/videoslideshow/wizard/vidslidefinalpage.cpp
M  +4    -6    core/dplugins/generic/tools/videoslideshow/wizard/vidslideimagespage.cpp
M  +9    -15   core/dplugins/generic/tools/videoslideshow/wizard/vidslideoutputpage.cpp
M  +12   -24   core/dplugins/generic/tools/videoslideshow/wizard/vidslidevideopage.cpp
M  +11   -21   core/dplugins/generic/tools/videoslideshow/wizard/vidslidewizard.cpp
M  +2    -2    core/libs/video/manager/vidslidesettings.cpp
M  +1    -1    core/libs/video/manager/vidslidesettings.h

https://invent.kde.org/graphics/digikam/-/commit/002af12bc3aad5cdfff34f2e6dd4eed71310df66
Comment 8 caulier.gilles 2024-01-04 14:09:44 UTC
Git commit 58ece9388d0a3ef6ba90db979902ba7cbf2a9b84 by Gilles Caulier.
Committed on 04/01/2024 at 15:07.
Pushed by cgilles into branch 'master'.

new video slideshow task to encode frame as temporary JPEG files.
This JPEG stream will be pipe to the FFmpeg cli tool to encode as video.

M  +2    -3    core/libs/video/CMakeLists.txt
D  +0    -452  core/libs/video/manager/qtav/vidslidetask.cpp
A  +184  -0    core/libs/video/manager/vidslidetask.cpp     [License: GPL(v2.0+)]
R  +0    -0    core/libs/video/manager/vidslidetask.h [from: core/libs/video/manager/qtav/vidslidetask.h - 100% similarity]

https://invent.kde.org/graphics/digikam/-/commit/58ece9388d0a3ef6ba90db979902ba7cbf2a9b84
Comment 9 caulier.gilles 2024-01-04 14:18:30 UTC
Git commit ae723b3daa572b4fa26fbe820b4f9b3131979b6c by Gilles Caulier.
Committed on 04/01/2024 at 15:16.
Pushed by cgilles into branch 'master'.

start the encoding thread to generate temprary JPEG frame before encode video with FFMPEG
Related: bug 472503, bug 425284, bug 427221, bug 462810, bug 448681

M  +13   -9    core/dplugins/generic/tools/videoslideshow/wizard/vidslidefinalpage.cpp

https://invent.kde.org/graphics/digikam/-/commit/ae723b3daa572b4fa26fbe820b4f9b3131979b6c
Comment 10 caulier.gilles 2024-01-04 15:26:05 UTC
Git commit 7c0981484d4371bd1e5ff7db5da6785f9393f65b by Gilles Caulier.
Committed on 04/01/2024 at 16:25.
Pushed by cgilles into branch 'master'.

Create a temporary directory to host JPEG frames
Related: bug 472503, bug 425284, bug 427221, bug 462810, bug 448681

M  +1    -1    core/dplugins/generic/tools/CMakeLists.txt
M  +23   -8    core/libs/video/manager/vidslidetask.cpp

https://invent.kde.org/graphics/digikam/-/commit/7c0981484d4371bd1e5ff7db5da6785f9393f65b
Comment 11 caulier.gilles 2024-01-05 13:50:40 UTC
Git commit dd325854d3021dacb139d387bd37544bf89d3df8 by Gilles Caulier.
Committed on 05/01/2024 at 14:45.
Pushed by cgilles into branch 'master'.

First version for testing of the new video slideshow tool based on FFmpeg CLI tool to encode images as video.

A small demo is available here: https://drive.google.com/file/d/1posBo2rqkatU7N6qkbZWGBbOELsUGdgg/view?usp=sharing

It still plenty of features to restore, as to adjust the codecs, the size, the frame rate, the format. The audio track must be supported too.
Currently the temporary directory containing frames to encode is not yet deleted at end, it's for debuging.
It's planed to remove temp dir when all features will be completed.
Related: bug 472503, bug 425284, bug 427221, bug 462810, bug 448681

M  +1    -3    core/dplugins/generic/tools/CMakeLists.txt
M  +1    -1    core/dplugins/generic/tools/videoslideshow/wizard/vidslidefinalpage.cpp
M  +6    -6    core/libs/video/manager/ffmpeglauncher.cpp
M  +17   -4    core/libs/video/manager/vidslidethread.cpp
M  +15   -1    core/libs/video/manager/vidslidethread.h

https://invent.kde.org/graphics/digikam/-/commit/dd325854d3021dacb139d387bd37544bf89d3df8
Comment 12 caulier.gilles 2024-01-07 11:22:05 UTC
Git commit 90b508130131d470ef6051e0296d24f058bd85b1 by Gilles Caulier.
Committed on 07/01/2024 at 12:20.
Pushed by cgilles into branch 'master'.

run the ffmpeg process in a separate thread to not block the GUI while encoding frames.
Related: bug 472503, bug 425284, bug 427221, bug 462810, bug 448681

M  +6    -1    core/libs/threads/processlauncher.cpp
M  +6    -2    core/libs/threads/processlauncher.h

https://invent.kde.org/graphics/digikam/-/commit/90b508130131d470ef6051e0296d24f058bd85b1
Comment 13 caulier.gilles 2024-01-09 12:20:49 UTC
Git commit 03ade2541d50c3bc5a56ecfbbc768f685fcc949b by Gilles Caulier.
Committed on 09/01/2024 at 13:18.
Pushed by cgilles into branch 'master'.

Add soundtrack support to Video Slideshow tool.
Audio track is not reencoded (ffmpeg copy)
FIXED-IN: 8.3.0

M  +25   -7    core/dplugins/generic/tools/videoslideshow/wizard/vidslideoutputpage.cpp
M  +25   -12   core/libs/video/manager/ffmpeglauncher.cpp
M  +3    -0    core/libs/video/manager/vidslidesettings.cpp
M  +1    -1    core/libs/video/manager/vidslidesettings.h

https://invent.kde.org/graphics/digikam/-/commit/03ade2541d50c3bc5a56ecfbbc768f685fcc949b
Comment 14 caulier.gilles 2024-01-31 07:02:17 UTC
Git commit b2e9442765af647012ffb8e8942f97d0b29af118 by Gilles Caulier.
Committed on 31/01/2024 at 07:00.
Pushed by cgilles into branch 'master'.

Use Audio Player Widget in Video SlideShow tool to preview soundtrack before rendering media.

M  +15   -3    core/dplugins/generic/tools/videoslideshow/wizard/vidslideoutputpage.cpp
M  +10   -0    core/libs/video/player/audplayerwdg.cpp

https://invent.kde.org/graphics/digikam/-/commit/b2e9442765af647012ffb8e8942f97d0b29af118