Bug 138022 - separate .sig stripping from other smart quoting options
Summary: separate .sig stripping from other smart quoting options
Status: RESOLVED WAITINGFORINFO
Alias: None
Product: kmail
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-28 15:11 UTC by Maciej Pilichowski
Modified: 2012-08-19 00:30 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
digest mail (20.82 KB, message/rfc822)
2006-12-01 07:58 UTC, Maciej Pilichowski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej Pilichowski 2006-11-28 15:11:50 UTC
Version:            (using KDE KDE 3.5.5)
Installed from:    SuSE RPMs

I tried to reply to some rather length mails (kde-usability digest) and I can't. Mail is cut. One at the ~200th line, the second at the ~500th line. And this done without any warning, nothing (to be honest, I would like to see it working, not warnings).

Reply, if nothing selected, should copy and reply to entire mail. I think that such reliability is critical for mail app.
Comment 1 Bram Schoenmakers 2006-11-28 18:38:38 UTC
Did you have the text selected when you pressed the Reply button? In that case it only uses only the selection in the reply.
Comment 2 Maciej Pilichowski 2006-11-28 21:25:03 UTC
Bram... ;-) of course not.
Comment 3 Philip Rodrigues 2006-12-01 00:57:10 UTC
I suspect a dupe of bug 129634. Maciej, can you check this please. If it's a dupe, please close, and if it's not, can you provide steps to reproduce. Thanks!
Comment 4 Maciej Pilichowski 2006-12-01 07:58:50 UTC
Created attachment 18741 [details]
digest mail

Hmm, if I understood correctly the reporter is talking about selections -- so
this is primary complaint. I don't have to select anything, KMail does not copy
the entire mail.

Steps -- the easiest way, subscribe to kde-usability, you get some data to test
on -- mail you cannot reply (entirely) to it. 

Here is just an example of one of them -- I don't know how to put it back to
KMail however.
Comment 5 Jonathan Marten 2006-12-01 12:10:05 UTC
To get the message back into KMail: Open the file (just click on the attachment link above) which will open it in a KMail viewer window.  From the popup menu, do "Copy To -> inbox" (or any other folder).  Then Reply.

And, for me, the same problem... the quoted text ends just after the paragraph ending "...it's not the file manager's fault, just hit back." of message 9.  Could it possibly be the reply trying to trim a signature? - that text is immediately followed by the "dash dash space" signature separator.
Comment 6 Maciej Pilichowski 2006-12-01 14:01:32 UTC
Jonathan, you are probably right.

Maybe KMail should include signature after all, or include it conditionaly -- check if there is text below (I mean more than 4 lines) or lines with "From:". 
I would opt for just including it. If there are ~4 lines it is easy to erase it (I am editing the original messages either way), if there are more is is probably the message, so I would feel more secure I did not miss something.
Comment 7 Philip Rodrigues 2006-12-02 17:31:30 UTC
Retitling to reflect the investigation, and be less hyperbolic.

With this retitling, I should point out that KMail already does reasonably well in this case: it only strips after the final "--" in the message, so you lose very little (compared to what would happen if it stripped after the first "--" :-).

Perhaps the best solution would be just not to strip signatures if there's more than one "--" in the message?
Comment 8 Maciej Pilichowski 2006-12-02 17:51:39 UTC
> I should point out that KMail already does reasonably well in this case: it
> only strips after the final "--" in the message, so you lose very little
> (compared to what would happen if it stripped after the first "--" :-). 

:-) Ahh, black humor (is this correct English?) -- I should include mail when the almost everything is lost because the sig is almost at the top ;-D

> Perhaps the best solution would be just not to strip signatures if there's
> more than one "--" in the message? 

Nope. It does make any difference really.

The sig separator is rather kind of agreement -- don't _type_ any dash dash space. But those characters are perfectly ok while composing mail so it would be better to copy the whole mail-body. Relying on a human "I won't" ("...type '-- ' by hand") is not a good assumption.

Or am I mistaken and this sig separator is a stricly technical thing and no mail agent is supposed to send '-- ' except for sig?
Comment 9 Philip Rodrigues 2006-12-02 21:00:30 UTC
Turning off "smart quoting" seems to make KMail include the signature, FWIW. Maciej, can you check this? If it works, then this bug should either be closed or downgraded to a wish (to separate out the .sig handling configuration from the other features of smart quoting).
Comment 10 Maciej Pilichowski 2006-12-02 21:36:06 UTC
Philip, thank you. So, this report is a wish really:

Please separate removing sig to another option, maybe like this:
[ ] smart line-wrapping when quoting
[ ] auto-remove signature when quoting

 
Comment 11 Philip Rodrigues 2006-12-02 23:26:58 UTC
OK, retitling again :-) (and marking unconfirmed, as normal for wishes)
Comment 12 Myriam Schweingruber 2012-08-18 08:41:55 UTC
Thank you for your feature request. Kmail1 is currently unmaintained so we are closing all wishes. Please feel free to reopen a feature request for Kmail2 if it has not already been implemented.
Thank you for your understanding.
Comment 13 Luigi Toscano 2012-08-19 00:30:09 UTC
Instead of creating a new feature request, please confirm here if the wishlist is still valid for kmail2.