Bug 136559 - Bad encoding in folder name for added RSS feeds from Konqueror
Summary: Bad encoding in folder name for added RSS feeds from Konqueror
Status: RESOLVED FIXED
Alias: None
Product: akregator
Classification: Applications
Component: general (show other bugs)
Version: 1.2
Platform: unspecified Linux
: NOR normal (vote)
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-31 11:23 UTC by Andrey Cherepanov
Modified: 2006-10-31 13:02 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrey Cherepanov 2006-10-31 11:23:17 UTC
Version:           1.2 (using KDE 3.5.0, compiled sources)
Compiler:          gcc version 3.4.4 20050721 (Red Hat 3.4.4-2)
OS:                Linux (i686) release 2.6.9-1.667smp

After add new RSS feed from Konqueror to Akregator, it is placed to new folder (Imported Feeds). But on Russian name of this folder is unreadable (like show UTF-8 in 8-bit encoding). I use ru_RU.UTF-8 as system locale.

Possible, bug in kdepim/akregator/src/main.cpp:68 (KDE-3.5.4 sources):

QString addFeedGroup = !args->getOption("group").isEmpty() ? args->getOption("group") : i18n("Imported Folder");

args->getOption("group") 
should be replaced by 
QString::fromLocal8Bit(args->getOption("group"))
Comment 1 Frank Osterfeld 2006-10-31 11:32:19 UTC
Thanks, that looks reasonable. It would be very helpful if you could test the patch so we can be sure that this fixes the problem.
Comment 2 Andrey Cherepanov 2006-10-31 12:36:48 UTC
I have checked on kdepim-3.5.4. My patch is enough for fix this problem. Do you apply my patch?
Comment 3 Frank Osterfeld 2006-10-31 12:40:44 UTC
Ah, ok. I read it like you just reckoned this being the right fix, without actual testing. I will apply it. Thanks!
Comment 4 Frank Osterfeld 2006-10-31 12:53:33 UTC
SVN commit 600663 by osterfeld:

fix group name encoding when using the CLI options to add a feed
BUG:136559


 M  +8 -1      ChangeLog  
 M  +3 -1      src/main.cpp  


--- branches/KDE/3.5/kdepim/akregator/ChangeLog #600662:600663
@@ -1,7 +1,14 @@
-Akregator ChangeLog
+#Akregator ChangeLog
 ===================
 (c) 2004-2006 the Akregator authors.
 
+Changes after 1.2.5:
+-----------------------------
+
+Bug fixes:
+
+ 2006/10/31 Fix group name encoding bug when adding feeds from commandline (e.g., using the Konq plugin) (#136559)
+
 Changes after 1.2.4:
 -----------------------------
 
--- branches/KDE/3.5/kdepim/akregator/src/main.cpp #600662:600663
@@ -65,7 +65,9 @@
       akr.send("openStandardFeedList");
     }
 
-    QString addFeedGroup = !args->getOption("group").isEmpty() ? args->getOption("group") : i18n("Imported Folder");
+    QString addFeedGroup = !args->getOption("group").isEmpty() 
+         ? QString::fromLocal8Bit(args->getOption("group")) 
+         : i18n("Imported Folder");
 
     QCStringList feeds = args->getOptionList("addfeed");
     QStringList feedsToAdd;
Comment 5 Frank Osterfeld 2006-10-31 12:58:34 UTC
SVN commit 600668 by osterfeld:

port encoding fix to trunk
CCBUG:136559


 M  +3 -1      main.cpp  


--- trunk/KDE/kdepim/akregator/src/main.cpp #600667:600668
@@ -64,7 +64,9 @@
       akr.call( "openStandardFeedList");
     }
 
-    QString addFeedGroup = !args->getOption("group").isEmpty() ? args->getOption("group") : i18n("Imported Folder");
+    QString addFeedGroup = !args->getOption("group").isEmpty() ? 
+         QString::fromLocal8Bit(args->getOption("group")) 
+         : i18n("Imported Folder");
 
     QByteArrayList feeds = args->getOptionList("addfeed");
     QStringList feedsToAdd;
Comment 6 Frank Osterfeld 2006-10-31 13:02:27 UTC
SVN commit 600670 by osterfeld:

Mention Andrey for providing the patch
CCBUG:136559


 M  +1 -0      ChangeLog  


--- branches/KDE/3.5/kdepim/akregator/ChangeLog #600669:600670
@@ -8,6 +8,7 @@
 Bug fixes:
 
  2006/10/31 Fix group name encoding bug when adding feeds from commandline (e.g., using the Konq plugin) (#136559)
+            Patch by Andrey Cherepanov.
 
 Changes after 1.2.4:
 -----------------------------