Bug 136527 - Aborting file copy/move operations does not work
Summary: Aborting file copy/move operations does not work
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
Depends on:
Reported: 2006-10-30 19:59 UTC by Wenli Liu
Modified: 2006-12-29 10:36 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:

proposed patch (9.35 KB, patch)
2006-10-30 20:08 UTC, Wenli Liu

Note You need to log in before you can comment on or make changes to this bug.
Description Wenli Liu 2006-10-30 19:59:12 UTC
Version:           svn (using KDE KDE 3.5.5KDE 1.2)
Installed from:    UnspecifiedCompiled From Sources
Compiler:          G++ 3.3.5 
OS:                Linux

To repeat:
1). Type audiocd:/ on File Browser tab (or any folder that has audio files)
2). Select a few files
3). Right click and choose Copy to Collction
4). While in progress, click on the abort button

The message "Abort all jobs" shows up but the copy/move operations are still active.
Comment 1 Wenli Liu 2006-10-30 20:08:03 UTC
Created attachment 18329 [details]
proposed patch

This patch does the following:
1). Stops the underlying file copy/move operation when the abort button is
2). Prevents further file copy/move operations until the abort action is done
3). Removes the .part files if exists
4). Tries to hide the progress bar even if the owner has already gone
5). Removes the query part from the extention when deciding a temporary file
name for non-local source files.
Comment 2 Martin Aumueller 2006-12-29 10:36:10 UTC
Thank you for the patch. Already applied for 1.4.5.