Bug 134304 - [test case] margin: auto and display: table on root element incorrectly generate horizontal scrollbar
Summary: [test case] margin: auto and display: table on root element incorrectly gener...
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: khtml renderer (show other bugs)
Version: unspecified
Platform: FreeBSD Ports FreeBSD
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-19 03:40 UTC by khtmltest
Modified: 2006-09-25 16:05 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
testcase (265 bytes, text/html)
2006-09-23 03:53 UTC, khtmltest 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description khtmltest 2006-09-19 03:40:47 UTC 
Version:            (using KDE KDE 3.5.4)
Installed from:    FreeBSD Ports
Compiler:          gcc 3.4.6 
OS:                FreeBSD

If the root element has display: table; and margin: auto; specified, Konqueror 3.5.4 will generate a bogus horizontal scrollbar.

testcase:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01//EN">
<html>
<head>
<title>margin: auto and display: table on root</title>
<style type="text/css">
html {
	margin: auto;
	display: table;
}
</style>
</head>
	
<body>
<div>there should be no scrollbar</div>
</body>
</html>

According to CSS 2.1 anonymous table model, the table computed width is shrink-to-fit in this case, with table-row-group, table-row, and table-cell anonymous elements autogenerated around the body descendant of root element with display: table; 

If the viewport width for a given font size is wider than the text in the body, the text should be centered on page. There should be no scrollbar.

The problem occurs if the following display types are assigned to the root element:

display: table;
display: table-header-group;
display: table-footer-group;
display: table-row-group;
display: table-row;
display: table-cell;

This is a spec violation in KHTML 3.5.4.
Comment 1 khtmltest 2006-09-23 03:53:55 UTC 
Created attachment 17884 [details]
testcase
Comment 2 Tommi Tervo 2006-09-23 16:34:33 UTC 
Confirmed, svn r587111
Comment 3 Allan Sandfeld 2006-09-25 16:05:30 UTC 
SVN commit 588278 by carewolf:

Don't mix canvas width and root margins. 
BUG: 134304
BUG: 134051


 M  +1 -1      render_box.cpp  
 M  +2 -4      render_canvas.cpp  


--- branches/KDE/3.5/kdelibs/khtml/rendering/render_box.cpp #588277:588278
@@ -696,7 +696,7 @@
 
 short RenderBox::containingBlockWidth() const
 {
-    if ((isCanvas()||isRoot()) && canvas()->view())
+    if (isCanvas() && canvas()->view())
     {
         if (canvas()->pagedMode())
             return canvas()->width();
--- branches/KDE/3.5/kdelibs/khtml/rendering/render_canvas.cpp #588277:588278
@@ -109,9 +109,7 @@
         return;
     }
 
-    m_width = m_view ?
-                m_view->frameWidth() + paddingLeft() + paddingRight() + borderLeft() + borderRight()
-                : m_minWidth;
+    m_width = m_view ? m_view->frameWidth() : m_minWidth;
 
     if (style()->marginLeft().isFixed())
         m_marginLeft = style()->marginLeft().value();
@@ -720,7 +718,7 @@
     RenderObject *fc = firstChild();
     if(fc) {
         // ow: like effectiveWidth() but without the negative
-        const int ow = hasOverflowClip() ? width() : overflowWidth();
+        const int ow = fc->hasOverflowClip() ? fc->width() : fc->overflowWidth();
         int dw = ow + fc->marginLeft() + fc->marginRight();
         int rightmostPos = fc->rightmostPosition(false);
 // kdDebug(6040) << "w " << w << " rightmostPos " << rightmostPos << " dw " << dw << " fc->rw " << fc->effectiveWidth() << " fc->width() " << fc->width() << endl;