Bug 134158 - Some UI issues (Audio-CD track view)
Summary: Some UI issues (Audio-CD track view)
Status: RESOLVED FIXED
Alias: None
Product: k3b
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Sebastian Trueg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-16 11:10 UTC by Elias Probst
Modified: 2006-09-17 16:06 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Audio CD view (47.50 KB, image/png)
2006-09-16 11:12 UTC, Elias Probst
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Elias Probst 2006-09-16 11:10:58 UTC
Version:           1.0_pre2 (using KDE KDE 3.5.4)
Installed from:    Gentoo Packages

The new K3B-1.0_pre2 is really great, but it still suffers some problems:

1.) When ripping an Audio CD the title of the MainWindow becomes 100% instead of changing back to "K3b - The CD and DVD Kreator"



2.) When editing information of an Audio CD there are 2 issues:

a) Problem:
The view doesn't scroll early enough (see Attachment#1 [details], scroll.png) when jumping from one track to the next by pressing <ENTER> and reaching the end of the view. 

Solution:
It should scroll, as soon as the current line is hidden by more than 1px.

b) Problem:
When reaching the end of the list and pushing accidentally enter, K3B jumps to directory navigation and all made changes are lost, when having not clicked "Save CDDB entry locally".

Solution:
K3B should stay in Audio CD view mode
or
K3B should save the CDDB entry before changing to directory view mode
or
K3B should ask for saving the changes


3.) The other buttons (Query CDDB, Save CDDB entry locally, ...) should have a text label just like the "Start Ripping" button. It would make the UI more intuitive. At the moment you have to 'mouseover' them to find out what they do.
The same should be done to the buttons in the CD ripping dialog for saving/loading/... user configuration.



4.) There is a problem disabling KDED Mediamanager, but it seems to be Amarok related. Already filed a bug (#134153).
Comment 1 Elias Probst 2006-09-16 11:12:38 UTC
Created attachment 17788 [details]
Audio CD view
Comment 2 Sebastian Trueg 2006-09-16 13:24:39 UTC
I know. The stupid thing is that it does not happen each time. Thus, finding 
the bug is really hard.
Comment 3 Sebastian Trueg 2006-09-16 14:43:54 UTC
SVN commit 585162 by trueg:

Emit the started signal.

BUG: 134158


 M  +1 -0      k3baudioripjob.cpp  
 M  +2 -2      k3baudioripthread.cpp  


--- trunk/extragear/multimedia/k3b/src/rip/k3baudioripjob.cpp #585161:585162
@@ -59,6 +59,7 @@
 
 void K3bAudioRipJob::start()
 {
+  emitStarted();
   K3bInterferingSystemsHandler::instance()->disable( m_thread->m_device );
   k3bcore->blockDevice( m_thread->m_device );
   m_threadJob->start();
--- trunk/extragear/multimedia/k3b/src/rip/k3baudioripthread.cpp #585161:585162
@@ -278,8 +278,8 @@
     emitFinished(false);
   }
   else {
-  if( k3bcore->globalSettings()->ejectMedia() )
-    m_device->eject();
+    if( k3bcore->globalSettings()->ejectMedia() )
+      m_device->eject();
 
     emitFinished(success);
   }
Comment 4 Elias Probst 2006-09-17 16:06:12 UTC
Sorry for posting more than one "bug" as one report. I've opened some new ones for the other issues:

Issue "2.)" bug#134208

Issue "3.)" bug#134209

Issue "4.)" is now discussed by the Amarok devs. See bug#134153