Bug 133643 - DAAP server doesn't compile without CFLAGS being set
Summary: DAAP server doesn't compile without CFLAGS being set
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Slackware Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-09-06 11:28 UTC by richlv
Modified: 2006-09-10 02:09 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description richlv 2006-09-06 11:28:04 UTC 
Version:           svn 581368 (using KDE KDE 3.5.4)
Installed from:    Slackware Packages
Compiler:          gcc 3.4.6 
OS:                Linux

make -f Makefile.cvs complains :
amarok/src/mediadevice/daap/mongrel/http11/Makefile.am:10: `CFLAGS' is a user variable, you should not override it;
amarok/src/mediadevice/daap/mongrel/http11/Makefile.am:10: use `AM_CFLAGS' instead.
Comment 1 Ian Monroe 2006-09-06 19:44:01 UTC 
Warnings aren't bugs. If it causes problem it would be a bug then.
Comment 2 Seb Ruiz 2006-09-10 01:08:00 UTC 
it is a bug
Comment 3 Seb Ruiz 2006-09-10 01:08:53 UTC 
and it was closed by Dirk Mueller:

SVN commit 582645 by mueller:

don't overwrite user's CFLAGS
Comment 4 Ian Monroe 2006-09-10 01:17:46 UTC 
If by "close" you mean "make not compile".

I don't just add random crap to Makefile.am's, you can't just remove something and expect it to work.

gcc -DHAVE_CONFIG_H -I../../../../amarok/src/mediadevice/daap/mongrel/http11 -I/home/ian/workspace/local/amarok/src/mediadevice/daap/mongrel/http11 -I../../../.. -I/usr/lib64/ruby/1.8/x86_64-linux -DQT_THREAD_SUPPORT -D_REENTRANT -std=iso9899:1990 -W -Wall -Wchar-subscripts -Wshadow -Wpointer-arith -Wmissing-prototypes -Wwrite-strings -D_XOPEN_SOURCE=500 -D_BSD_SOURCE -g3 -fno-inline -Wformat-security -Wmissing-format-attribute -fPIC -DPIC -c /home/ian/workspace/local/amarok/src/mediadevice/daap/mongrel/http11/http11.c -o ../../../../amarok/src/mediadevice/daap/mongrel/http11/.libs/http11.o -Wp,-MD,../../../../amarok/src/mediadevice/daap/mongrel/http11/.deps/http11.TUlo
In file included from /home/ian/workspace/local/amarok/src/mediadevice/daap/mongrel/http11/http11.c:5:
/usr/lib64/ruby/1.8/x86_64-linux/ruby.h:631: error: syntax error before "VALUE"
/usr/lib64/ruby/1.8/x86_64-linux/ruby.h:638: warning: no previous prototype for 'rb_class_of'
/usr/lib64/ruby/1.8/x86_64-linux/ruby.h:648: error: syntax error before "int"
/usr/lib64/ruby/1.8/x86_64-linux/ruby.h:655: warning: no previous prototype for 'rb_type'
/home/ian/workspace/local/amarok/src/mediadevice/daap/mongrel/http11/http11.c:64: warning: no previous prototype for 'http_field'
Comment 5 Ian Monroe 2006-09-10 02:09:16 UTC 
Turned out all it was was C++-style comments.