Bug 133490 - "Stop Playing After Track" feature does not go to next track when playing again
Summary: "Stop Playing After Track" feature does not go to next track when playing again
Status: RESOLVED WORKSFORME
Alias: None
Product: amarok
Classification: Applications
Component: general (other bugs)
Version First Reported In: 2.0-SVN
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
: 139864 (view as bug list)
Depends on:
Blocks:
 
Reported: 2006-09-03 12:48 UTC by Bram Schoenmakers
Modified: 2008-07-10 11:44 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Returns old playlist behaviour ( before 1.4.1 ) (504 bytes, patch)
2007-03-02 16:20 UTC, CodeMachine
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bram Schoenmakers 2006-09-03 12:48:37 UTC
Version:           1.4.2 (using KDE KDE 3.5.4)
Installed from:    Gentoo Packages
Compiler:          gcc 4.1.1 
OS:                Linux

I often use the "Stop Playing After Track" feature when I'm about to leave my keyboard for a while. When I return, I want to continue playing, but it starts the last played track again. I'd expect to pick the next song instead of the last one I played before I left.

This is bothering me for some releases already (at least 1.4.0, but it may be earlier). I'm primarily using the random track mode, if that's of any use.
Comment 1 richlv 2006-09-04 13:18:44 UTC
hmm. with latest svn 'stop after current track' marks next track as the active, not the one just played. i think this behaviour has been changed somewhere before at least 1.4.2 - are you sure that is the final 1.4.2 build ?

anybody else can reproduce this with 1.4.2 ?
Comment 2 Bram Schoenmakers 2006-09-04 13:56:18 UTC
Yes, I'm really sure that I'm running 1.4.2 right now.
Comment 3 Seb Ruiz 2006-09-04 14:07:41 UTC
i agree entirely, its annoying.  Unfortunately it requires quite a bit of tweaking to get better/right, because of the original design of playlist code.
Comment 4 richlv 2006-09-04 14:32:43 UTC
ok, to clarify - this is with 'random' mode, not dynamic playlist 'random mix' or any other dynamic playlist ;)
Comment 5 simon 2006-09-27 18:48:49 UTC
Resently (can't give the exact rev) there is a different issue with stop playing after track.
It advances two tracks. In fact it stops and the next is marked active (which would be the desired state) and after ~1sec. it advances again, and one track is not  played at all when resuming playback.
When i stop manually it doesn't advance the current track marker (bubble thingy) at all. So in this case the last track is played again. 
i'm currently using revision 589003.
Comment 6 simon 2006-10-12 19:07:02 UTC
I just realize this skip seems to be gone if i disable crossfading - so i think it has the same reason as http://bugs.kde.org/show_bug.cgi?id=135511
Comment 7 CodeMachine 2006-10-25 07:27:57 UTC
This seems to be related to bugfix of #127312. See http://websvn.kde.org/trunk/extragear/multimedia/amarok/src/playlist.cpp?rev=544148&r1=542672&r2=544148 for details.
It makes amarok not deselect current item after 'stop after current track' while in random mode.
Applying reverse patch fixed this for me.
Comment 8 Bram Schoenmakers 2006-11-06 20:09:10 UTC
In amaroK 1.4.4 I don't see this problem. But I wonder if it is a hack which accomplishes this and you want to do it the right way at a later stage. So feel free to close this bug if there are no plans to work further on it.
Comment 9 simon 2006-11-06 20:25:59 UTC
well with rev600764 i still got the advance of two tracks if using crossfading and stop playing after this track. I don't think 1.4.4 is newer but i'll try to test this with a current svn tomorrow.
Comment 10 CodeMachine 2006-11-07 04:00:01 UTC
Still see this problem in amarok 1.4.4. Track selected to stop after in random mode is played again after stop.
Comment 11 Alexandre Oliveira 2006-12-27 22:05:24 UTC
It seems to work ok in svn version
Comment 12 CodeMachine 2007-02-09 19:52:50 UTC
In amarok-1.4.5 track is still played twice if play position was changed during playback.
Comment 13 Kevin Funk 2007-02-26 12:43:44 UTC
I can confirm this; re-opening.
Comment 14 CodeMachine 2007-03-02 16:20:14 UTC
Created attachment 19863 [details]
Returns old playlist behaviour ( before 1.4.1 )

Since this bug is very annoying for me, I've made a small patch that returns
old playlist behavior ( to reset selection after "Stop after current tack" ).
I've used it since amarok 1.4.1 ( and still using on amarok 1.4.5 ) and it
works fine for me so I've decided to post it here. Perhaps someone else may
find it useful.
Comment 15 missive 2007-07-04 21:28:48 UTC
This had been working for me, but now in 1.4.6 I am having this problem again.

Now what I see is that after stopping, the "stop playing after track" marker stays on the selected track, and if I press start the selected track will play again.

I also notice that no statistics are updated for the track (ie. it still says play count: 0  and score: 0)

My expectation would be that after stopping, the "stop playing after track" marker would disappear, the track statistics would be updated, and the next track in the list would be selected so that when I press start the track will not be repeated.
Comment 16 Harald Sitter 2007-08-28 23:12:43 UTC
*** Bug 139864 has been marked as a duplicate of this bug. ***
Comment 17 Jesse Kahtava 2008-03-07 18:22:30 UTC
I can confirm this bug still exists in 1.4.8 on Fedora 8.

- Stop playing icon doesn't disappear after song finishes
- Pressing play replays the same song
- Score is not updated after song finishes with stop playing selected
Comment 18 Dan Meltzer 2008-03-14 16:38:56 UTC
Setting this version to 2.0... It's not easily fixed with the playlist code in 1.4, unfortunatly.

It should be easier to fix in 2.0, however.
Comment 19 Thomas Kamps 2008-06-15 12:00:05 UTC
I can also confirm this bug in 1.4.9.1
Comment 20 Thomas Kamps 2008-06-15 12:26:59 UTC
In Amarok 2 amarok just crashes, when stopping an the end of a track.
I'll put debug infos later, when i have debug packages installed.
Comment 21 Mark Kretschmann 2008-07-10 11:44:38 UTC
I can no longer reproduce this in Amarok 2. Closing.