Version: 1.4.1-r3 (using KDE KDE 3.5.4)
Installed from: Gentoo Packages
Compiler: gcc 4.1.1 -march=pentium4 -O2 -fomit-frame-pointer -momit-leaf-frame-pointer -pipe -frename-registers
I have an 2 disk album. In Random Album mode, it'll jump from track 1 of disk 1 to track 1 of disk 2, and then vice versa over and over again. The Playlist browser is smart enough to sort it correctly (all of disk one followed by all two), but the playback order doesn't recognize it as well.
How to reproduce:
- Turn on random album mode
- Tag your each CD of your 2-cd album with the "Disk Number" tag appropriately, and label the tracks from 1-10 and 1-10 (or something like that)
- Load up a 2 cd album, watch how it's displayed properly (1-10 followed by 1-10)
- Watch as it goes back and forth between the two Track 1's
I can confirm this bug in 1.4.3.
*** Bug 131418 has been marked as a duplicate of this bug. ***
I can also confirm this bug in 1.4.5.
Bug is still available in 1.4.6
But in my case it doesn't depend on a 2 CD Album.
When I have e.g. only 2 or some more Songs that belong to one album, it also happens sometimes, that these Songs are played again and again.
The endless loop occures if you play the playlist in album random order and you play a couple of songs of one artist where the songs don't have an album entry.
Created attachment 21118 [details]
I've investigated on this bug and found a fix. The problem was that with tracks
with duplicate track numbers within one album *), only one was added to the
list of tracks to play.
*) The totality of tracks with a blank album name count as one album ;-)
Created attachment 21123 [details]
(Supposedly) working version of the patch.
Sorry, I just realized that I messed up when creating the diff.
To apply the patch, copy to you Amarok source folder and run `patch -p0 <
Cristoph - I tried to apply the patch and it did not compile - did you test it? I presume it was just a typo and you removed one of the lines by accident.
I'm not going to commit this until you fix up the patch and have convinced me that you have tested the patch and it works :).
Once you've done that, no problems!
Hm, I must have messed with using diff, curiously, though, it seemed to work for me... Please be patient with me, this is my first patch :-/
I'll fix and re-test it when I have access to my own computer again with the sources on it, which will probably be tomorrow evening.
Argh and yet another typo in the above comment ... where's the "edit"-button anyway? ;-)
On 15 Jul 2007 19:06:46 -0000, Christoph Watzl
> Hm, I must have messed with using diff, curiously, though, it seemed to work for me... Please be patient with me, this is my first patch :-/
> I'll fix and re-test it when I have access to my own computer again with the sources on it, which will probably be tomorrow evening.
Christian, from my experience it often works best to use "svn diff".
Never had problems with that.
Sorry, I meant to write Christoph.
Created attachment 21533 [details]
Working version of the patch
I think the last proposed path is wrong; It doesn't change the
PlayListItem:prevInAlbum and PlayListItem:prevInAlbum and it doesn't check that
the disc numbers are the same when comparing the track numbers.
Note that (DiscNumber => 2, Track => 1) should be after (DiscNumber => 1, Track
I am attaching a modified patch that I have tested (both going forward and
backwards, with previous track, in the playlist). This is against 1.4.7.
SVN commit 723237 by seb:
Fix random album mode with compilations. Patch thanks to Siavosh Benabbas. Sorry it took so long, I've been away.
M +16 -4 playlistitem.cpp
WebSVN link: http://websvn.kde.org/?view=rev&revision=723237