Bug 132895 - [PATCH] "album random play" breaks on tracks with album==emptystring
Summary: [PATCH] "album random play" breaks on tracks with album==emptystring
Status: RESOLVED DUPLICATE of bug 128405
Alias: None
Product: amarok
Classification: Applications
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-24 01:39 UTC by Philip Rodrigues
Modified: 2006-10-01 12:06 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:

Attachments
proposed patch (428 bytes, patch)
2006-08-24 01:40 UTC, Philip Rodrigues 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Rodrigues 2006-08-24 01:39:45 UTC 
Version:           r576121 (using KDE KDE 3.5.4)
Installed from:    Compiled From Sources

Settings:
Mode->Repeat->Off
Mode->Random->Albums
Mode->Random->Favor->Least recently played

In "album random play" mode, when a track is chosen which has an empty string as its album, all tracks by that artist with album==emptystring are subsequently played, and for some reason, the track chooser loops 2 or 3 times round these tracks.

I'd prefer that when a track with no album (or album==emptystring) is chosen, then next track is chosen completely at random, rather than taking the next track with that artist and album==emptystring. This may be intended behaviour (so perhaps that should be a separate wishlist item), but the looping is a bug. The attached patch solves both of these, though it might not be the best way to do it.
Comment 1 Philip Rodrigues 2006-08-24 01:40:37 UTC 
Created attachment 17482 [details]
proposed patch
Comment 2 Philip Rodrigues 2006-10-01 12:06:24 UTC 

*** This bug has been marked as a duplicate of 128405 ***