Bug 131948 - Broken "Open File" dialog in Color Management tool
Summary: Broken "Open File" dialog in Color Management tool
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: ColorManagement-Views (show other bugs)
Version: 0.9.0
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-06 12:11 UTC by Dik Takken
Modified: 2022-02-01 11:31 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 1.0.0
Sentry Crash Report:


Attachments
File dialog in Color Management Plugin (85.97 KB, image/png)
2006-08-19 11:35 UTC, Dik Takken
Details
patch to use QScrollArea to host icc profile preview widget (2.20 KB, patch)
2008-12-10 21:06 UTC, caulier.gilles
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Dik Takken 2006-08-06 12:11:48 UTC
Version:           0.9.0-Beta1 (using KDE KDE 3.5.3)
OS:                Linux

In the colormanagement plugin (Adjust -> Color -> Color Management), when you select an input profile, the File Open dialog is a bit broken: It has no scrollbar, and it does not respond to the mouse wheel.
Comment 1 caulier.gilles 2006-08-17 00:40:58 UTC
I cannot reproduce this problem here. Can you give us a screenshot please ?

Gilles Caulier
Comment 2 F.J. Cruz 2006-08-18 22:50:46 UTC
This happen in other kde apps too, i think you can solve it if you adjust the dialog size using the mouse.

Paco.
Comment 3 Dik Takken 2006-08-19 11:34:57 UTC
Hmm. I never noticed the problem in other KDE apps. Resizing does not trigger the appearance of a scrollbar, unless I make it really big, to make the preview fully visible. Only then, a horizontal scrollbar appears.
Comment 4 Dik Takken 2006-08-19 11:35:53 UTC
Created attachment 17419 [details]
File dialog in Color Management Plugin
Comment 5 Marcel Wiesweg 2006-08-19 23:11:38 UTC
Same here.
I see two possibilities:
Either there is a problem with size hints or minimum size or whatever in the embedded widget.
Or the file open dialog assumes that widgets are small enough and does not create scrollbars if not. Perhaps then we need to embed the embedded widget in another widget that provides scrollbars.
Comment 6 F.J. Cruz 2006-08-20 23:36:39 UTC
El S
Comment 7 caulier.gilles 2006-08-21 20:12:22 UTC
Paco, this is my viewpoint :

Like the icc preview widget is embedded by the KFileDialog, this is the role to this dialog to respect the widget size to render properly to the screen (to provide a scroolbar in fact).

I suspect a problem in KFileDialog layout management, especially in the preview area.

Of course, perhaps something can be done in digiKam to solve the problem like Marcel has said. I recommend you to check the KDELibs library implementation to find a part using a KFileDialog instance with a preview widget, and look how the preview widget is embedded into the KFileDialog.

Gilles

Comment 8 Andi Clemens 2008-12-03 12:39:06 UTC
This is still present in latest KDE4... I will take a look at this today.

Andi
Comment 9 Andi Clemens 2008-12-10 19:47:14 UTC
We should either use a ScrollArea widget here (or similar) or write a different ICCProfile preview widget. I think the current one is MUCH to big for a preview widget in an open file dialog.
In general it would be nice if graphic widgets (like ICCProfile, CurvesWidget, Histogram etc) would scale down automatically, this will solve a lot of space problems. Right now they are all fixed size.

Andi
Comment 10 caulier.gilles 2008-12-10 20:13:23 UTC
Using QScrollArea Will be the speed way to fix this entry. I will do it

Trying to redesign ICC profile widget will be a lot's of job. It's will be better to see if lprof project now share this widget in a library. Current implementation use this code plus customizations, redesign and several improvements.

Gilles Caulier
Comment 11 caulier.gilles 2008-12-10 21:06:57 UTC
Created attachment 29222 [details]
patch to use QScrollArea to host icc profile preview widget

Marcel, Andi,

Using QScrollArea do not solve this problem. Try my patch attached

Gilles
Comment 12 Andi Clemens 2008-12-10 21:24:18 UTC
No, doesn't work good... ;-(
Comment 13 Andi Clemens 2009-02-13 15:05:02 UTC
SVN commit 925544 by aclemens:

Use QScrollArea for ICCPreviewWidget, do not use setWidgetResizable(),
otherwise the preview widget becomes messed up.

Right now this seems to be the best solution, what do you think? It
scales vertically, but not horizontally. I think it still looks ok.

CCBUG:131948

 M  +8 -4      iccpreviewwidget.cpp  


WebSVN link: http://websvn.kde.org/?view=rev&revision=925544
Comment 14 caulier.gilles 2009-02-15 10:33:33 UTC
It's better and fine for me...

Gilles
Comment 15 Andi Clemens 2009-02-15 11:08:42 UTC
Any idea how we can make it expand only horizontally? I tried using the "Horizontal Policy", but this seems to be ignored when a layout is used.

I set vertical: Fixed
horizontal: MinimumExpanding

Maybe I did something wrong? I'll try it once again...

Andi
Comment 16 Andi Clemens 2009-09-29 13:04:15 UTC
Can we close this one? The old color management plugin is gone and therefore the problem described in here, right?

Andi
Comment 17 Andi Clemens 2009-10-15 14:04:54 UTC
I will close this one now, since we don't seem to use IICProofTool anymore.