Bug 131895 - wrong kicker taskbar vertical size
Summary: wrong kicker taskbar vertical size
Status: RESOLVED DUPLICATE of bug 128552
Alias: None
Product: kicker
Classification: Unmaintained
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Aaron J. Seigo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-08-04 22:47 UTC by Martin Benda
Modified: 2006-08-13 00:52 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:

Attachments
The patch to fix the bug. (479 bytes, patch)
2006-08-04 22:49 UTC, Martin Benda 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Benda 2006-08-04 22:47:39 UTC 
Version:            (using KDE KDE 3.5.4)
Installed from:    Gentoo Packages
Compiler:          GCC 3.4.6 
OS:                Linux

External taskbar which is aligned left or right does not size properly when the "Expand as required to fit contents" option is checked. The taskbar has always maximal vertical size across the whole screen - regardless on the content of the taskbar.

It worked properly in KDE 3.5.3.

I've tracked the bug down to TaskBar::sizeHint(...) method in kicker/taskbar/taskbar.cpp - in the case of left and right alignment the height is properly computed (variable actualMax), but maxSize.height() is returned.

Bendis
Comment 1 Martin Benda 2006-08-04 22:49:12 UTC 
Created attachment 17231 [details]
The patch to fix the bug.
Comment 2 Martin Benda 2006-08-04 23:08:30 UTC 
The lines lines 178-181 in taskbar.cpp aren't clear to me neither:
...
    if (containerCount() == 0)
    {
        actualMax = maxSize.height();
    }
...
When the taskbar is empty it will stretch to the full size - is this the correct behavior?

Bendis
Comment 3 Andreas Kling 2006-08-13 00:52:01 UTC 

*** This bug has been marked as a duplicate of 128552 ***