Bug 129293 - kmahjongg: two different strings for "Show/Hide Toolbar"
Summary: kmahjongg: two different strings for "Show/Hide Toolbar"
Status: RESOLVED FIXED
Alias: None
Product: docs.kde.org
Classification: Websites
Component: general (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Documentation Editorial Team
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-17 12:14 UTC by Frederik Schwarzer
Modified: 2024-09-30 07:48 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Frederik Schwarzer 2006-06-17 12:14:01 UTC
Version:            (using KDE KDE 3.5.3)
Installed from:    Debian testing/unstable Packages
OS:                Linux

In the menu description, there are two different strings, one for "Hide Toolbar" (index.docbook:905/907) and one for "Show Toolbar"(index.docbook:912/914). Due to other docs, 912 and 914 should be deleted and 905 could be like "Show/Hide Toolbar" with suitable description in 907.
Comment 1 Frederik Schwarzer 2006-06-17 12:16:45 UTC
Same for statusbar (index.docbook:919/921 926/928)
Comment 2 Frederik Schwarzer 2006-06-17 12:25:59 UTC
and for "Matching Tiles" (index.docbook:933/935 940/942)

next time I make the list afore... ;)
Comment 3 Burkhard Lück 2006-06-18 23:00:47 UTC
SVN commit 552703 by lueck:

fixed errors found by Frederik Schwarzer
BUG:129293 

 M  +6 -27     index.docbook  


--- trunk/KDE/kdegames/doc/kmahjongg/index.docbook #552702:552703
@@ -902,48 +902,27 @@
 <variablelist>
 
 <varlistentry>
-<term><menuchoice><guimenu>Settings</guimenu><guimenuitem>Hide Toolbar</guimenuitem></menuchoice></term>
+<term><menuchoice><guimenu>Settings</guimenu><guimenuitem>Show/Hide Toolbar</guimenuitem></menuchoice></term>
 <listitem>
-<para>Hides the Toolbar.</para>
+<para>Shows or hides the Toolbar.</para>
 </listitem>
 </varlistentry>
 
 <varlistentry>
-<term><menuchoice><guimenu>Settings</guimenu><guimenuitem>Show Toolbar</guimenuitem></menuchoice></term>
+<term><menuchoice><guimenu>Settings</guimenu><guimenuitem>Show/Hide Statusbar</guimenuitem></menuchoice></term>
 <listitem>
-<para>Shows the Toolbar.</para>
+<para>Shows or hides the Statusbar.</para>
 </listitem>
 </varlistentry>
 
 <varlistentry>
-<term><menuchoice><guimenu>Settings</guimenu><guimenuitem>Hide Statusbar</guimenuitem></menuchoice></term>
+<term><menuchoice><guimenu>Settings</guimenu><guimenuitem>Show/Hide Matching Tiles</guimenuitem></menuchoice></term>
 <listitem>
-<para>Hides the Statusbar.</para>
+<para>Shows or hides matching tiles by not flashing the matching free tiles when a tile is selected.</para>
 </listitem>
 </varlistentry>
 
 <varlistentry>
-<term><menuchoice><guimenu>Settings</guimenu><guimenuitem>Show Statusbar</guimenuitem></menuchoice></term>
-<listitem>
-<para>Shows the Statusbar.</para>
-</listitem>
-</varlistentry>
-
-<varlistentry>
-<term><menuchoice><guimenu>Settings</guimenu><guimenuitem>Hide Matching Tiles</guimenuitem></menuchoice></term>
-<listitem>
-<para>Hides matching tiles by not flashing the matching free tiles when a tile is selected.</para>
-</listitem>
-</varlistentry>
-
-<varlistentry>
-<term><menuchoice><guimenu>Settings</guimenu><guimenuitem>Show Matching Tiles</guimenuitem></menuchoice></term>
-<listitem>
-<para>Shows matching tiles by flashing all matching free tiles when a tile is selected.</para>
-</listitem>
-</varlistentry>
-
-<varlistentry>
 <term><menuchoice><guimenu>Settings</guimenu><guimenuitem>Configure Shortcuts...</guimenuitem></menuchoice></term>
 <listitem>
 <para><action>Displays a standard &kde; shortcut configuration dialog</action> to change the 
Comment 4 Fushan Wen 2024-09-30 07:43:17 UTC
Git commit fa668e99a4258a314b5e3d251f23760850fefc7c by Fushan Wen.
Committed on 30/09/2024 at 06:49.
Pushed by fusionfuture into branch 'master'.

applets/kicker: port to std::unordered_map to work around a common crash when uninstalling apps

For some reason QHash doesn't play nicely with std::shared_ptr

```
    at /home/qydw/kde/src/plasma-workspace/applets/kicker/plugin/kastatsfavoritesmodel.cpp:383
        normalized = {m_id = {d = {d = 0x2c21a630, ptr = 0x2c21a640 u"applications:org.gnome.Cheese.desktop", size = 37}, static _empty = 0 u'\000'}}
        index = <optimized out>
        i = {c = <optimized out>, i = {i = {d = 0x36072570, bucket = 16}}, n = {i = {d = 0x36072570, bucket = <optimized out>}}}
    (__closure=0x2c575800) at /home/qydw/kde/src/plasma-workspace/applets/kicker/plugin/kastatsfavoritesmodel.cpp:206
        key = @0x329623c0: {d = {d = 0x2c21a630, ptr = 0x2c21a640 u"applications:org.gnome.Cheese.desktop", size = 37}, static _empty = 0 u'\000'}
        __for_range = @0x7ffe6b4e05f0: {<QListSpecialMethods<QString>> = {<QListSpecialMethodsBase<QString>> = {<No data fields>}, <No data fields>}, d = {d = 0x329623b0, ptr = 0x329623c0, size = 3}}
        __for_begin = {i = <optimized out>}
        __for_end = {i = <optimized out>}
        keys = {<QListSpecialMethods<QString>> = {<QListSpecialMethodsBase<QString>> = {<No data fields>}, <No data fields>}, d = {d = 0x329623b0, ptr = 0x329623c0, size = 3}}
        itemEntries = {d = <optimized out>}
        this = 0x2c43a5d0
    at /usr/src/debug/qtbase-everywhere-src-6.7.2/src/corelib/kernel/qobject.cpp:1452
        mce = 0x2ef6acc0
        connections = <optimized out>
        sender = {previous = 0x0, receiver = 0x2c43a5d0, sender = 0x2b905320, signal = 3}
    at /usr/src/debug/qtbase-everywhere-src-6.7.2/src/corelib/kernel/qcoreapplication.cpp:1142
        selfRequired = <optimized out>
        result = false
        cbdata = {0x2c43a5d0, 0x2ef6acc0, 0x7ffe6b4e071f}
        d = <optimized out>
        threadData = 0x2b3ac310
        scopeLevelCounter = {threadData = 0x2b3ac310}
    at /usr/src/debug/qtbase-everywhere-src-6.7.2/src/corelib/kernel/qcoreapplication.cpp:1583
    at /usr/src/debug/qtbase-everywhere-src-6.7.2/src/corelib/kernel/qcoreapplication.cpp:1940
        e = 0x2ef6acc0
        pe = <optimized out>
        r = <optimized out>
        relocker = {m_func = {__locker = <optimized out>}, m_invoke = <optimized out>}
        event_deleter = {d = 0x2ef6acc0}
        locker = {_M_device = 0x2b3ac368, _M_owns = false}
        startOffset = 0
        i = @0x2b3ac358: 4
        cleanup = {receiver = <optimized out>, event_type = <optimized out>, data = <optimized out>, exceptionCaught = <optimized out>}
    at /usr/src/debug/qtbase-everywhere-src-6.7.2/src/corelib/kernel/qeventdispatcher_glib.cpp:244
        source = 0x2b41a770
    at /usr/src/debug/qtbase-everywhere-src-6.7.2/src/corelib/kernel/qeventdispatcher_glib.cpp:394
        d = 0x2b4338d0
        canWait = true
        savedFlags = {i = 0}
        result = <optimized out>
    at /usr/src/debug/qtbase-everywhere-src-6.7.2/src/corelib/global/qflags.h:34
        d = 0x2b7f0000
        threadData = <optimized out>
        locker = {m_mutex = 0x2b3ac448, m_isLocked = false}
        ref = {d = <optimized out>, locker = <optimized out>, exceptionCaught = <optimized out>}
        app = <optimized out>
        threadData = 0x2b3ac310
        eventLoop = {<QObject> = {_vptr.QObject = 0x7f940280d170 <vtable for QEventLoop+16>, static staticMetaObject = {d = {superdata = {direct = 0x0}, stringdata = 0x7f9402643c80 <_ZN12_GLOBAL__N_1L39qt_meta_stringdata_CLASSQObjectENDCLASSE.lto_priv.0>, data = 0x7f9402643b60 <_ZL33qt_meta_data_CLASSQObjectENDCLASS.lto_priv.0>, static_metacall = 0x7f94023e1570 <QObject::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)>, relatedMetaObjects = 0x0, metaTypes = 0x7f940280aa20 <_Z27qt_incomplete_metaTypeArrayIN12_GLOBAL__N_141qt_meta_stringdata_CLASSQObjectENDCLASS_tEJN9QtPrivate20TypeAndForceCompleteI7QStringSt17integral_constantIbLb1EEEENS3_I7QObjectS6_EENS3_IvS5_IbLb0EEEENS3_IPS8_SA_EESB_SB_NS3_IRKS4_SA_EESB_SD_EE.lto_priv.0>, extradata = 0x0}}, d_ptr = {d = 0x2b7f0000}}, static staticMetaObject = {d = {superdata = {direct = 0x4eac80 <QObject::staticMetaObject@Qt_6>}, stringdata = 0x7f9402642ec0 <_ZN12_GLOBAL__N_1L42qt_meta_stringdata_CLASSQEventLoopENDCLASSE.lto_priv.0>, data = 0x7f9402642dc0 <_ZL36qt_meta_data_CLASSQEventLoopENDCLASS.lto_priv.0>, static_metacall = 0x7f9402396ef0 <QEventLoop::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)>, relatedMetaObjects = 0x0, metaTypes = 0x7f940280a600 <_Z27qt_incomplete_metaTypeArrayIN12_GLOBAL__N_144qt_meta_stringdata_CLASSQEventLoopENDCLASS_tEJN9QtPrivate20TypeAndForceCompleteI6QFlagsIN10QEventLoop17ProcessEventsFlagEESt17integral_constantIbLb1EEEENS3_IS5_S9_EENS3_IvS8_IbLb0EEEENS3_IiSC_EESD_SD_EE.lto_priv.0>, extradata = 0x0}}}
        returnCode = <optimized out>
        format = {d = 0x2b37f980}
        app = <incomplete type>
        aboutData = {d = std::unique_ptr<KAboutDataPrivate> = {get() = 0x2b7e48e0}}
        replace = false
        corona = 0x2b787790
        service = <incomplete type>
```

SENTRY: PLASMA-WORKSPACE-NZ0

M  +24   -21   applets/kicker/plugin/kastatsfavoritesmodel.cpp

https://invent.kde.org/plasma/plasma-workspace/-/commit/fa668e99a4258a314b5e3d251f23760850fefc7c
Comment 5 Fushan Wen 2024-09-30 07:48:46 UTC
Git commit 0736d1b4a4309895418b724ff48f792ad6eebd82 by Fushan Wen.
Committed on 30/09/2024 at 07:11.
Pushed by fusionfuture into branch 'Plasma/6.2'.

applets/kicker: port to std::unordered_map to work around a common crash when uninstalling apps

For some reason QHash doesn't play nicely with std::shared_ptr

```
    at /home/qydw/kde/src/plasma-workspace/applets/kicker/plugin/kastatsfavoritesmodel.cpp:383
        normalized = {m_id = {d = {d = 0x2c21a630, ptr = 0x2c21a640 u"applications:org.gnome.Cheese.desktop", size = 37}, static _empty = 0 u'\000'}}
        index = <optimized out>
        i = {c = <optimized out>, i = {i = {d = 0x36072570, bucket = 16}}, n = {i = {d = 0x36072570, bucket = <optimized out>}}}
    (__closure=0x2c575800) at /home/qydw/kde/src/plasma-workspace/applets/kicker/plugin/kastatsfavoritesmodel.cpp:206
        key = @0x329623c0: {d = {d = 0x2c21a630, ptr = 0x2c21a640 u"applications:org.gnome.Cheese.desktop", size = 37}, static _empty = 0 u'\000'}
        __for_range = @0x7ffe6b4e05f0: {<QListSpecialMethods<QString>> = {<QListSpecialMethodsBase<QString>> = {<No data fields>}, <No data fields>}, d = {d = 0x329623b0, ptr = 0x329623c0, size = 3}}
        __for_begin = {i = <optimized out>}
        __for_end = {i = <optimized out>}
        keys = {<QListSpecialMethods<QString>> = {<QListSpecialMethodsBase<QString>> = {<No data fields>}, <No data fields>}, d = {d = 0x329623b0, ptr = 0x329623c0, size = 3}}
        itemEntries = {d = <optimized out>}
        this = 0x2c43a5d0
    at /usr/src/debug/qtbase-everywhere-src-6.7.2/src/corelib/kernel/qobject.cpp:1452
        mce = 0x2ef6acc0
        connections = <optimized out>
        sender = {previous = 0x0, receiver = 0x2c43a5d0, sender = 0x2b905320, signal = 3}
    at /usr/src/debug/qtbase-everywhere-src-6.7.2/src/corelib/kernel/qcoreapplication.cpp:1142
        selfRequired = <optimized out>
        result = false
        cbdata = {0x2c43a5d0, 0x2ef6acc0, 0x7ffe6b4e071f}
        d = <optimized out>
        threadData = 0x2b3ac310
        scopeLevelCounter = {threadData = 0x2b3ac310}
    at /usr/src/debug/qtbase-everywhere-src-6.7.2/src/corelib/kernel/qcoreapplication.cpp:1583
    at /usr/src/debug/qtbase-everywhere-src-6.7.2/src/corelib/kernel/qcoreapplication.cpp:1940
        e = 0x2ef6acc0
        pe = <optimized out>
        r = <optimized out>
        relocker = {m_func = {__locker = <optimized out>}, m_invoke = <optimized out>}
        event_deleter = {d = 0x2ef6acc0}
        locker = {_M_device = 0x2b3ac368, _M_owns = false}
        startOffset = 0
        i = @0x2b3ac358: 4
        cleanup = {receiver = <optimized out>, event_type = <optimized out>, data = <optimized out>, exceptionCaught = <optimized out>}
    at /usr/src/debug/qtbase-everywhere-src-6.7.2/src/corelib/kernel/qeventdispatcher_glib.cpp:244
        source = 0x2b41a770
    at /usr/src/debug/qtbase-everywhere-src-6.7.2/src/corelib/kernel/qeventdispatcher_glib.cpp:394
        d = 0x2b4338d0
        canWait = true
        savedFlags = {i = 0}
        result = <optimized out>
    at /usr/src/debug/qtbase-everywhere-src-6.7.2/src/corelib/global/qflags.h:34
        d = 0x2b7f0000
        threadData = <optimized out>
        locker = {m_mutex = 0x2b3ac448, m_isLocked = false}
        ref = {d = <optimized out>, locker = <optimized out>, exceptionCaught = <optimized out>}
        app = <optimized out>
        threadData = 0x2b3ac310
        eventLoop = {<QObject> = {_vptr.QObject = 0x7f940280d170 <vtable for QEventLoop+16>, static staticMetaObject = {d = {superdata = {direct = 0x0}, stringdata = 0x7f9402643c80 <_ZN12_GLOBAL__N_1L39qt_meta_stringdata_CLASSQObjectENDCLASSE.lto_priv.0>, data = 0x7f9402643b60 <_ZL33qt_meta_data_CLASSQObjectENDCLASS.lto_priv.0>, static_metacall = 0x7f94023e1570 <QObject::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)>, relatedMetaObjects = 0x0, metaTypes = 0x7f940280aa20 <_Z27qt_incomplete_metaTypeArrayIN12_GLOBAL__N_141qt_meta_stringdata_CLASSQObjectENDCLASS_tEJN9QtPrivate20TypeAndForceCompleteI7QStringSt17integral_constantIbLb1EEEENS3_I7QObjectS6_EENS3_IvS5_IbLb0EEEENS3_IPS8_SA_EESB_SB_NS3_IRKS4_SA_EESB_SD_EE.lto_priv.0>, extradata = 0x0}}, d_ptr = {d = 0x2b7f0000}}, static staticMetaObject = {d = {superdata = {direct = 0x4eac80 <QObject::staticMetaObject@Qt_6>}, stringdata = 0x7f9402642ec0 <_ZN12_GLOBAL__N_1L42qt_meta_stringdata_CLASSQEventLoopENDCLASSE.lto_priv.0>, data = 0x7f9402642dc0 <_ZL36qt_meta_data_CLASSQEventLoopENDCLASS.lto_priv.0>, static_metacall = 0x7f9402396ef0 <QEventLoop::qt_static_metacall(QObject*, QMetaObject::Call, int, void**)>, relatedMetaObjects = 0x0, metaTypes = 0x7f940280a600 <_Z27qt_incomplete_metaTypeArrayIN12_GLOBAL__N_144qt_meta_stringdata_CLASSQEventLoopENDCLASS_tEJN9QtPrivate20TypeAndForceCompleteI6QFlagsIN10QEventLoop17ProcessEventsFlagEESt17integral_constantIbLb1EEEENS3_IS5_S9_EENS3_IvS8_IbLb0EEEENS3_IiSC_EESD_SD_EE.lto_priv.0>, extradata = 0x0}}}
        returnCode = <optimized out>
        format = {d = 0x2b37f980}
        app = <incomplete type>
        aboutData = {d = std::unique_ptr<KAboutDataPrivate> = {get() = 0x2b7e48e0}}
        replace = false
        corona = 0x2b787790
        service = <incomplete type>
```

SENTRY: PLASMA-WORKSPACE-NZ0


(cherry picked from commit fa668e99a4258a314b5e3d251f23760850fefc7c)

Co-authored-by: Fushan Wen <qydwhotmail@gmail.com>

M  +24   -21   applets/kicker/plugin/kastatsfavoritesmodel.cpp

https://invent.kde.org/plasma/plasma-workspace/-/commit/0736d1b4a4309895418b724ff48f792ad6eebd82