Bug 128733 - improve markers definition and properties
Summary: improve markers definition and properties
Status: CONFIRMED
Alias: None
Product: kst
Classification: Applications
Component: general (show other bugs)
Version: 1.10.0
Platform: Compiled Sources Other
: NOR wishlist
Target Milestone: ---
Assignee: kst
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-06-07 12:07 UTC by Marc-Antoine Miville-Deschenes
Modified: 2010-08-14 14:15 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Proposed patch (11.99 KB, patch)
2006-06-07 17:53 UTC, Andrew Walker
Details
Proposed patch (27.87 KB, patch)
2006-06-09 21:46 UTC, Andrew Walker
Details
Proposed patch (41.64 KB, patch)
2006-06-10 00:54 UTC, Andrew Walker
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Marc-Antoine Miville-Deschenes 2006-06-07 12:07:43 UTC
Version:           1.2.0_devel (using KDE 3.1.4)
Installed from:    compiled sources
Compiler:          gcc version 3.3 20030304 (Apple Computer, Inc. build 1495)
OS:                Darwin (Power Macintosh) release 7.9.0

Markers are already useful to highlight events but I would
like to propose to extend some of their features.
1) It would be very useful to be able to use scalars (e.g., [vector-Max]) 
to define markers instead of only fixed values (e.g., 1000).
2) I would like to be able to use a vector to identify marker positions.
This vector would only be an array of marker position (not 0-1 and 1-0 edges).
3) It would be useful to be able to modify the linestyle and color of
markers (by default they are grey dash).
Comment 1 Andrew Walker 2006-06-07 17:53:58 UTC
Created attachment 16510 [details]
Proposed patch

Proposed changes to UI for part 3) of the bug report.
Comment 2 Andrew Walker 2006-06-07 20:06:25 UTC
SVN commit 549195 by arwalker:

CCBUG:128733 Make it possible to define the line style, width, and color for markers. Addresses part 3 of the bug report.

 M  +33 -7     kst2dplot.cpp  
 M  +16 -3     kst2dplot.h  
 M  +45 -1     kstplotdialog_i.cpp  
 M  +2 -1      kstplotdialog_i.h  
 M  +174 -30   plotdialog.ui  
Comment 3 Andrew Walker 2006-06-07 20:11:41 UTC
For part 2 would it be sufficient to add another checkbox item in the Automatic Marker Generation field so that the user can specify to use the vector values themselves for markers? This would restrict the user to a single vector, but this is already the case.
Comment 4 Andrew Walker 2006-06-07 20:15:55 UTC
For part 1 if the scalar value changes would you expect the marker position to change to reflect this?
Comment 5 Andrew Walker 2006-06-09 21:29:48 UTC
So part 2 would actually need another entry for specifiying the vector, as the current automatic marker generation takes a curve and not a vector.
Comment 6 Andrew Walker 2006-06-09 21:46:47 UTC
Created attachment 16539 [details]
Proposed patch

proposed UI change to allow vector to define marker values
Comment 7 Andrew Walker 2006-06-10 00:54:58 UTC
Created attachment 16541 [details]
Proposed patch

This addresses part 2 of the bug report
Comment 8 George Staikos 2006-06-10 01:52:11 UTC
  In general, looks good.
Comment 9 Andrew Walker 2006-06-12 18:19:20 UTC
SVN commit 550752 by arwalker:

CCBUG:128733 Allow user to specify vector with values to be used as markers

 M  +97 -55    eqdialogwidget.ui  
 M  +71 -8     kst2dplot.cpp  
 M  +9 -2      kst2dplot.h  
 M  +4 -1      ksteqdialog_i.cpp  
 M  +39 -12    kstplotdialog_i.cpp  
 M  +258 -226  plotdialog.ui  
Comment 10 Matthew Truch 2006-06-16 20:02:35 UTC
I'd like to 'vote' for part 3 of this bug report.  The ability to change the plot marker style.  I'm not like Mr. Ford, and I would like markers in more than just black (and more than just dashed).  
Comment 11 Andrew Walker 2006-06-16 20:16:37 UTC
Part 3 has already been addressed. Only part 1 remains.
Comment 12 Matthew Truch 2006-06-16 20:20:41 UTC
Reply to comment 11 from Andrew Walker

Ooops, I guess my kst is too old.  
Comment 13 Peter Kümmel 2010-08-14 14:15:00 UTC
Could be still open in Kst 1.