Bug 124794 - [PATCH] menus in disarray -- some rearrangement
Summary: [PATCH] menus in disarray -- some rearrangement
Status: RESOLVED INTENTIONAL
Alias: None
Product: kmail
Classification: Applications
Component: keys and menus (show other bugs)
Version: 1.9.1
Platform: unspecified Linux
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-04-02 23:08 UTC by Benno Schulenberg
Modified: 2009-12-25 22:55 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
patch that brings a bit more order to KMail's menus (10.09 KB, patch)
2006-04-02 23:10 UTC, Benno Schulenberg
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Benno Schulenberg 2006-04-02 23:08:25 UTC
Version:           1.9.1 (using KDE 3.5.2, Gentoo)
Compiler:          gcc version 3.4.6 (Gentoo Hardened 3.4.6, ssp-3.4.5-1.0, pie-8.7.9)
OS:                Linux (i686) release 2.6.16

Somewhere betweeen the 1.8 and 1.9 versions of KMail, the "Compact All Folders" item was removed from the "File" menu -- an item that I sometimes use.  At the same time the "Import Messages" item was added, which stole the "I" accelerator key from "Check Mail In" , which got the "C" as accelerator, freed by the removal of "Compact All Folders".

While making a patch to get that last item back in the "File" menu, I noticed that "Find Messages..." and "Find in Message..." are located both in the "Edit" and the "Tools" menu, but not in the "Folder" and "Message" menu, where I would expect them -- although the "Find Messages..." item _is_ present in the context menu when rightclicking on a folder.  In addition, several items in that same context menu are lacking from the "Folder" menu, and vice versa.

So the attached patch makes several changes to KMail's menus:
* readds "Compact All Folders" to the "File" menu,
* adds "Find Messages..." to the "Folder" menu,
* adds "Find in Message..." to the "Message" menu,
* removes these two from the "Edit" and "Tools" menu,
  (although they should probably stay in the "Edit" menu, as legacy)
* rearranges the "Folder" and folder context menus to become similar,
* adds the HTML and threading options to the folder context menu,
* changes some accelerator keys to be a bit more consistent,
* adds trailing dots to some menu items that should have them,
* and makes a few other tiny small adjustments.

The patch ignores KNode, as I don't use it.  It also doesn't add the "Move Folder To" item to the "Folder" menu, as I don't know how to do it -- but it should be there for similarity with the folder context menu.  The patch should also add the "Find in Message..." item to the message context menu, but I never use this one.
Comment 1 Benno Schulenberg 2006-04-02 23:10:00 UTC
Created attachment 15429 [details]
patch that brings a bit more order to KMail's menus
Comment 2 Jonathan Marten 2006-10-28 17:43:19 UTC
KDE-PIM bugs day: valid points, but should be a wishlist item
Comment 3 Thomas McGuire 2007-07-03 19:36:12 UTC
See also bug 124679
Comment 4 Björn Ruberg 2009-12-25 22:55:22 UTC
Please split in different bug reports. The folder contect menu is discussed in other bugs. kmail developer want only the most important features in the context menu - others go to the folder menu bar.