Bug 124317 - JJ: Use kdpf to show the document printed to a PDF file
Summary: JJ: Use kdpf to show the document printed to a PDF file
Alias: None
Product: kdeprint
Classification: Applications
Component: general (show other bugs)
Version: 4.0
Platform: Fedora RPMs Linux
: NOR wishlist
Target Milestone: ---
Assignee: KDEPrint Devel Mailinglist
Depends on:
Reported: 2006-03-26 19:39 UTC by Allen Winter
Modified: 2009-01-03 01:30 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:

kprinter.cpp patch for 3.5.5 (600 bytes, patch)
2007-07-04 14:10 UTC, Lion Vollnhals
kprintdialog.cpp patch for 3.5.5 (3.77 KB, patch)
2007-07-04 14:11 UTC, Lion Vollnhals
current print dialog design with "open afterwards" checkbox (26.66 KB, image/jpeg)
2007-07-04 14:12 UTC, Lion Vollnhals
open file when printing is finished in kdeprintd module - compile tested only - (8.38 KB, patch)
2007-07-04 16:03 UTC, Lion Vollnhals
revised patch, extract filename from kprintprocess command (8.45 KB, patch)
2007-07-05 02:10 UTC, Lion Vollnhals

Note You need to log in before you can comment on or make changes to this bug.
Description Allen Winter 2006-03-26 19:39:10 UTC
Version:            (using KDE KDE 3.5.1)
Installed from:    Fedora RPMs

A wish.

When printing to a PS or PDF file, it might be nice to prompt the user
if they would like to see that file in a viewer upon "print" completion.
You might have one of those "don't ask me again" checkboxes on the dialog.

But, I think this would be a nice convenience.

NOTE: PDFCreator on Windows launches acroread for you after the "print"
to the pdf file is complete.
Comment 1 Kurt Pfeifle 2007-01-09 05:24:55 UTC
Setting wishlist item to version 4.0 now...

Comment 2 Lion Vollnhals 2007-07-04 14:08:56 UTC

I am currently working on this.
I have put a checkbox (asking to open the file afterwards) under the existing preview checkbox. The current position looks good. But maybe a usability engineer knows a even better placement. (The checkbox is disabled/enabled as needed and the status is saved of course.)

A beta patch is ready but i am still having problems with
opening the .pdf afterwards. When finishPrinting in KPrinter is called
the output .pdf still does not exist. So we have to sleep before we
open the .pdf (with KRun for example). I am currently using KRun::runCommand("sleep 1 && kfmclient exec " + outputFileName()). But there really has to be a better way.

(I also removed a superfluous call to finishPrinting, so that finishPrinting is called only once.)

The patch is currently against KDE 3.5.5.
I am working on a version 4 one.
Comment 3 Lion Vollnhals 2007-07-04 14:10:49 UTC
Created attachment 21037 [details]
kprinter.cpp patch for 3.5.5
Comment 4 Lion Vollnhals 2007-07-04 14:11:48 UTC
Created attachment 21038 [details]
kprintdialog.cpp patch for 3.5.5

to be used with the kprinter.cpp patch
Comment 5 Lion Vollnhals 2007-07-04 14:12:44 UTC
Created attachment 21039 [details]
current print dialog design with "open afterwards" checkbox
Comment 6 Lion Vollnhals 2007-07-04 16:03:55 UTC
Created attachment 21040 [details]
open file when printing is finished in kdeprintd module - compile tested only -

combined patch. use printTerminated signal from KPrintProcess in
KDEPrintd::print to open output file. compile tested only (maybe
KPrintProcess::output is the wrong file). will test thoroughly later today.
Comment 7 Lion Vollnhals 2007-07-05 02:10:04 UTC
Created attachment 21045 [details]
revised patch, extract filename from kprintprocess command

add checkbox (asking to open the file afterwards if printing to file) to the
printer dialog (same as before). Two strings (still) need to be localised.
open file in kdeprintd module (as in the previous patch) when printTerminated
is signaled. the filename is extracted from the corresponding kprintprocess
Comment 8 John Layt 2009-01-03 01:30:43 UTC
KDEPrint in KDE3 is unmaintained and will have no more new features
implemented.  This request will never be implemented in KDEPrint as a result.  

In KDE4 the print dialog is provided by Qt and any issues will need to be raised directly with them.

Lion, sorry that your hard work was unable to be used.