Bug 123866 - Konsole sessions forget the encoding after terminal reset
Summary: Konsole sessions forget the encoding after terminal reset
Status: RESOLVED FIXED
Alias: None
Product: konsole
Classification: Applications
Component: general (show other bugs)
Version: 1.6
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Konsole Developer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-03-18 20:02 UTC by Karoly Lorentey
Modified: 2011-08-25 14:03 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In: 4.7
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karoly Lorentey 2006-03-18 20:02:01 UTC
Version:           1.6 (using KDE 3.5.1, Debian Package 4:3.5.1-4 (testing/unstable))
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.15.walrus-25

Try the following: start a new Konsole instance by

  LC_CTYPE=hu_HU.UTF-8

Verify that the encoding is correctly set by trying 
to input some accented characters from e.g. the Latin-1
charset.  (For example, you can cut and paste 
these: áéíóöúü.)

Next, set Settings > Encoding > Greek (cp1253).
Observe that the same characters as above are now 
replaced with question marks.  This is the expected
behaviour, as the Greek charset misses these 
characters.

Now run the standard 'reset' command.

According to Settings > Encoding, the encoding is 
still set to Greek, but the same test characters
are now inputtable, which indicates that we are back
to UTF-8.

Either the terminal initialization string should not 
replace the encoding, or the Encoding menu should be 
updated to reflect the change.
Comment 1 Kurt Hindenburg 2006-05-02 20:02:28 UTC
Yea, a 'reset' always send Konsole back to UTF-8; perhaps because I have  LC_ALL=en_US.utf8 system-wide.?!

Not sure how Konsole could catch this...

Comment 2 Kurt Hindenburg 2011-06-25 04:31:39 UTC
Git commit 27182ebbadb8bcf406cba74be1888125e54fe63f by Kurt Hindenburg.
Committed on 25/06/2011 at 06:26.
Pushed by hindenburg into branch 'master'.

Restore codec to profile setting or previous codec upon reset.

Previously, after typing in 'reset' or using 'Clear Scrollback & Reset',
the current codec is lost.

With this patch, typing in 'reset' will cause the codec to stay what
it was before the reset.  Using the 'Clear Scrollback & Reset' will
cause the codec to be set to the Profile setting.

This may get backported to 4.6.x
BUG: 123866
BUG: 273959
FIXED-IN: 4.7
REVIEW: 101565

M  +4    -0    src/SessionController.cpp     
M  +9    -1    src/Vt102Emulation.cpp     

http://commits.kde.org/konsole/27182ebbadb8bcf406cba74be1888125e54fe63f
Comment 3 Kurt Hindenburg 2011-08-25 14:03:55 UTC
Git commit 4c4b686a30a849af450cce7d140c8eafbf467627 by Kurt Hindenburg.
Committed on 25/06/2011 at 06:26.
Pushed by hindenburg into branch 'KDE/4.7'.

Restore codec to profile setting or previous codec upon reset.

Previously, after typing in 'reset' or using 'Clear Scrollback & Reset',
the current codec is lost.

With this patch, typing in 'reset' will cause the codec to stay what
it was before the reset.  Using the 'Clear Scrollback & Reset' will
cause the codec to be set to the Profile setting.

This may get backported to 4.6.x
BUG: 123866
BUG: 273959
FIXED-IN: 4.7
REVIEW: 101565
(cherry picked from commit 27182ebbadb8bcf406cba74be1888125e54fe63f)

M  +9    -1    src/Vt102Emulation.cpp
M  +4    -0    src/SessionController.cpp

http://commits.kde.org/konsole/4c4b686a30a849af450cce7d140c8eafbf467627