Bug 121371 - Missing display of EXIF infos in "Simple view"
Summary: Missing display of EXIF infos in "Simple view"
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Metadata-Exif (show other bugs)
Version: unspecified
Platform: openSUSE Linux
: NOR wishlist
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-02-04 18:07 UTC by krienke
Modified: 2017-08-13 07:26 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 0.9.0


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description krienke 2006-02-04 18:07:26 UTC
Version:           0.9 (using KDE KDE 3.5.0)
Installed from:    SuSE RPMs
Compiler:          gcc 4 
OS:                Linux

In the ExIF side tab in the image editor in the "simple view" of EXIF data there is not F-stop display and no information about the flash. I think both infos are very basic and should be displayed in the "simple" view as well. 

The are displayed in the "full" view.
Comment 1 caulier.gilles 2006-03-03 10:59:59 UTC
SVN commit 515268 by cgilles:

digikam from trunk : Metadata support using Exiv2 :

- New image properties sidebar tab named "Metadata" instead old "Exif". This area include :

* Standard Exif tags viewer.
* MarkerNote Exif tags viewer.
* IPTC records viewer.

- New capability to copy metadata in clipboard like text.
- New capability to print metadata.
- Tags name use the "user Friendly" conversion from Exiv2 instead the internal name provided by old Exif viewer based on libkexif.
- Capability to read metadata from CRW files (Canon RAW files)
- New class DMetadata to load/save metadata without loading image data. Actually JPEG, CRW, and PNG files are supported. About PNG (Exif and IPTC raw profiles generated by ImageMagick are supported.

To support new file formats (like NEF, MRW, TIFF, DNG, etc), new image file parsers must be added to Exiv2 library.

IMPORTANT: 

- Exiv2 do not support yet gettext for i18n rules. All informations in metadata viewers aren't yet i18n (tags name, tags values, and tags descriptions)
- Any tag names use internal Exiv2 name, not the user friendly text transformations. This point must be fixed in Exiv2 libs.

To 0.9.0, these tools are just metadata readers. Writting capabilities (metadata editors) will added later 0.9.0. The files in B.K.O directly or indirectly relevant of this commits are listed below :

*Pending:

103255
106103
115764
111560

*Partially fixed:

91812
96459
109253
110598
118501         

* To check before closing:

122264

* Fixed (can be closed):

103489
121371
105670
109319

CCMAIL: digikam-devel@kde.org,  Andreas Huggel <ahuggel@gmx.net>

CCBUGS: 103255, 106103, 115764, 111560, 91812, 96459, 109253, 110598, 118501, 122264, 103489, 121371, 105670, 109319


 M  +2 -1      libs/Makefile.am  
 M  +5 -4      libs/dimg/Makefile.am  
 M  +1 -1      libs/dimg/dimg.cpp  
 M  +1 -1      libs/dimg/dimg.h  
 M  +19 -1     libs/dimg/dimgloader.cpp  
 M  +4 -2      libs/dimg/dimgloader.h  
 M  +4 -61     libs/dimg/loaders/jpegloader.cpp  
 M  +5 -29     libs/dimg/loaders/pngloader.cpp  
 M  +2 -1      libs/dimg/loaders/rawloader.cpp  
 A             libs/dmetadata (directory)  
 A             libs/dmetadata/Makefile.am  
 A             libs/dmetadata/dmetadata.cpp   [License: GPL]
 A             libs/dmetadata/dmetadata.h   [License: GPL]
 A             libs/dmetadata/loaders (directory)  
 A             libs/dmetadata/loaders/Makefile.am  
 A             libs/dmetadata/loaders/dmetaloader.cpp   [License: GPL]
 A             libs/dmetadata/loaders/dmetaloader.h   [License: GPL]
 A             libs/dmetadata/loaders/jpegmetaloader.cpp   [License: GPL]
 A             libs/dmetadata/loaders/jpegmetaloader.h   [License: GPL]
 A             libs/dmetadata/loaders/pngmetaloader.cpp   [License: GPL]
 A             libs/dmetadata/loaders/pngmetaloader.h   [License: GPL]
 A             libs/dmetadata/loaders/rawmetaloader.cpp   [License: GPL]
 A             libs/dmetadata/loaders/rawmetaloader.h   [License: GPL]
 A             libs/dmetadata/loaders/tiffmetaloader.cpp   [License: GPL]
 A             libs/dmetadata/loaders/tiffmetaloader.h   [License: GPL]
 M  +3 -2      libs/imageproperties/Makefile.am  
 M  +82 -323   libs/imageproperties/imagepropertiesexiftab.cpp  
 M  +12 -25    libs/imageproperties/imagepropertiesexiftab.h  
 M  +19 -18    libs/imageproperties/imagepropertiessidebar.cpp  
 M  +10 -9     libs/imageproperties/imagepropertiessidebar.h  
 M  +27 -26    libs/imageproperties/imagepropertiessidebarcamgui.cpp  
 M  +2 -1      libs/imageproperties/imagepropertiessidebarcamgui.h  
 M  +16 -15    libs/imageproperties/imagepropertiessidebardb.cpp  
 M  +3 -1      libs/widgets/Makefile.am  
 A             libs/widgets/metadata (directory)  
 A             libs/widgets/metadata/Makefile.am  
 A             libs/widgets/metadata/exifwidget.cpp   [License: GPL]
 A             libs/widgets/metadata/exifwidget.h   [License: GPL]
 A             libs/widgets/metadata/iptcwidget.cpp   [License: GPL]
 A             libs/widgets/metadata/iptcwidget.h   [License: GPL]
 A             libs/widgets/metadata/makernotewidget.cpp   [License: GPL]
 A             libs/widgets/metadata/makernotewidget.h   [License: GPL]
 A             libs/widgets/metadata/mdkeylistviewitem.cpp   [License: GPL]
 A             libs/widgets/metadata/mdkeylistviewitem.h   [License: GPL]
 A             libs/widgets/metadata/metadatalistview.cpp   [License: GPL]
 A             libs/widgets/metadata/metadatalistview.h   [License: GPL]
 A             libs/widgets/metadata/metadatalistviewitem.cpp   [License: GPL]
 A             libs/widgets/metadata/metadatalistviewitem.h   [License: GPL]
 A             libs/widgets/metadata/metadatawidget.cpp   [License: GPL]
 A             libs/widgets/metadata/metadatawidget.h   [License: GPL]
 M  +24 -1     utilities/cameragui/cameraui.cpp  
Comment 2 caulier.gilles 2006-03-21 15:44:37 UTC
This file can be closed now

Gilles Caulier
Comment 3 krienke 2006-03-22 17:12:33 UTC
The problem with Nikon cameras and the missing aperture value in simple
exif display is still there. I think it could be easily fixed by just adding the FNumber Tag to the list of tags shown in simple view. This is because Nikon does not use the Aperture Tag used by other manufacturers but always the FNumber tag. exiv2 provides this tag so its only a matter of "to show" or "not to show". Because the aperture value is a quite important information  I think it should be shown.
Comment 4 krienke 2006-03-23 06:32:29 UTC
"Aperture value not shown" problem still not solved for Nikon cameras. See my comment from yesterday.
Comment 5 caulier.gilles 2006-03-23 18:54:19 UTC
I cannot see the FNumber tag with my nikon JPEG files. Where i must seen it ? in Exif or MakerNote view ?

Have you a sample file to test ?

Gilles Caulier
Comment 6 krienke 2006-03-23 20:41:06 UTC
The FNumber is not part of the makernotes its a regular tag and I can read it eg by the standard exif utility:

[krienke:~/www/tmp] exif Nikon_D70.jpg |grep FNumber
FNumber             |f/2,8

You can find a sample photo taken with my Nikon D70 in 
http://userpages.uni-koblenz.de/~krienke/tmp  

For the Nikon D200 and a Nikon_Coolpix 2000 of that I also have sample photos its the same (no Aperture tag but a FNumber tag).            
Comment 7 caulier.gilles 2006-03-24 12:22:28 UTC
SVN commit 522075 by cgilles:

digikam from trunk : metadata sidebar tab : Displaying FNumber tag value to the simple view if ApertureValue tag isn't present.

CCMAIL: digikam-devel@kde.org
CCBUGS: 121371


 M  +1 -0      exifwidget.cpp  
 M  +9 -8      makernotewidget.cpp  


--- trunk/extragear/graphics/digikam/libs/widgets/metadata/exifwidget.cpp #522074:522075
@@ -72,6 +72,7 @@
      "Sharpness",
      "LightSource",
      "Flash",
+     "FNumber",
      "-1"
 };
 
--- trunk/extragear/graphics/digikam/libs/widgets/metadata/makernotewidget.cpp #522074:522075
@@ -50,7 +50,7 @@
 namespace Digikam
 {
 
-static char* ExifHumanList[] =
+static char* MakerNoteHumanList[] =
 {
      "Make",
      "Model",
@@ -73,27 +73,28 @@
      "Sharpness",
      "LightSource",
      "Flash",
+     "FNumber",
      "-1"
 };
 
-static char* StandardExifEntryList[] =
+static char* ExifEntryListToIgnore[] =
 {
-     "Image",
-     "Photo",
      "GPSInfo",
      "Iop",
      "Thumbnail",
+     "Image",
+     "Photo",
      "-1"
 };
 
 MakerNoteWidget::MakerNoteWidget(QWidget* parent, const char* name)
                : MetadataWidget(parent, name)
 {
-    for (int i=0 ; QString(StandardExifEntryList[i]) != QString("-1") ; i++)
-        m_keysFilter << StandardExifEntryList[i];
+    for (int i=0 ; QString(ExifEntryListToIgnore[i]) != QString("-1") ; i++)
+        m_keysFilter << ExifEntryListToIgnore[i];
 
-    for (int i=0 ; QString(ExifHumanList[i]) != QString("-1") ; i++)
-        m_tagsfilter << ExifHumanList[i];
+    for (int i=0 ; QString(MakerNoteHumanList[i]) != QString("-1") ; i++)
+        m_tagsfilter << MakerNoteHumanList[i];
 }
 
 MakerNoteWidget::~MakerNoteWidget()
Comment 8 caulier.gilles 2006-03-24 12:24:18 UTC
and this file can be closed now ? (:=)))

Gilles Caulier
Comment 9 krienke 2006-03-24 13:40:48 UTC
Am Freitag, 24. März 2006 12:24 schrieb Gilles Caulier:
[bugs.kde.org quoted mail]

Let me think .... :-))  Yes of course,  works great now. 

Rainer