Bug 121144 - short keys activated by CTRL: Many duplicates
Summary: short keys activated by CTRL: Many duplicates
Alias: None
Product: konqueror
Classification: Applications
Component: khtml (show other bugs)
Version: unspecified
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
Depends on:
Reported: 2006-02-01 11:52 UTC by Wolfgang Rohdewald
Modified: 2006-02-07 14:50 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Note You need to log in before you can comment on or make changes to this bug.
Description Wolfgang Rohdewald 2006-02-01 11:52:33 UTC
Version:           3.5.1 (using KDE 3.5.1, Debian Package 4:3.5.1-1 (testing/unstable))
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.15

duplicates are generated if the underlying link is identical. On www.sbroker.de, many links say "javascript: void(0);". They all get the same short key although they do very different things.

If konqueror cannot differentiate them by looking at the script, it would be better to define a short key only for the first of several javascript calls.
Comment 1 Lubos Lunak 2006-02-07 14:50:25 UTC
SVN commit 506683 by lunakl:

Never consider two javascript links to be the same.
BUG: 121144

 M  +1 -1      khtmlview.cpp  

--- branches/KDE/3.5/kdelibs/khtml/khtmlview.cpp #506682:506683
@@ -2640,7 +2640,7 @@
             QString url = (*it).url;
             it = data.remove( it );
             // assign the same accesskey also to other elements pointing to the same url
-            if( !url.isEmpty()) {
+            if( !url.isEmpty() && !url.startsWith( "javascript:", false )) {
                 for( QValueList< AccessKeyData >::Iterator it2 = data.begin();
                      it2 != data.end();
                      ) {