Bug 120594 - Konqueror crashes when closed by Javascript ("window.close()" called)
Summary: Konqueror crashes when closed by Javascript ("window.close()" called)
Status: RESOLVED WORKSFORME
Alias: None
Product: konqueror
Classification: Applications
Component: searchbarplugin (show other bugs)
Version: 3.5
Platform: unspecified Linux
: NOR crash
Target Milestone: ---
Assignee: Arend van Beelen jr.
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-22 13:07 UTC by William Kendrick
Modified: 2007-02-12 23:55 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments
Backtrace of Konqueror crashing when closing a window via JavaScript (3.91 KB, text/plain)
2006-01-22 23:38 UTC, William Kendrick
Details
Simply example of JavaScript close link that causes Konqueror to crash (233 bytes, text/html)
2006-01-22 23:40 UTC, William Kendrick
Details

Note You need to log in before you can comment on or make changes to this bug.
Description William Kendrick 2006-01-22 13:07:39 UTC
Version:           3.5 (using KDE 3.5.0, Debian Package 4:3.5.0-3 (testing/unstable))
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.14-2-686

I've used a number of websites recently which pop up windows using JavaScript that contain additional information, and also a close button or link. e.g.:

  <input type="button" name="Close" value="   Close   " onClick="window.close();">

and:

  <a href="javascript:window.close()">Close Window</a>

In either case, clicking the JavaScript-based close button/link causes Konqueror to crash.  (I believe in earlier versions, e.g. 3.4.x, this did not happen, but I cannot be sure.)

Thanks!
Comment 1 Maksim Orlovich 2006-01-22 16:03:35 UTC
I can not reproduce this based on these instructions, please provide as much of:
a)backtrace
b)testcase
c)sample URL
as possible 
Comment 2 William Kendrick 2006-01-22 23:37:08 UTC
I will attach a backtrace.

The sites I was using that causes the crash (CafePress.com and MaxBounty.com) are a bit complicated, and in some cases require a login.

However, I was able to reproduce with a simple 2-line HTML file, attached.
(It is also currently available at: http://www.sonic.net/~nbs/khtml-js-close-crash-test.html )

Thank you!
Comment 3 William Kendrick 2006-01-22 23:38:38 UTC
Created attachment 14346 [details]
Backtrace of Konqueror crashing when closing a window via JavaScript
Comment 4 William Kendrick 2006-01-22 23:40:29 UTC
Created attachment 14347 [details]
Simply example of JavaScript close link that causes Konqueror to crash
Comment 5 William Kendrick 2006-01-22 23:44:23 UTC
Note: I tried clicking the "Created an attachment (id=14347)" link here in this bug at bugs.kde.org.  When I click the JavaScript close link, rather than the window closing or Konqueror crashing, I get a pop-up dialog: "Close window?"  However, if I right-click the link and open it in a new tab or new window, the JavaScript close link crashes Konqueror.  (It seems to matter whether the 'close' action will close the only Konqueror window/tab.)

Thanks and good luck!
Comment 6 Maksim Orlovich 2006-01-23 03:47:35 UTC
Your backtrace suggests that some "googlebar" plugin is at fault.
Comment 7 William Kendrick 2006-01-23 07:42:07 UTC
Ah, you're right!  I disabled the Google Toolbar extension for Konqueror and that seems to have helped.  I'll check for an upgrade and/or contact the author.

Thanks!
Comment 8 Thiago Macieira 2006-01-23 18:44:06 UTC
Pasting the backtrace for future reference:

[KCrash handler]
#4  0xb606fb69 in KHTMLPart::view () from /usr/lib/libkhtml.so.4
#5  0xb633d358 in PluginGoogleBar::testActivePart ()
   from /usr/lib/kde3/libgooglebarplugin.so
#6  0xb633e0fd in PluginGoogleBar::qt_invoke ()
   from /usr/lib/kde3/libgooglebarplugin.so
#7  0xb72c8c93 in QObject::activate_signal () from /usr/lib/libqt-mt.so.3
#8  0xb7f8d405 in KParts::PartManager::activePartChanged ()
   from /usr/lib/libkparts.so.2
#9  0xb7f91f7e in KParts::PartManager::setActivePart ()
   from /usr/lib/libkparts.so.2
#10 0xb66aaf08 in KonqViewManager::setActivePart ()
   from /usr/lib/libkdeinit_konqueror.so
#11 0xb66ab0aa in KonqViewManager::setActivePart ()
   from /usr/lib/libkdeinit_konqueror.so
#12 0xb7f964a6 in KParts::PartManager::removePart ()
   from /usr/lib/libkparts.so.2
#13 0xb66acbcc in KonqViewManager::removePart ()
   from /usr/lib/libkdeinit_konqueror.so
#14 0xb7f8c1f3 in KParts::Part::~Part () from /usr/lib/libkparts.so.2
#15 0xb7f9345d in KParts::ReadOnlyPart::~ReadOnlyPart ()
   from /usr/lib/libkparts.so.2
#16 0xb60a7d29 in KHTMLPart::~KHTMLPart () from /usr/lib/libkhtml.so.4
#17 0xb72c5c7f in QObject::event () from /usr/lib/libqt-mt.so.3
#18 0xb725e698 in QApplication::internalNotify () from /usr/lib/libqt-mt.so.3
#19 0xb725e8b6 in QApplication::notify () from /usr/lib/libqt-mt.so.3
#20 0xb79308ae in KApplication::notify () from /usr/lib/libkdecore.so.4
#21 0xb71ee5e5 in QApplication::sendEvent () from /usr/lib/libqt-mt.so.3
#22 0xb725fccc in QApplication::sendPostedEvents ()
   from /usr/lib/libqt-mt.so.3
#23 0xb725fdf9 in QApplication::sendPostedEvents ()
   from /usr/lib/libqt-mt.so.3
#24 0xb7201812 in QEventLoop::processEvents () from /usr/lib/libqt-mt.so.3
#25 0xb7276da2 in QEventLoop::enterLoop () from /usr/lib/libqt-mt.so.3
#26 0xb7276ccb in QEventLoop::exec () from /usr/lib/libqt-mt.so.3
#27 0xb725d225 in QApplication::exec () from /usr/lib/libqt-mt.so.3
#28 0xb66d2fac in kdemain () from /usr/lib/libkdeinit_konqueror.so
#29 0xb7fbc524 in kdeinitmain () from /usr/lib/kde3/konqueror.so
Comment 9 William Kendrick 2006-01-23 18:49:33 UTC
Sadly, upgrading to the latest version of Google Suggest Toolbar, 0.61 (released August 2005), did not appear to help.
Comment 10 Maksim Orlovich 2006-01-23 18:50:38 UTC
Thiago: different plugin:
[maksim@treetop Mail]$ cat ~/kde3/kdeaddons/konq-plugins/searchbar/Makefile.am |grep LT
kde_module_LTLIBRARIES = libsearchbarplugin.la

I don't think we have the googlebar thingie in SVN.
Comment 11 William Kendrick 2006-01-23 19:00:16 UTC
Ah, ok.  Here's where one can find it: http://sourceforge.net/projects/googlebar

I'll contact the developer directly.  Feel free to close this bug.  Sorry to waste your time!
Comment 12 tkaitchuck 2006-03-03 23:33:46 UTC
I have another backtrace of what appears to be the same bug on 3.5.1 However this one occurs when the javascript is attempting to close the main (only) window. Knoqueror prompts if it should actually close, this is the trace that comes up when I clicked "yes".


Using host libthread_db library "/lib/tls/libthread_db.so.1".
...
[Thread debugging using libthread_db enabled]
[New Thread -1222617408 (LWP 10428)]
...
[KCrash handler]
#5  0xb60eb4be in KJS::Value::operator= () from /usr/lib/libkjs.so.1
#6  0xb60eb50c in KJS::ExecState::clearException () from /usr/lib/libkjs.so.1
#7  0xb6383cb5 in EmbedLiveConnect::EmbedLiveConnect ()
   from /usr/lib/libkhtml.so.4
#8  0xb63c3568 in EmbedLiveConnect::toString () from /usr/lib/libkhtml.so.4
#9  0x4ef60076 in QObject::event () from /usr/lib/libqt-mt.so.3
#10 0x4eef8ad8 in QApplication::internalNotify () from /usr/lib/libqt-mt.so.3
#11 0x4eef8cf6 in QApplication::notify () from /usr/lib/libqt-mt.so.3
#12 0xb7911d4e in KApplication::notify () from /usr/lib/libkdecore.so.4
#13 0x4ee88a25 in QApplication::sendEvent () from /usr/lib/libqt-mt.so.3
#14 0x4eee9dcc in QEventLoop::activateTimers () from /usr/lib/libqt-mt.so.3
#15 0x4ee9c79c in QEventLoop::processEvents () from /usr/lib/libqt-mt.so.3
#16 0x4ef111e2 in QEventLoop::enterLoop () from /usr/lib/libqt-mt.so.3
#17 0x4ef1110b in QEventLoop::exec () from /usr/lib/libqt-mt.so.3
#18 0x4eef7665 in QApplication::exec () from /usr/lib/libqt-mt.so.3
#19 0xb714df9c in kdemain () from /usr/lib/libkdeinit_konqueror.so
#20 0xb7fa2524 in kdeinitmain () from /usr/lib/kde3/konqueror.so
#21 0x0804e1d6 in ?? ()
#22 0x00000002 in ?? ()
#23 0x080972f8 in ?? ()
#24 0x00000001 in ?? ()
#25 0x00000000 in ?? ()
Comment 13 Eric Kjeldergaard 2006-09-01 16:03:18 UTC
As William said, not a KDE issue.  The second backtrace is unrelated to this bug.
Comment 14 Nerijus Baliūnas 2006-11-30 04:03:33 UTC
My konqueror 3.5.5 crashes in such scenario:
Open http://freshmeat.net/projects/webcbq/
Press middle mouse button on a picture (screenshot)
a new window opens (http://freshmeat.net/screenshots/54393/58429/)
Press "close" link at the bottom of the page.
Comment 15 William Kendrick 2007-01-12 18:02:28 UTC
This still happens, even without the Google bar installed (I'm running Konq 3.5.5 on a new Kubuntu system).  Nerijus's example ('close' link on screenshot page at freshmeat.net) crashes my Konqueror, as well.
Comment 16 Magnus 2007-01-27 13:08:57 UTC
I'm unable to reproduce this in KDE 3.5.6 (Konqueror 3.5.6) with the freshmeat-link. Can you try with 3.5.6? You'll find Kubuntu packages at http://kubuntu.org/announcements/kde-356.php 
Comment 17 William Kendrick 2007-02-01 04:07:49 UTC
Confirmed that it no longer happens for me in Konqueror 3.5.6 on Kubuntu (without Googlebar installed). Thanks!
Comment 18 Nerijus Baliūnas 2007-02-12 23:55:15 UTC
It no longer happens with 3.5.6 in Fedora.