Bug 120562 - Add Tango patches to KDE (kdelibs, kdebase)
Summary: Add Tango patches to KDE (kdelibs, kdebase)
Status: RESOLVED FIXED
Alias: None
Product: kdelibs
Classification: Frameworks and Libraries
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: Stephan Kulow
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-01-21 16:55 UTC by Thomas Fischer
Modified: 2006-08-28 13:40 UTC (History)
4 users (show)

See Also:
Latest Commit:
Version Fixed In:

Attachments
kdelibs patch (7.89 KB, patch)
2006-08-09 16:53 UTC, Lubos Lunak 		Details
View All Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Fischer 2006-01-21 16:56:03 UTC 
Version:           3.5.0 (using KDE KDE 3.5.1)
Installed from:    Gentoo Packages
OS:                Linux

The Tango Desktop Project [1] provides special patches for KDE 3.5 [2] to improve the integration of their icons into the desktop. The patches are rather minor and have to be applied to kdebase and kdelibs.
Is it possible to add these patches to 3.5.1 or following minor releases?

[1] http://tango-project.org
[2] http://tango-project.org/Installation#Patches_to_KDE
Comment 1 Maksim Orlovich 2006-01-21 17:12:00 UTC 
That would break the string freeze...
Comment 2 Thomas Fischer 2006-01-21 19:12:12 UTC 
How about scheduling this patch for future 3.5.x releases?
Comment 3 Stephan Kulow 2006-01-21 19:55:40 UTC 
let's see how many votes this gets. Feel free to add the bug link to the tango-project wiki. I'm not interested per se - as it doesn't do more than adding strings from what I see.
Comment 4 Thiago Macieira 2006-01-21 19:56:52 UTC 
It's up to the translators, actually, to decide if we should include it in 3.5.2.
Comment 5 Jean-Christophe 2006-01-31 14:24:06 UTC 
*** This bug has been confirmed by popular vote. ***
Comment 6 Funda Wang 2006-05-07 09:31:24 UTC 
How is this going?
Comment 7 Rex Dieter 2006-05-07 19:58:18 UTC 
Due to lack of comments, I'd have to say nothing (so far).
Comment 8 Stalwart 2006-05-07 20:00:43 UTC 
We can flood a bit =]
Comment 9 Jure Repinc 2006-05-08 09:12:41 UTC 
I think 7 strings are not a problem. Slovenian translation team is fine with adding them and they will get translated.
Comment 10 Funda Wang 2006-06-04 08:11:09 UTC 
Should we do it now?
Comment 11 Carsten Niehaus 2006-06-04 11:21:43 UTC 
Well, now or never I guess... Who is going to do this?
Comment 12 Peter Rockai 2006-06-04 11:41:35 UTC 
Well, there is another problem than strings with those patches. That being, most users will have no icons in most of those categories and that generally leads only to confusion. So applying them in their current state will do a mis-service to majority of our users. I may be wrong, but both from code and from trying to remove all filesystem entries from my index.theme seems that the problem is there. I am presented with entries in the combobox that are completely empty. Suboptimal at best.

Adding code that hides empty icon categories would probably solve this, please consider doing that before including the patch in a KDE release.
Comment 13 Lubos Lunak 2006-08-09 16:53:30 UTC 
Created attachment 17308 [details]
kdelibs patch

I didn't know we were so pedantic about such details. Anyway, here is the
kdelibs patch updated to include comment #12, kdebase patch remains the same.
Comment 14 Lubos Lunak 2006-08-09 17:29:40 UTC 
Hmm, before I commit, looking at the icon theme spec, which lists only 4 contexts, where exactly does it say we should add these new ones?
Comment 15 James Richard Tyrer 2006-08-27 21:40:17 UTC 
The new contexts are in the Icon Naming Spec:

http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html
Comment 16 Lubos Lunak 2006-08-28 13:40:18 UTC 
*** Bug has been marked as fixed ***.