Bug 117603 - Google Video problem seeing bar
Summary: Google Video problem seeing bar
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: khtml (show other bugs)
Version: 3.5
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-12-03 17:58 UTC by Jordi Pina
Modified: 2006-09-29 00:48 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jordi Pina 2005-12-03 17:58:05 UTC
Version:           3.5 (using KDE 3.5.0, Kubuntu Package 4:3.5.0-0ubuntu0breezy1 breezy)
Compiler:          Target: i486-linux-gnu
OS:                Linux (i686) release 2.6.12-10-386

If I look a video in Google Video I can't see the down bar.

Take a look at this screenshot:

http://img443.imageshack.us/img443/6909/down7by.png

I hope it helps!
Comment 1 Thiago Macieira 2005-12-03 21:37:59 UTC
Confirmed. This is caused by the fact that we try to load a VBScript and we shouldn't.

We have a patch for this, but it needs some testing.
Comment 2 Giovanni Venturi 2006-04-06 22:47:26 UTC
This happen also to me with KDE 3.5.2 from SVN and qt 3.3.6
Comment 3 Felix Seeger 2006-09-17 23:52:35 UTC
This works here (if there are no javascript errors preventing the movie to play) Using kde 3.5.4
Comment 4 Maksim Orlovich 2006-09-29 00:48:04 UTC
SVN commit 589919 by orlovich:

- Make sure we always size the plugin:
    - Fixes google videos showing up.
    - Fixes acroread in background tab.
 
- Make sure to notify the plugin directly of size changes:
    - Fixes resizing of google videos
    - Makes sizing of acroread more reliable
    
BUG:117603
BUG:125076
BUG:118038

... And potentially a couple others, will double-check.


 M  +5 -0      nspluginloader.cpp  
 M  +1 -0      nspluginloader.h  
 M  +1 -5      viewer/nsplugin.cpp  
 M  +0 -1      viewer/nsplugin.h  


--- branches/KDE/3.5/kdebase/nsplugins/nspluginloader.cpp #589918:589919
@@ -120,6 +120,11 @@
   kdDebug() << "NSPluginInstance(client)::resizeEvent" << endl;
 }
 
+void NSPluginInstance::showEvent(QShowEvent *event)
+{
+  EMBEDCLASS::showEvent(event);
+  resizePlugin(width(), height());
+}
 
 /*******************************************************************************/
 
--- branches/KDE/3.5/kdebase/nsplugins/nspluginloader.h #589918:589919
@@ -56,6 +56,7 @@
 
 protected:
     void resizeEvent(QResizeEvent *event);
+    void showEvent  (QShowEvent *);
     void windowChanged(WId w);
     class NSPluginLoader *_loader;
     bool shown;
--- branches/KDE/3.5/kdebase/nsplugins/viewer/nsplugin.cpp #589918:589919
@@ -588,7 +588,6 @@
    : DCOPObject(), QObject( parent, name ) 
 {
     Q_UNUSED(embed);
-   _firstResize = true;
    _visible = false;
    _npp = privateData;
    _npp->ndata = this;
@@ -988,10 +987,7 @@
 
    resizeWidgets(XtWindow(_form), _width, _height);
 
-   if (_firstResize) {
-      _firstResize = false;
-      setWindow();
-   }
+   setWindow();
 
    kdDebug(1431) << "<- NSPluginInstance::resizePlugin" << endl;
 }
--- branches/KDE/3.5/kdebase/nsplugins/viewer/nsplugin.h #589918:589919
@@ -220,7 +220,6 @@
 
   bool _destroyed;
   bool _visible;
-  bool _firstResize;
   void addTempFile(KTempFile *tmpFile);
   QPtrList<KTempFile> _tempFiles;
   NSPluginCallbackIface_stub *_callback;