Bug 117068 - 'Show windows from all screens' behaviour
Summary: 'Show windows from all screens' behaviour
Status: RESOLVED FIXED
Alias: None
Product: kicker
Classification: Plasma
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR normal
Target Milestone: ---
Assignee: Aaron J. Seigo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-25 18:47 UTC by Matt Biggs
Modified: 2005-12-01 18:13 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Biggs 2005-11-25 18:47:29 UTC
Version:            (using KDE KDE 3.5.0)
Installed from:    Gentoo Packages
OS:                Linux

Using dual screens and xinerama, the 'Show windows from all screens' behaves the opposite way round. 

When ticked, windows placed on the second screen do NOT show up in the 1st screens tasklist. When unticked, all windows appear in the 1st screens tasklist. 

When this option is ticked, the only way to view all windows, is to place a second panel with its own seperate tasklist on it in the 2nd monitor view.

Surely this behavious should be the opposite way around?
Comment 1 Aaron J. Seigo 2005-11-25 19:57:12 UTC
yes, it should be. however, i no longer have a xinerama machine to test this on. 

i don't see any changes in the code that should cause problems, but this will have to be confirmed and if necessary debugged on a xinerama machine.
Comment 2 Matt Biggs 2005-11-25 20:00:05 UTC
If you need me to try/test/debug anything, please let me know. I'll be more than happy to. 

This only started happening as of 3.5. 

3.4 use to work as expected.
Comment 3 Peter Krenesky 2005-11-29 20:01:00 UTC
I'm also seeing this in 3.5

kubuntu / breezy badger
Comment 4 Aaron J. Seigo 2005-12-01 18:13:28 UTC
SVN commit 484727 by aseigo:

when this was converted to kconfigxt, the logic of "show windows from
all screens" was reversed, but the GUI was not changed. now the logic is
correct.
BUG:117068


 M  +4 -3      kcmtaskbar.cpp  
 M  +2 -2      kcmtaskbarui.ui  


--- branches/KDE/3.5/kdebase/kcontrol/taskbar/kcmtaskbar.cpp #484726:484727
@@ -66,8 +66,7 @@
            TaskBarSettings::haloText() == m_haloText &&
            TaskBarSettings::showButtonOnHover() == m_showButtonOnHover;
 }
-#include <iostream>
-using namespace std;
+
 void TaskbarAppearance::alterSettings() const
 {
     TaskBarSettings::self()->setDrawButtons(m_drawButtons);
@@ -165,7 +164,7 @@
     if (!QApplication::desktop()->isVirtualDesktop() ||
         QApplication::desktop()->numScreens() == 1) // No Ximerama
     {
-        m_widget->kcfg_ShowCurrentScreenOnly->hide();
+        m_widget->showAllScreens->hide();
     }
 
     KAboutData *about = new KAboutData(I18N_NOOP("kcmtaskbar"),
@@ -242,10 +241,12 @@
     KCModule::load();
     slotUpdateComboBox();
     updateAppearanceCombo();
+    m_widget->showAllScreens->setChecked(!TaskBarSettings::self()->showCurrentScreenOnly());
 }
 
 void TaskbarConfig::save()
 {
+    TaskBarSettings::self()->setShowCurrentScreenOnly(!m_widget->showAllScreens->isChecked());
     int selectedAppearance = m_widget->appearance->currentItem();
     if (selectedAppearance < m_appearances.count())
     {
--- branches/KDE/3.5/kdebase/kcontrol/taskbar/kcmtaskbarui.ui #484726:484727
@@ -41,7 +41,7 @@
                 </property>
                 <widget class="QCheckBox" row="2" column="0" rowspan="1" colspan="3">
                     <property name="name">
-                        <cstring>kcfg_ShowCurrentScreenOnly</cstring>
+                        <cstring>showAllScreens</cstring>
                     </property>
                     <property name="text">
                         <string>Show windows from all sc&amp;reens</string>
@@ -311,7 +311,7 @@
 <tabstops>
     <tabstop>kcfg_ShowAllWindows</tabstop>
     <tabstop>kcfg_SortByDesktop</tabstop>
-    <tabstop>kcfg_ShowCurrentScreenOnly</tabstop>
+    <tabstop>showAllScreens</tabstop>
     <tabstop>kcfg_ShowOnlyIconified</tabstop>
     <tabstop>kcfg_ShowIcon</tabstop>
     <tabstop>kcfg_ShowWindowListBtn</tabstop>