Bug 116124 - [test case] only honors height tag of a CSS class for a TR for first TR with the class
Summary: [test case] only honors height tag of a CSS class for a TR for first TR with ...
Status: RESOLVED FIXED
Alias: None
Product: konqueror
Classification: Applications
Component: khtml (show other bugs)
Version: unspecified
Platform: Debian testing Linux
: NOR normal
Target Milestone: ---
Assignee: Konqueror Developers
URL:
Keywords:
: 118411 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-11-11 12:32 UTC by Joost Yervante Damad
Modified: 2012-01-13 06:50 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
Test case attached (714 bytes, text/html)
2005-11-11 16:29 UTC, Tommi Tervo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joost Yervante Damad 2005-11-11 12:32:31 UTC
Version:            (using KDE KDE 3.4.2)
Installed from:    Debian testing/unstable Packages
Compiler:          gcc-4.0.2 
OS:                Linux

Konqueror does not handle the CSS height attribute for TR's correctly.

How to reproduce (300pt is just an arbitrary value to clearly show it):

tr.jaar {
        height: 300pt;
}

Now create a table with 2 TR's with class "jaar", and watch how only only
the first TR has the correct 300pt height.

Also for reference, I use a thead with a different class before the 2 TR's.

In total the "nearly" minimal testcase:

<html>
<head>
	<link title="stylesheet" rel="stylesheet" href="1.css" type="text/css" />
</head>
<body>
<table class="jaar">
	<caption>jaar</caption>
	<tr class="jaar">
		<td colspan="2" class="empty">fall</td>
	</tr>
	<tr class="jaar">
		<td colspan="2" class="empty">winter</td>
	</tr>
</table>
</body>

with 1.css:

body {
        color: black;
        background-color: white;
        padding: 0px;
        margin: 0 12pt;
}

table.jaar {
        background: #F0F080;
        border-collapse: collapse;
        empty-cells: show;
        border: 1px solid black;
        text-align: center;
}

td.empty {
        border: 1px solid black;
        font-style: italic;
}

tr.jaar {
        height: 300pt;
}
Comment 1 Tommi Tervo 2005-11-11 16:29:32 UTC
Created attachment 13388 [details]
Test case attached
Comment 2 Maksim Orlovich 2005-12-24 19:09:56 UTC
*** Bug 118411 has been marked as a duplicate of this bug. ***
Comment 3 Germain Garand 2006-07-02 19:12:44 UTC
Maksim is right, those are fixed by r557184
Comment 4 Tommi Tervo 2006-07-02 20:55:20 UTC
Bottom of the winter cell is not rendered. 
Comment 5 Germain Garand 2006-07-02 22:24:20 UTC
It's an unrelated bug... the border is there, but you can't scroll to it if it doesn't fit on screen because the doc height is not correctly calculated.
I'd suspect the border-collapse style is responsible.
Most probably, the collapsed border height is subtracted twice or something along those lines.
I'll have a look later.
Comment 6 James Spahlinger 2008-04-19 13:54:29 UTC
Bug still fixed in 4.0.3

Unrelated bug about the bottom border also appears fixed.

Using Gentoo Linux ~x86 (testing in gentoo lingo). KDE 4.0.3 and the majority of packages compiled using gcc 4.3.0.
Comment 7 FiNeX 2008-04-25 13:37:54 UTC
The initial reported bug (tr width not respected) has been fixed on both kde 3.5.9 AND trunk (revision 800924). On both the bottom border is not rendered. Shall we open a new bugreport about this problem and close this?
Comment 8 Gérard Talbot (no longer involved) 2011-06-25 21:03:44 UTC
FiNeX,

As far as I can see with Konqueror 4.6.4, the initial reported bug (tr height not respected) has been fixed.

Gérard
Comment 9 Gérard Talbot (no longer involved) 2011-09-02 02:59:34 UTC
The original issue with this bug report has been FIXED.

This testcase

CSS Test: Height applied to elements with 'display' set to 'table-row'
http://test.csswg.org/suites/css2.1/latest/html4/height-applies-to-004.htm

confirms it too.

The original testcase (with fall and winter text) declares 'border-collapse: collapse' for reasons that have nothing to do with height specification of table row. The original testcase declares 'empty-cells: show;' when show is already the initial value anyway. 

The original testcase misuses colspan="2":

<table class="jaar">
        <caption>jaar</caption>
        <tr class="jaar">
                <td colspan="2" class="empty">fall</td>
        </tr>
        <tr class="jaar">
                <td colspan="2" class="empty">winter</td>
        </tr>
</table>

The colspan attribute specification colspan="2" is going to be ignored; this colspan="2" attribute specification may be valid HTML4 code but it is not compliant with the HTML4 spec.

As far as I am concerned, this bug should be RESOLVED as FIXED.

The collapsed border height issue is another distinct, separate issue and should be file in another bug report.

Gérard
Comment 10 Gérard Talbot (no longer involved) 2012-01-13 06:50:15 UTC
Resolving as FIXED