Bug 115850 - Remove all the Image tools menu entries when unchecking the tools in Settings->Configure ShowFoto...
Summary: Remove all the Image tools menu entries when unchecking the tools in Settings...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Showfoto-Plugins (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-11-07 11:33 UTC by Tung NGUYEN
Modified: 2022-02-04 22:09 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In: 5.7.0

Attachments
Add an attachment

Note You need to log in before you can comment on or make changes to this bug.
Description Tung NGUYEN 2005-11-07 11:33:33 UTC 
Version:           0.3.0 (packaged with DigiKam 0.8.0-beta2) (using KDE KDE 3.4.2)
Installed from:    Compiled From Sources
OS:                Linux

When unchecking the Image Plugins in Settings->Configure ShowFoto..., their menu entries are not removed in the ShowFoto main menu and if you re-check them then the menu entries are displayed twice...
Comment 1 caulier.gilles 2005-11-07 12:05:33 UTC 
SVN commit 478627 by cgilles:

Unload image plugins list properly before to reload it.
CCBUG : 115850

 M  +2 -2      showfoto.cpp  


--- trunk/extragear/graphics/digikam/showfoto/showfoto.cpp #478626:478627
@@ -89,6 +89,7 @@
 ShowFoto::ShowFoto(const KURL::List& urlList)
         : KMainWindow( 0, "Showfoto" )
 {
+    m_currentItem            = 0;
     m_itemsNb                = 0;
     m_splash                 = 0;
     m_BCGAction              = 0;
@@ -98,7 +99,6 @@
     m_fullScreenHideThumbBar = true;
     m_config                 = kapp->config();
     m_config->setGroup("ImageViewer Settings");
-    m_currentItem = 0;
 
     if(m_config->readBoolEntry("ShowSplash", true) &&
        !kapp->isRestored())
@@ -1271,9 +1271,9 @@
     if (setup.exec() != QDialog::Accepted)
         return;
 
+    unLoadPlugins();
     m_imagePluginLoader->loadPluginsFromList(setup.pluginsPage_->getImagePluginsListEnable());
     m_config->sync();
-    unLoadPlugins();
     loadPlugins();
     applySettings();
Comment 2 caulier.gilles 2017-07-09 13:26:02 UTC 
Since digiKam 5.2.0, all image editor plugins have been removed and embed as
well in image editor/showfoto implementation. There is no more run-time loading
of plugin libraries.

Gilles Caulier