Version: (using KDE KDE 3.4.3) Installed from: SuSE RPMs OS: Linux As you can see here http://www.openoffice.org/nonav/issues/showattachment.cgi/31018/image-file-dialog.png The file-dialog can get too wide (doesn't fit on screen), if there are too many filters defined. The problem doesn't exists on the gnome file-dialog.
Do you have the original issue number of OpenOffice.org? As for the problem, I suppose that somehow one of the squeeze functions of the class KStringHandler must be used. (See KBabel's bug #115296, which is a bout a non-editable QComboBox with a similar problem.) (By the way, if you are the reporter, you do not need to added yourself again in the CC list.) Have a nice day!
The original OpenOffice issue can be found at: http://www.openoffice.org/issues/show_bug.cgi?id=56972 So who do you think has to call KStringHandler::csqueeze()? The visual class developers of OpenOffice or is it a bug in KDEs kfile class? Both?
On Monday 31 October 2005 01:09, wegmann@psi.co.at wrote: (...) > http://www.openoffice.org/issues/show_bug.cgi?id=56972 Thank you! > > So who do you think has to call KStringHandler::csqueeze()? > The visual class developers of OpenOffice or is it a bug > in KDEs kfile class? Both? I would say that the KDE file dialog was not meant for such a long extension list. So at least there is a bug there, as the file dialog should avoid overwide filter entries. However I do not think that it will be done for KDE3, as for example KOffice is making dirty tricks with the filter list, so I suppose that, internally, we cannot have suddenly two filter lists: a list with the long uncensored filter names and a list of squeezed filter names. So until KDE supports the needed feature, I would think that OOo should avoid to create such wide entries. Have a nice day!
Isn't it possible to simply set a maximum width for the KComboBox (KFileFilter)? That has a bad side-effect: If someone adds a filter line that won't fit, nobody would be able to read the whole line. But I think that's better, than to have a file-dialog that won't fit on your screen.
On Tuesday 01 November 2005 04:13, wegmann@psi.co.at wrote: (...) > Isn't it possible to simply set a maximum width for the KComboBox > (KFileFilter)? I had tried to find that for the list box but I have no idea how to do it. (However I am not an expert in the UI side of Qt.) > That has a bad side-effect: If someone adds a filter line > that won't fit, nobody would be able to read the whole line. Yes, but KDE has normally no such long line, as we only display to the user a generic text and not all the extensions. > But I think > that's better, than to have a file-dialog that won't fit on your screen.
Created attachment 13255 [details] this patch doesn't fix the bug Here is a fix for this bug. It's a diff to the SuSE 10.0 kdelibs3-3.4.2-24 package (Level "b").
On Thursday 03 November 2005 00:02, wegmann@psi.co.at wrote: (...) > --> (http://bugs.kde.org/attachment.cgi?id=13255&action=view) > this patch fixes the bug > > Here is a fix for this bug. > It's a diff to the SuSE 10.0 kdelibs3-3.4.2-24 package (Level "b"). I cannot test the patch right now. But I fear that used that way, the user cannot increase the width of the dialog as he wants. Have a nice day!
Created attachment 13263 [details] patched version of the file dialog Well ... my patch breaks the layout somewhat. The OK and Cancel buttons - as well as the preview checkbox - are no longer visible (and can't be made visible through resizing). :-( Besides maximumWidth has to be set to some reasonable value.
Created attachment 13264 [details] this patch fixes the bug (really :) Calling setMaximumWidth(600) in the constructor of the KFileFilterCombo class fixes the problem.
Something like setSizePolicy( QSizePolicy( QSizePolicy::Expanding, QSizePolicy::Fixed )); would be more appropriate.
I don't understand, why I would want to set the horizontal SizePolizy::Expanding, when the expanding KComboBox is actually the problem here. The solution (apart from the OO people to set a reasonable file-filter) is IMHO to set a maximumWidth, so the KFileFilter doesn't get larger than my screen (1280x1024).
Created attachment 13635 [details] patched file dialog in kword I object to this patch; it gives a strange layout when the user makes the file dialog larger so that the location and filter combos can use more than 600 pixels. Any hardcoded value is wrong anyway; it would be a better idea to use the desktop size. And setting the max size on both combos would avoid the strange effect in my screenshot... but even then, this doesn't feel like the right solution. I don't understand why the OOo code sets all those extensions in the *description* of the filter... KFileDialog certainly allows to use extensions without showing them in the description, why not just filter out the extensions from the description?
On Thursday 24 November 2005 17:25, David Faure wrote: (...) > KFileDialog certainly allows to use > extensions without showing them in the description, why not just filter out > the extensions from the description? I had the same idea too but I have not told it because I could not much see the impact on translations. Have nice day!
I cannot vouch for the source of the problem (kfilter...), but as a symptom, this problem is not isolated to open office as seems to be the thinking from reading the log. I get this from konqueror (for example reading/printing this page), or double clicking on a 10 line text file (named xxx.txt) and file/print ing it. I would be happy to try things, or send you information if you feed me things to do. It does this reliably - every time. webclark at rochester dot rr dot com
I forgot to include... I am running Suse 10.2, kde 3.5.5 "release 45"
Nevermind... 139866 is a duplicate and directly addresses the suse 10.2 problem.
Moving from "kio/kfile" component to "kfile" product, helps sorting out duplicates.
*** This bug has been marked as a duplicate of bug 163456 ***