Bug 113808 - Tags view: can not change the tag icon with the contextual menu "Edit Tag Properties..." after setting a photo as tag thumbnail.
Summary: Tags view: can not change the tag icon with the contextual menu "Edit Tag Pro...
Status: RESOLVED FIXED
Alias: None
Product: digikam
Classification: Applications
Component: Usability-Menus (show other bugs)
Version: 0.8.0
Platform: Compiled Sources Linux
: NOR normal
Target Milestone: ---
Assignee: Digikam Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-10-03 22:11 UTC by Tung NGUYEN
Modified: 2017-08-02 21:08 UTC (History)
1 user (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tung NGUYEN 2005-10-03 22:11:58 UTC
Version:           0.8.0-beta2 (using KDE KDE 3.4.2)
Installed from:    Compiled From Sources
OS:                Linux

For exemple:
- In the Tags view, set a Photo1 as a Tag1 thumbnail.
- Now, select Tag1 and "Edit Tag Properties..." it.
- Click on the icon button and select a different icon.
- Click on OK to accept the Tag1 edition.

=> nothing happens, Tag1 keeps always the Photo1 icon (even after DigiKam restart).
Comment 1 Renchi Raju 2005-10-04 10:07:02 UTC
SVN commit 467063 by pahlibar:

kde > 3.3.x allows us to lock out the "other" icon select
option. use it. 

Its no longer possible in 0.8.x to set icons through the 
kicondialog. use the assign tag thumbnail or drag-and-drop
a file to assign thumbnail

BUGS: 113808


 M  +15 -0     tagcreatedlg.cpp  


--- trunk/extragear/graphics/digikam/digikam/tagcreatedlg.cpp #467062:467063
@@ -21,6 +21,7 @@
 #include <klocale.h>
 #include <kicondialog.h>
 #include <kapplication.h>
+#include <kdeversion.h>
 
 #include <qcombobox.h>
 #include <qlabel.h>
@@ -113,9 +114,16 @@
 
 void TagCreateDlg::slotIconChange()
 {
+#if KDE_IS_VERSION(3,3,0)
+    KIconDialog dlg(this);
+    dlg.setup(KIcon::NoGroup, KIcon::Application, false, 20, false,
+              true, true);
+    QString icon = dlg.openDialog();
+#else
     QString icon = KIconDialog::getIcon(KIcon::NoGroup, KIcon::Application, false, 20);
     if (icon.startsWith("/"))
         return;
+#endif
 
     if (icon.isEmpty() || m_icon == icon)
         return;
@@ -221,9 +229,16 @@
 
 void TagEditDlg::slotIconChange()
 {
+#if KDE_IS_VERSION(3,3,0)
+    KIconDialog dlg(this);
+    dlg.setup(KIcon::NoGroup, KIcon::Application, false, 20, false,
+              true, true);
+    QString icon = dlg.openDialog();
+#else
     QString icon = KIconDialog::getIcon(KIcon::NoGroup, KIcon::Application, false, 20);
     if (icon.startsWith("/"))
         return;
+#endif
     
     if (icon.isEmpty() || icon == m_icon)
         return;