Bug 112571 - Double click to toggle full screen mode
Summary: Double click to toggle full screen mode
Status: RESOLVED UNMAINTAINED
Alias: None
Product: kmplayer
Classification: Unmaintained
Component: general (other bugs)
Version First Reported In: unspecified
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: Koos Vriezen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-09-14 02:40 UTC by Curtis Wensley
Modified: 2025-06-09 21:04 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed/Implemented In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Curtis Wensley 2005-09-14 02:40:28 UTC
Version:           9.0c (using KDE KDE 3.4.1)
Installed from:    Gentoo Packages
OS:                Linux

kmplayer has awesome support for fullscreen mode - probably the only linux media player that supports full screen when embedded into a website in konqueror.  
The only way to switch to full screen is by opening the menu (using the arrow) and pressing 'F' or selecting 'Full Screen'.  

It would be super (and easy) to just double click on the video to toggle fullscreen mode, ala all windows video players (wmp, etc).
Comment 1 Koos Vriezen 2005-09-14 09:08:14 UTC
Sounds great indeed, however there is unfortunately a problem due to a limitation from XSelectInput (man:
      Only one client at a time can select a ButtonPress event, which is
      associated with the event mask ButtonPressMask.)
which means that kmplayer doesn't recieve the mouse click events, because the backend players already have the ButtonPressMask monitored.
There is a workaround though, which means that I should re-send these events from kmplayer to backens. Unfortunately, MPlayer gives a bad-match when I monitor ButtonPressMask before MPlayer ...
Comment 2 Curtis Wensley 2005-09-15 05:06:36 UTC
strange, how does kaffeine do it then?  It doesn't support mplayer, but for xine and the "embedded media plaayer" (under settings->player engine), it supports double click to toggle full screen with it's external viewer ... (kaffeine's kpart viewer doesn't support full screen mode so it doesn't work there).   

kaffeine is very unstable and constantly crashes as an embedded viewer, hence is why I now use kmplayer for that task.  It'd be nice if this is supported too.
Comment 3 Koos Vriezen 2005-09-15 09:34:23 UTC
Yes the buttonclick issue is because of MPlayer, with Xine I could pass the buttonPress events from Qt to the backend (note that mouseclick events are needed for DVDNav). 
The code for embedding the video window is the same for all backends and, for code simplicity, I would like to keep it that way.
I described the problem, though I can get away with that (at least for the time MPlayer doesn't have DVDNav) but, as you may understand, it's not what I consider a good solution. KMPlayer should not break for every MPlayer version that's out there. Currently all versions since 0.90 work (though need some tweaking in the configuration files). A real solution is to wrap MPlayer in an external application as well, but that has not a high priority currently.

FWIW, in the 0.9.1-pre2 version there is now a normal-window-mode button on the controlpanel. Also, the Esc key is bound to jump out of fullscreen.

I position KMPlayer as a konqueror plugin and a simple tool for video playing/recording. Install both kmplayer and kaffeine, and you have a good video player (kaffeine), a tiny one for simple click&play (kmplayer) and a descent plugin (kmplayer).
Of course, this is a bit of an excuse. OTOH. I really wish people would stop seeing kaffeine and kmplayer as competitors, they both have their advantages. Kaffeine is a true Xine frontend, whereas kmplayer uses all kind of OSS projects for various task. Take DVB for instance, Kaffeine implements it using Xine, I just use VDR.

So I leave this issue open, but don't expect any progress here (or someone else should step in)
Comment 4 Curtis Wensley 2005-09-17 01:35:28 UTC
Hiya, 

Thanks for the response.  I do use kaffeine for my media player, but cannot use it for the konqueror plugin as it's slow (has very bad startup lag time) and crashes konqueror constantly..  

The reason I would like the double click is mainly for the embedded video anyway.   However, come to think of it, a 'fullscreen' button on the toolbar, would do just as well in my mind, matching the normal-window-mode button in fullscreen that you mentioned...  toggling in/out of fullscreen from a video playing on a website would be extreemly easy in this case then!  

Thanks muchly,
Curtis.
Comment 5 Stephan Sokolow 2006-06-10 22:31:21 UTC
Can't this be forwarded to the MPlayer people and implemented for all embedded MPlayer frames? I assume there's some quirk of X that prevents it?

Oh, and thanks a bunch for KMplayer. I've never used Kaffeine, but I usually prefer MPlayer as a backend (and I can't stand GMplayer's two-window design) and I like a nice minimal design. (When on Windows, I used MPlayer Classic)

From your description of Kaffeine, I doubt I'll be trying it any time soon.
Comment 6 Christoph Cullmann 2025-06-09 21:04:58 UTC
This project is unfortunately no longer maintained.

If a new maintainer wants to step up and take care, the project is archived here:

https://invent.kde.org/multimedia/kmplayer

You can just clone it in your private namespace on invent.kde.org and if you have started to work on it and fixed/implemented something get it reviewed and the project unarchived.

Sorry for the inconveniences.