Bug 111459 - Don't send system colors by default
Summary: Don't send system colors by default
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Applications
Component: general (show other bugs)
Version: 0.10.3
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-25 04:42 UTC by Chris
Modified: 2005-08-25 19:12 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Chris 2005-08-25 04:42:12 UTC
Version:           0.10.3 (using KDE KDE 3.4.2)
Compiler:          GCC 3.4.4 
OS:                Linux

On protocols that are capable of colored text, Kopete sends the text colored as you have the system configured. Since I use light-on-dark, this causes most recipients (who have a black-on-white setup) to get inverted-like color areas from me.. if the protocol even supports background colors at all, otherwise they'd get light-colored text on a white background. Since I am using my system default colors, I would expect Kopete to send default colors (as it would if rich text was off). Due to this, I consider it a bug.
Comment 1 Olivier Goffart 2005-08-25 19:12:20 UTC
SVN commit 453253 by ogoffart:

fix Bug 111459: Don't send system colors by default
BUG: 111459
CCMAIL mattr@kde.org


 M  +27 -6     krichtexteditpart.cpp  
 M  +2 -2      krichtexteditpart.h  


--- branches/KDE/3.5/kdenetwork/kopete/kopete/chatwindow/krichtexteditpart.cpp #453252:453253
@@ -316,10 +316,12 @@
 
 void KopeteRichTextEditPart::setFgColor()
 {
-	QColor col;
+	QColor col=editor->color();
 
-	int s = KColorDialog::getColor( col, editor->color(), editor );
-	if ( s != QDialog::Accepted || !col.isValid() )
+	int s = KColorDialog::getColor( col, KGlobalSettings::textColor() , editor );
+	if(!col.isValid())
+		col= KGlobalSettings::textColor() ;
+	if ( s != QDialog::Accepted  )
 		return;
 
 	setFgColor( col );
@@ -346,12 +348,24 @@
 	editor->setColor( mFgColor );
 }
 
+QColor KopeteRichTextEditPart::fgColor()
+{
+	if( mFgColor == KGlobalSettings::textColor())
+		return QColor();
+	return mFgColor;
+}
+
 void KopeteRichTextEditPart::setBgColor()
 {
-	QColor col;
+	QColor col=mBgColor;
 
-	int s = KColorDialog::getColor( col, mBgColor, editor );
-	if ( s != QDialog::Accepted || !col.isValid() )
+	int s = KColorDialog::getColor( col, KGlobalSettings::baseColor(), editor );
+	if(!col.isValid())
+	{
+		col=KGlobalSettings::baseColor();
+	}
+
+	if ( s != QDialog::Accepted  )
 		return;
 
 	setBgColor( col );
@@ -374,6 +388,13 @@
 		editor->setPalette(pal);
 }
 
+QColor KopeteRichTextEditPart::bgColor()
+{
+	if( mBgColor == KGlobalSettings::baseColor())
+		return QColor();
+	return mBgColor;
+}
+
 void KopeteRichTextEditPart::setFontSize( int size )
 {
 	mFont.setPointSize( size );
--- branches/KDE/3.5/kdenetwork/kopete/kopete/chatwindow/krichtexteditpart.h #453252:453253
@@ -38,9 +38,9 @@
 
 		QFont font() { return mFont; }
 
-		QColor fgColor() { return mFgColor; }
+		QColor fgColor();
 
-		QColor bgColor() { return mBgColor; }
+		QColor bgColor();
 
 		void clear();