Bug 110835 - please remove KMEdit::setSpellCheckingActive from kmail
Summary: please remove KMEdit::setSpellCheckingActive from kmail
Alias: None
Product: kmail
Classification: Applications
Component: composer (show other bugs)
Version: SVN trunk (KDE 4)
Platform: Compiled Sources All
: NOR wishlist
Target Milestone: ---
Assignee: kdepim bugs
Depends on:
Reported: 2005-08-15 18:37 UTC by Thorsten Staerk
Modified: 2008-03-13 19:49 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Note You need to log in before you can comment on or make changes to this bug.
Description Thorsten Staerk 2005-08-15 18:37:51 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources
OS:                Linux

keep kmail's code clean! It compiles without KMEdit::setSpellCheckingActive, so, please remove it.
Comment 1 Thomas McGuire 2007-12-16 20:04:13 UTC
I think the whole KMEdit thing will be removed as soon as the port to libkdepim/KMeditor is complete (in trunk).
Comment 2 Thomas McGuire 2008-03-13 19:49:35 UTC
SVN commit 785309 by tmcguire:

Fix various spellcheck/highlighting issues:

- Decouple quote highlighting from spell highlighting, now
  quote highlighting works again when spellchecking is disabled.

  Unfortunatley, this is a bit hacky, as the methods from KTextEdit
  could not be reused, because they weren't virtual. KMeditor hides
  spellcheck-related methods inherited from KTextEdit and implements
  its own, properly working ones.

- Move more spellcheck code into KMeditor
- Many bugfixes related to spelling
- In KMail, sync languages used for spelling correctly between the
  highlighter, the config dialog and the spell dialog. This needs
  kdelibs 4.0.67 to work properly.

Also, spell checking in HTML mode now works, but again, you need an 
updated kdelibs.

BUG: 79681
BUG: 110835
BUG: 126361
FEATURE: 141377

 M  +14 -23    kmail/kmcomposereditor.cpp  
 M  +0 -2      kmail/kmcomposereditor.h  
 M  +21 -30    kmail/kmcomposewin.cpp  
 M  +1 -5      kmail/kmcomposewin.h  
 M  +4 -2      knode/kncomposer.cpp  
 M  +4 -4      knode/kncomposereditor.cpp  
 M  +10 -1     libkdepim/dictionarycombobox.cpp  
 M  +1 -0      libkdepim/dictionarycombobox.h  
 M  +51 -37    libkdepim/kemailquotinghighter.cpp  
 M  +37 -11    libkdepim/kemailquotinghighter.h  
 M  +74 -4     libkdepim/kmeditor.cpp  
 M  +79 -3     libkdepim/kmeditor.h  

WebSVN link: http://websvn.kde.org/?view=rev&revision=785309