Bug 110814 - Xine engine: Changing crossfade length does nothing noticable, but can make amaroK skip tracks
Summary: Xine engine: Changing crossfade length does nothing noticable, but can make a...
Status: RESOLVED FIXED
Alias: None
Product: amarok
Classification: Applications
Component: general (show other bugs)
Version: 1.3-SVN
Platform: unspecified Linux
: NOR normal
Target Milestone: ---
Assignee: Amarok Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-08-15 12:46 UTC by Jocke Andersson
Modified: 2006-07-19 11:41 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jocke Andersson 2005-08-15 12:50:02 UTC
Version:           1.3-SVN (using KDE KDE 3.4.2)
Installed from:    Unlisted Binary Package
Compiler:          GCC 3.3.5 (Debian 1:3.3.5-8ubuntu2)
OS:                Linux

The Xine engine crossfade length isn't configurable (talked to Mark Kretschmann about this), but the setting apparently makes a difference (when in the end of the track the crossfade should start)
Setting this value to 500 ms makes amaroK skip tracks (fade out, fade in for a new track, fade out again, a second into that song and then fade in another new song.) Which can be a bit disturbing...

To reproduce this:
1. Start amaroK 1.3 (beta 3 and up).
2. Select the Xine engine.
3. Turn on Crossfading, and set the length to 500 ms or lower (I ran it with 500 ms)
4. Play a track to the end of it (Skipping will NOT help.)

Often (not always, but mostly) you should hear the start of a song in the middle of the crossfading, before the "real" new song starts.

A solution might be to either lock the setting to 2000 ms (default?) or make the fade length configurable.
Comment 1 bonne 2005-08-19 08:29:57 UTC
I have found that the crossfade length is not honoured when skipping tracks. It always seems to be around 5 seconds no matter what the setting is. 

Comment 2 Mark Kretschmann 2005-08-19 16:54:57 UTC
Yeah, it's true.
Comment 3 Mark Kretschmann 2005-08-20 12:35:57 UTC
SVN commit 451292 by markey:

Don't allow crossfading duration < 1500 ms. This change was necessary because xine skips tracks with smaller values.

Guys, can you please test if 1500 ms works OK for you?

BUG: 110814



 M  +1 -0      amarok.kcfg  


--- trunk/extragear/multimedia/amarok/src/amarokcore/amarok.kcfg #451291:451292
@@ -220,6 +220,7 @@
         <label>Length of crossfade, in milliseconds</label>
         <whatsthis>The length of the crossfade between tracks in milliseconds.</whatsthis>
         <default>3000</default>
+        <min>1500</min>
     </entry>
     <entry key="Sound System" type="String">
         <label>Sound system to use</label>
Comment 4 bonne 2005-08-20 16:28:26 UTC
It seems fix the problem for song transitions when songs finish, but the fade still seems much longer than 1500ms when manually skipping tracks. 
Comment 5 Mark Kretschmann 2005-08-20 16:50:24 UTC
On Saturday 20 August 2005 16:28, Bonne Eggleston wrote:
> 2005-08-20 16:28 ------- It seems fix the problem for song transitions when
> songs finish, but the fade still seems much longer than 1500ms when
> manually skipping tracks.


Yeah, xine-engine does not heed this value at all. The transition time is 
currently hardcoded.
Comment 6 Felix Eckhofer 2006-07-19 11:32:12 UTC
Some tracks still skip with crossfade set to 1500ms for me (amarok 1.4.1, xine engine using alsa-dmix output, kubuntu dapper).
Comment 7 Mark Kretschmann 2006-07-19 11:41:18 UTC
Oh btw, xine-engine now heeds the crossfade length setting, as of r564097.