Bug 109097 - Move "Export Diagram" to File menu
Summary: Move "Export Diagram" to File menu
Status: RESOLVED FIXED
Alias: None
Product: umbrello
Classification: Applications
Component: general (show other bugs)
Version: 1.4.1
Platform: Compiled Sources FreeBSD
: NOR wishlist
Target Milestone: 2.17 (KDE Applications 15.08)
Assignee: Umbrello Development Group
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-07-14 21:01 UTC by Alan Horkan
Modified: 2015-08-19 22:09 UTC (History)
2 users (show)

See Also:
Latest Commit:
Version Fixed In: 2.16.80 (KDE Applications 15.07.80)


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alan Horkan 2005-07-14 21:01:48 UTC
Version:           1.4.1 (using KDE KDE 3.4.1)
Installed from:    Compiled From Sources
OS:                FreeBSD

I was interested to learn about how KChart uses the built in functionality of QPainter to export SVG. 
If it is feasible it would be really great if Umbrello could allow SVG export too.  
http://websvn.kde.org/trunk/koffice/filters/kchart/svg/

If it is impractical to implement then dont worry about it but I'd love to see SVG Everywhere, especially if it something already built into QT and it is not too much trouble.
Comment 1 Jonathan Riddell 2005-07-14 21:04:06 UTC
This is already possible.  Diagram->Export as Picture
Comment 2 Alan Horkan 2005-07-14 21:28:51 UTC
I built the latest version of Umbrello and checked to see if there was support for SVG export but I missed it.  

I guess instead I should ask you to follow the standard conventions used by various other KDE applications and put Export in the File menu on the grounds of usability.  (I've taken the liberty of reopening this request on that basis and I hope you will change the summary to match.)

Fantastic to see you are supporting SVG, thanks.  
Comment 3 Jonathan Riddell 2005-07-15 16:26:47 UTC
I'm not sure this is a good idea, it's not exporting the whole file, only the current diagram.  Any UI experts got an opinion?
Comment 4 Alan Horkan 2005-07-15 17:12:29 UTC
I'm not an expert but I am actively interested in usability.  
I've got a big thing about consistency which is why I suggested this change.  

I dont know if KDE has any specific guidelines but there are koffice applications with mutlipage documents that put Export in the File menu as I suggest and it does seem to be a standard Koffice have set for themselves.  The Text CSV exporter in KSpread is a good example (and it provides the option to select which pages from the document are exported rather than just the current one). Kivio does things more like how Umbrello does but they may yet change to conform with the rest of Koffice, I couldn't say for sure.  I guess that doesn't help all that much giving you examples of applications that do it both ways and you are probably following the lead of an existing application.  Perhaps if you know a koffice developer they might be able to quickly and easily explain their reasoning to you and that might help you decide if this is approrpriate for Umbrello.  

Thanks for your consideration.  
Comment 5 Sebastian Stein 2005-07-15 17:32:32 UTC
Currently the function only exports the current diagram, so it is ok to have the action in the diagram menu. There is currently no way to export all diagrams in a file to SVG. This would be another issue and then it should be placed in File.

Sebastian
Comment 6 Alan Ezust 2005-09-27 02:35:59 UTC
I tried to add an "export all diagrams" as a menu item, but it never showed up in any of the menu items. However, there is a KAction-derived class for it.

That would also be nice to add to the File menu, to apply to all diagrams.

Comment 7 Alan Ezust 2005-09-27 03:04:38 UTC
file->export dialog

shows you a collection of checkbox items, one for each diagram,
   name next to checkbox

a "select all" button
a "export to format.." combo box
an "export" button

When export is clicked, exports the selected diagrams in the selected format.

Comment 8 Alan Horkan 2005-09-27 19:30:51 UTC
more recent versions of the SVG specification have support for more than one page in a single SVG file but what I was really looking for was each page to be exported as a seperate file in case it wasn't clear.  
Comment 9 Ralf Habacker 2015-07-17 07:23:57 UTC
> There is currently no way to export all diagrams in a file to SVG. 
This has been added to version 1.5.3

...  then it should be placed in File. 
This will be in 2.16.80.
Comment 10 Ralf Habacker 2015-07-17 07:41:55 UTC
(In reply to Alan Ezust from comment #7)
> file->export dialog
> 
> shows you a collection of checkbox items, one for each diagram,
>    name next to checkbox
> 
> a "select all" button
> a "export to format.." combo box
> an "export" button
> 
A similiar diagram filter dialog is displayed for print and print preview, which could be reused for this purpose.
Comment 11 Ralf Habacker 2015-07-17 08:37:29 UTC
Git commit 6ef0d0a7882d9b512651627a47e3b15e911b5477 by Ralf Habacker.
Committed on 17/07/2015 at 08:36.
Pushed by habacker into branch 'master'.

Implement 'Move "Export Diagram" to File menu'.

The "export all diagrams" menu entry has been refactored to
reuse the diagram filter widget already used by print and print preview.

The diagram filter widget is still named DiagramPrintPage, which is
now misleading and need to be renamed in a further commit.

We use QPointer for m_printSettings to avoid dangled pointers.
FIXED-IN:2.16.80 (KDE Applications 15.07.80)

M  +1    -0    umbrello/CMakeLists.txt
M  +3    -1    umbrello/cmdlineexportallviewsevent.cpp
A  +35   -0    umbrello/dialogs/diagramselectiondialog.cpp     [License: GPL (v2/3)]
A  +36   -0    umbrello/dialogs/diagramselectiondialog.h     [License: GPL (v2/3)]
M  +2    -1    umbrello/docgenerators/docbookgenerator.cpp
M  +2    -2    umbrello/umbrelloui.rc
M  +11   -5    umbrello/uml.cpp
M  +3    -2    umbrello/uml.h
M  +24   -2    umbrello/umlviewimageexporterall.cpp
M  +5    -1    umbrello/umlviewimageexporterall.h
M  +2    -9    umbrello/umlviewimageexportermodel.cpp
M  +2    -2    umbrello/umlviewimageexportermodel.h

http://commits.kde.org/umbrello/6ef0d0a7882d9b512651627a47e3b15e911b5477