Bug 107104 - konsolekalendar --import does not import
Summary: konsolekalendar --import does not import
Status: RESOLVED FIXED
Alias: None
Product: konsolekalendar
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: RedHat Enterprise Linux Linux
: NOR normal
Target Milestone: ---
Assignee: Allen Winter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-06-09 15:04 UTC by Aleksey Nogin
Modified: 2005-07-07 02:40 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aleksey Nogin 2005-06-09 15:04:38 UTC
Version:           1.2.0 (using KDE KDE 3.3.1)
Installed from:    RedHat RPMs
OS:                Linux

konsolekalendar --verbose --file=foo.ics --import=bar.ics

prints "Calendar bar.ics successfully imported", but foo.ics remains completely unchanged (and strace shows that foo.ics was opened for reading, but bar.ics was never opener and foo.ics was never opened for writing).

% konsolekalendar --version
Qt: 3.3.3
KDE: 3.3.1-3.10 Red Hat
KonsoleKalendar: 1.2.0

I have not tried more receint versions of KDE yet.

Possibly related: bug 88361
Comment 1 Allen Winter 2005-06-11 23:27:18 UTC
Aleksey,
Yes, this seems to be broken in newest konsolekalendar too.

Will try to fix for KDE 3.5 (and KDE 3.4.2 if there is one)
Comment 2 Allen Winter 2005-07-07 02:40:36 UTC
SVN commit 432332 by winterz:

Restort the import feature (--import).
For some reason that I cannot recall either Tuukka or myself commented out
what appears to be working code.  It's back now.
BUGS: 107104



 M  +2 -4      konsolekalendaradd.cpp  


--- trunk/KDE/kdepim/konsolekalendar/konsolekalendaradd.cpp #432331:432332
@@ -114,9 +114,7 @@
 bool KonsoleKalendarAdd::addImportedCalendar()
 {
 
-  // TODO: reimplement this please..
-
-  /*if ( !m_variables->getCalendar()->load( m_variables->getImportFile() ) ) {
+  if ( !m_variables->getCalendar()->load( m_variables->getImportFile() ) ) {
     kdDebug()
       << "konsolekalendaradd.cpp::importCalendar() | "
       << "Can't import file: "
@@ -135,7 +133,7 @@
     m_variables->getCalendar()->save( m_variables->getCalendarFile() );
   } else {
     m_variables->getCalendar()->save();
-  }*/
+  }
 
   return true;
 }