Bug 106319 - auto-reconnect on protocol error
Summary: auto-reconnect on protocol error
Status: RESOLVED DUPLICATE of bug 115052
Alias: None
Product: kopete
Classification: Unmaintained
Component: general (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR wishlist
Target Milestone: ---
Assignee: Kopete Developers
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-05-26 01:58 UTC by Quinn Storm
Modified: 2006-04-02 10:45 UTC (History)
0 users

See Also:
Latest Commit:
Version Fixed In:
Sentry Crash Report:


Attachments
patch to oscar protocol to enable reconnecting & to switch KMessageBoxes to KPassivePopups (2.17 KB, patch)
2005-05-26 05:03 UTC, Quinn Storm
Details
Went over the jabber code, this is a cumulative patch of the oscar one and one for the jabber code. (4.05 KB, patch)
2005-05-26 05:23 UTC, Quinn Storm
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Quinn Storm 2005-05-26 01:58:35 UTC
Version:           SVN (using KDE KDE 3.4.0)
Installed from:    Gentoo Packages
OS:                Linux

In situations of protocol error as well as perhaps any other disconnect that wasn't user-initiated, it would be nice to have kopete attempt to auto-reconnect, specifically to automatically return to the last user-specified state (online, away, etc.)...I would start implementing this but I don't (yet) know enough about the libkopete protocol.  If anyone could help me out I'd love to develop this (perhaps even as a kopete plugin if it doesn't seem like it fits in the core code).  Please feel free to reply to the bug or e-mail me ( livinglatexkali@gmail.com ).  I want to help kopete grow.
Comment 1 Quinn Storm 2005-05-26 05:03:26 UTC
Created attachment 11205 [details]
patch to oscar protocol to enable reconnecting & to switch KMessageBoxes to KPassivePopups

Obviously this is a hack, really doing this right will need a few things,
including fixing kopete to have a centralized error reporting system (or so it
seems, other options may exist, I'm not a core dev)
Comment 2 Quinn Storm 2005-05-26 05:23:56 UTC
Created attachment 11206 [details]
Went over the jabber code, this is a cumulative patch of the oscar one and one for the jabber code.

enables auto-reconnecting and uses KPassivePopups for oscar & jabber, I hope
Comment 3 Till Gerken 2005-05-26 10:22:13 UTC
You have to make absolutely sure that the code works correctly in all cases. Especially the Jabber plugin is tricky because it has tons of different disconnection reasons. Either way, the use of KPassivePopups is dangerous because they only work when you can be really certain that the next reconnection attempt succeeds.

If the server is not available and you keep attempting to reconnect, you spam the user's desktop.

The lines about the bad password in the Jabber plugin are good catches though, I'll apply them. Please keep two separate patches for the protocols since right now I am restructuring the code and am unable to merge the patch as it is.
Comment 4 Quinn Storm 2005-05-26 10:54:03 UTC
There's no particular need to merge these patches now, they are indeed hackish and I understand that, so I don't expect them to get merged yet.
Comment 5 Quinn Storm 2005-05-26 11:00:54 UTC
to reply to the desktop flooding problem, as I already mentioned on #kopete, kpassivepopups as I used time out automatically & don't stack up, thats their purpose ^-^ and why I switched to them instead of kmessagebox.  however, this code is hackish and will be dropped for the centralized error system that is being developed for libkopete anyway
Comment 6 John Herdy 2005-12-07 15:13:37 UTC
Hi Till,

Are you working on the reconnect feature or do you want a patch? (note; I'm not able to create one).
Comment 7 steffenp 2006-03-29 17:19:24 UTC
*** This bug has been confirmed by popular vote. ***
Comment 8 Olivier Goffart 2006-04-02 10:45:50 UTC

*** This bug has been marked as a duplicate of 115052 ***