Bug 104660 - navigation between patches for different files should be possible when embedding the part
Summary: navigation between patches for different files should be possible when embedd...
Status: CONFIRMED
Alias: None
Product: kompare
Classification: Applications
Component: general (show other bugs)
Version: unspecified
Platform: Compiled Sources Linux
: NOR wishlist
Target Milestone: ---
Assignee: Kompare developers
URL:
Keywords:
: 128082 259411 269415 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-04-27 17:12 UTC by Leo Savernik
Modified: 2011-05-01 05:53 UTC (History)
5 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Leo Savernik 2005-04-27 17:12:02 UTC
Version:            (using KDE KDE 3.4.0)
Installed from:    Compiled From Sources

Ark contains a built-in diff viewer used to graphically visualize the content of patches.

However, when a diff-file may contain more than one patch, the built-in diff viewer only visualizes the very first patch. There is no means to iterate through the other patches.

Therefore, I propose to enhance the built-in diff viewer to allow viewing all patches contained within a single diff-file.
Comment 1 Georg Robbers 2005-04-27 21:37:58 UTC
Naah, Ark doesn't contain a built-in diff viewer; it simply asks KTrader for something that can handle "text/x-diff". So the wish is actually to have the kompare-part handle the navigation between the patches for different files itself (or embed the navigation part itself) rather than letting the kompare-shell handle that, so that kompare-part is more useful when embedded in Konqueror or Ark.
Comment 2 Otto Bruggeman 2005-04-28 23:28:27 UTC
Right, ARK then also need to ask for the navigation widget ut that is too hard. I will start a rewrite of certain things for 4.0 if I can find the time to make this a bit better or autoload the navigationpart in the komparepart itself. I dont know how else to fix this.
Comment 3 Jeff Snyder 2005-06-06 21:44:45 UTC
This is gonna be a little spammy... I'm reassigning everything that's currently 
assigned to bruggie (who's been the default assignee for bugs since time began) 
to the new list address. 
 
Bruggie: if you're working on one or more of these atm, please snatch 'em 
back.. 
 
Everyone, esp. Joshua and Bruggie: if this genrates 33 mails, my sincere 
apologies.. 
Comment 4 Jeff Snyder 2005-08-08 01:27:53 UTC
SVN commit 443929 by je4d:

Add a new directory view, based on newly abstracted komparelistview :-)
GUI
FEATURE
The navigation is entirely contained in KomparePart now, so when this is merged into HEAD 104660 will be fixed.
CCBUG: 104660


 M  +6 -0      Makefile.am  
 M  +4 -2      kompare_part.cpp  
 M  +21 -4     kompareconnectwidget.cpp  
 M  +3 -0      kompareconnectwidget.h  
 A             komparedirlistview.cpp   [License: GPL (v2+)]
 A             komparedirlistview.h   [License: GPL (v2+)]
 A             komparedirsplitter.cpp   [License: GPL (v2+)]
 A             komparedirsplitter.h   [License: GPL (v2+)]
 A             komparedirstyle.cpp   [License: no copyright]
 A             komparedirstyle.h   [License: no copyright]
 M  +11 -1     komparefilelistview.cpp  
 M  +4 -0      komparefilelistview.h  
 M  +83 -16    komparelistview.cpp  
 M  +19 -4     komparelistview.h  
 M  +23 -2     komparenavframe.cpp  
 M  +10 -1     komparenavframe.h  
Comment 5 Raúl 2007-11-15 16:10:55 UTC
Is it supposed to be already fixed in kde 3.5.8? I can't see it working.

Thanks.
Comment 6 Kevin Kofler 2008-03-27 09:12:28 UTC
That's a 3-way-kompare branch commit, unfortunately that branch is still not ready for production use.
Comment 7 Kevin Kofler 2009-04-15 08:46:45 UTC
*** Bug 128082 has been marked as a duplicate of this bug. ***
Comment 8 Otto Bruggeman 2009-04-15 10:01:29 UTC
Pressing Ctrl+PageUp and Ctrl+PageDown will make kompare go through the files in the diff. I know it is now a solution and only a workaround but it should be enough to get everyone to sto pfiling bugs :-).

Maybe we can add a variable to the kompare part that get initialized from kompare's main function when the navigation part is available. If not it is not initialized or set to false and we show a popup that tells the user he can use these keystrokes to navigate between files in a widget. I think that is the best solution for now until we're finally embedding the navigation into the view part.
Comment 9 Raphael Kubo da Costa 2010-12-10 17:01:45 UTC
*** Bug 259411 has been marked as a duplicate of this bug. ***
Comment 10 Raphael Kubo da Costa 2011-05-01 05:53:27 UTC
*** Bug 269415 has been marked as a duplicate of this bug. ***