Bug 104617 - JJ: Kopete tries to send UserIsTypingNotification with offline oscar account and crashes
Summary: JJ: Kopete tries to send UserIsTypingNotification with offline oscar account ...
Status: RESOLVED FIXED
Alias: None
Product: kopete
Classification: Applications
Component: ICQ and AIM Plugins (show other bugs)
Version: unspecified
Platform: Gentoo Packages Linux
: NOR crash
Target Milestone: ---
Assignee: Matt Rogers
URL:
Keywords:
: 106378 106907 107447 110710 114992 118391 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-04-26 23:59 UTC by Marcus Käll
Modified: 2006-01-29 06:52 UTC (History)
8 users (show)

See Also:
Latest Commit:
Version Fixed In:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marcus Käll 2005-04-26 23:59:32 UTC
Version:           0.10.90 (CVS) (using KDE KDE 3.4.0)
Installed from:    Gentoo Packages
Compiler:          gcc version 3.3.5  (Gentoo Linux 3.3.5-r1, ssp-3.3.2-3, pie-8.7.7.1) 
OS:                Linux

I start a chatsession with an ICQ contact and then disconnect my account. If I type a single letter in the chatsession Kopete tries to send a UserIsTypingNotification. As the connection is closed Kopete crashes.

A Small patch is attached which fixes this bug.

diff -Naur oscar_20050425/liboscar/client.cpp kopetecvs/kdenetwork/kopete/protocols/oscar/liboscar/client.cpp
--- oscar_20050425/liboscar/client.cpp	2005-04-10 20:04:38.000000000 +0200
+++ kopetecvs/kdenetwork/kopete/protocols/oscar/liboscar/client.cpp	2005-04-27 23:40:13.000000000 +0200
@@ -682,6 +682,7 @@
 
 void Client::sendTyping( const QString & contact, bool typing )
 {
+	if (!d->typingNotifyTask) return;
 d->typingNotifyTask->setParams( contact, ( typing ? TypingNotifyTask::Begin : TypingNotifyTask::Finished ) );
 	d->typingNotifyTask->go( false ); 	// don't delete the task after sending
 }
@@ -783,6 +784,7 @@
 	delete d->icqInfoTask;
 	delete d->userInfoTask;
 	delete d->closeConnectionTask;
+	delete d->typingNotifyTask;
 
 	d->errorTask = 0;
 	d->onlineNotifier = 0;
@@ -792,6 +794,7 @@
 	d->icqInfoTask = 0;
 	d->userInfoTask = 0;
 	d->closeConnectionTask = 0;
+	d->typingNotifyTask = 0;
 }
 
 #include "client.moc"
Comment 1 Matt Rogers 2005-06-15 13:58:06 UTC
*** Bug 106378 has been marked as a duplicate of this bug. ***
Comment 2 Matt Rogers 2005-06-15 13:58:54 UTC
*** Bug 107447 has been marked as a duplicate of this bug. ***
Comment 3 Matt Rogers 2005-07-06 19:13:27 UTC
*** Bug 106907 has been marked as a duplicate of this bug. ***
Comment 4 Matt Rogers 2005-07-07 05:42:26 UTC
this is fixed in trunk now. will backport a fix to KDE 3.4.2 as well.
Comment 5 Matt Rogers 2005-08-13 19:08:05 UTC
*** Bug 110710 has been marked as a duplicate of this bug. ***
Comment 6 Gregorio Guidi 2005-08-25 19:19:26 UTC
It seems this is not in the 3.4 branch yet?
Comment 7 Jan Ritzerfeld 2005-10-25 01:27:25 UTC
*** Bug 114992 has been marked as a duplicate of this bug. ***
Comment 8 Thiago Macieira 2005-12-15 17:50:52 UTC
*** Bug 118391 has been marked as a duplicate of this bug. ***
Comment 9 russell 2006-01-27 23:38:17 UTC
uhh im not seeing a patch i can use to fix this problem i have
Comment 10 russell 2006-01-29 06:52:59 UTC
I am Having this same problem, can anyone help me out?