Bug 99329

Summary: Copyright missing from source files
Product: [Applications] konsole Reporter: Kurt Hindenburg <khindenburg>
Component: generalAssignee: Konsole Developer <konsole-devel>
Status: RESOLVED FIXED    
Severity: normal    
Priority: NOR    
Version: unspecified   
Target Milestone: ---   
Platform: Compiled Sources   
OS: Linux   
Latest Commit: Version Fixed In:
Sentry Crash Report:

Description Kurt Hindenburg 2005-02-14 07:22:33 UTC
Version:            (using KDE Devel)
Installed from:    Compiled sources

According to http://www.icefox.net/kde/tests/copyright_kdebase.html there are a number of konsole files without copyrights.

No Copyright found in: ./konsole/konsole/BlockArray.cpp
  Nothing at all.
No Copyright found in: ./konsole/konsole/konsole_wcwidth.cpp
  A note saying it is in public domain.
No Copyright found in: ./konsole/konsole/konsolebookmarkhandler.cpp
  Nothing.
No Copyright found in: ./konsole/konsole/konsolebookmarkmenu.cpp
  Nothing.
No Copyright found in: ./konsole/konsole/kwrited.cpp
  Nothing.
Comment 1 Waldo Bastian 2005-02-14 11:09:56 UTC
> No Copyright found in: ./konsole/konsole/BlockArray.cpp
>   Nothing at all.

Stephan Kulow added it.

> No Copyright found in: ./konsole/konsole/konsole_wcwidth.cpp
>   A note saying it is in public domain.

That's ok.

> No Copyright found in: ./konsole/konsole/konsolebookmarkhandler.cpp
>   Nothing.
> No Copyright found in: ./konsole/konsole/konsolebookmarkmenu.cpp
>   Nothing.

Added by Stephan Binner

> No Copyright found in: ./konsole/konsole/kwrited.cpp
>   Nothing.

Added by Lars Doelle
Comment 2 Stephan Kulow 2005-02-14 11:45:26 UTC
Am Monday 14 February 2005 11:09 schrieb Waldo Bastian:
> > No Copyright found in: ./konsole/konsole/BlockArray.cpp
> >   Nothing at all.
> 
> Stephan Kulow added it.
> 
But it was never used, no?

Greetings, Stephan

Comment 3 Waldo Bastian 2005-02-14 12:48:29 UTC
On Monday 14 February 2005 11:45, Stephan Kulow wrote:
> Am Monday 14 February 2005 11:09 schrieb Waldo Bastian:
> > > No Copyright found in: ./konsole/konsole/BlockArray.cpp
> > >   Nothing at all.
> >
> > Stephan Kulow added it.
>
> But it was never used, no?

TEHistory.cpp uses it.

Comment 4 Kurt Hindenburg 2005-02-15 07:01:11 UTC
http://developer.kde.org/policies/licensepolicy.html

I notice it doesn't say anything about 'public domain'.  Is that an oversight?
Comment 5 Kurt Hindenburg 2005-02-15 07:36:11 UTC
No Copyright found in: ./kicker/menuext/konsole/konsolebookmarkhandler.cpp
No Copyright found in: ./kicker/menuext/konsole/konsolebookmarkmenu.cpp

Added by Stephan Binner 
Comment 6 Kurt Hindenburg 2006-07-12 10:48:44 UTC
http://www.englishbreakfastnetwork.org/krazy/reports/kde-4.0/kdebase/apps/index.html

#  ./konsole/tests/esc.c: missing tags: copyright (1)
# ./konsole/tests/main.c: missing tags: copyright (1)
# ./konsole/tests/header.h: missing tags: copyright (1)
# ./konsole/konsole/konsole_part.h: missing tags: email address(line 3) (1)
# ./konsole/konsole/konsoleiface.h: missing tags: copyright (1)
# ./konsole/konsole/sessioniface.h: missing tags: copyright (1)
# ./konsole/konsole/konsole_part.cpp: missing tags: email address(line 3) (1) 


#  ./konsole/tests/esc.c: missing license
# ./konsole/tests/main.c: missing license
# ./konsole/tests/header.h: missing license
# ./konsole/konsole/konsoleiface.h: missing license
# ./konsole/konsole/sessioniface.h: missing license 

The test/ files use (c) instead of 'copyright'; They are pre-GPL and I'm not sure that's O.K. I'm trying to get an answer from license ml.
The *iface.h will be removed when DCOP is dropped.
The konsole_part.h/.cpp files I'm trying to find an up todate email address for Boloni Laszlo ( blaci@utcluj.ro, boloni@cs.purdue.edu bounced).

Comment 7 Kurt Hindenburg 2006-08-03 19:23:55 UTC
#  ./konsole/tests/esc.c: missing license
# ./konsole/tests/main.c: missing license
# ./konsole/tests/header.h: missing license 

#  ./konsole/tests/esc.c: missing tags: copyright (1)
# ./konsole/tests/main.c: missing tags: copyright (1)
# ./konsole/tests/header.h: missing tags: copyright (1) 

I'm still waiting for someone to say whether these files in /tests are O.K. as is... the license ml seems dead...

http://lists.kde.org/?l=kde-licensing&m=115260953008961&w=2
Comment 8 Kurt Hindenburg 2006-09-08 17:46:33 UTC
According to krazy, konsole passes all the copyright/license tests...