| Summary: | Clicking on or moving ActionList: toolbar_filter_actions item makes SPAM filter icons disappear | ||
|---|---|---|---|
| Product: | [Unmaintained] kmail | Reporter: | Alan Mimms <alanm> |
| Component: | general | Assignee: | kdepim bugs <kdepim-bugs> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | auspex, glenn.enright |
| Priority: | NOR | ||
| Version: | 1.7.2 | ||
| Target Milestone: | --- | ||
| Platform: | Gentoo Packages | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
|
Description
Alan Mimms
2005-02-06 19:45:13 UTC
Confirmed. I don't know exactly if this can be fixed in KDE 3.4 at all, the issue depends heavily on features in kdelibs. Let's see. CVS commit by gungl:
Avoid "conserve memory" when using dynamic actions.
BUGS: 98715
M +1 -1 kmmainwin.cpp 1.604
--- kdepim/kmail/kmmainwin.cpp #1.603:1.604
@@ -136,5 +136,5 @@ void KMMainWin::slotEditToolbars()
void KMMainWin::slotUpdateToolbars()
{
- createGUI("kmmainwin.rc");
+ createGUI("kmmainwin.rc", false);
applyMainWindowSettings(KMKernel::config(), "Main Window");
}
Danke Andreas. That solves the problem of the item disappearing when you move it. I can now move the icons for the SPAM/HAM buttons anywhere on the toolbar. However, the icons disappear from the toolbar when the Configure Toolbars dialog is displayed (for example, by right clicking on the toolbar). I can move the "ActionList: toolbar_filter_actions" item within the list and the icons reappear (in the proper new place) when I close the dialog. People might be confused by the icons disappearing while the dialog is up. Can this be fixed as well? Should it be under a separate bug? CVS commit by gungl:
As requested for better usability. Limit the hiding of the dynamic
toolbar icons to a minimum.
BUG: 98715
M +7 -5 kmmainwin.cpp 1.605
--- kdepim/kmail/kmmainwin.cpp #1.604:1.605
@@ -120,7 +121,4 @@ void KMMainWin::displayStatusMsg(const Q
void KMMainWin::slotEditToolbars()
{
- // remove dynamically created actions before editing
- mKMMainWidget->clearFilterActions();
-
saveMainWindowSettings(KMKernel::config(), "Main Window");
KEditToolbar dlg(actionCollection(), "kmmainwin.rc");
@@ -130,12 +128,16 @@ void KMMainWin::slotEditToolbars()
dlg.exec();
- // plug dynamically created actions again
- mKMMainWidget->initializeFilterActions();
}
void KMMainWin::slotUpdateToolbars()
{
+ // remove dynamically created actions before editing
+ mKMMainWidget->clearFilterActions();
+
createGUI("kmmainwin.rc", false);
applyMainWindowSettings(KMKernel::config(), "Main Window");
+
+ // plug dynamically created actions again
+ mKMMainWidget->initializeFilterActions();
}
Excellent work. This seems to solve all of my issues. Thanks. *** Bug 99709 has been marked as a duplicate of this bug. *** *** Bug 94181 has been marked as a duplicate of this bug. *** Are you sure 99709 is a duplicate? There is no obvious similarity - the buttons never disappear when the toolbar dialog is in use. They just don't _reappear_ when Kontact is restarted. I'm quite sure, as I have coded this functionality. ;) The problem in KDE 3.3 was a general one. We had realized too late that the dynamic toolbar icon handling for the filters had created technical problems. Due to the freeze policy for KDE branches, I was not able to extend the GUI and underlaying functions in a way which had allowed to solve all those problems. I could work around some things, but a general cleanup was possible only for KDE 3.4 which will be out soon. I've marked the reports as duplicates because technically they rank all about the same problem, even if the visible symptoms have been different. Anyway, enjoy KDE 3.4 and Kontact, and of course, feel free to reopen any report if you can reproduce it with the new version. We're programmers, not God, that's why we make errors sometimes. :) |