Bug 95460

Summary:	weather icons too small in applet display http://bugs.kde.org/show_bug.cgi?id=95460
Product:	[Applications] kweather-kde3	Reporter:	Unknown <null>
Component:	general	Assignee:	geiseri
Status:	RESOLVED FIXED
Severity:	normal	CC:	aseigo, james.roberts-thomson, koch0121, lofi, mcamen, Stefan.Borggraefe
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Compiled Sources
OS:	Linux
Latest Commit:		Version Fixed In:
Attachments:	Screen shot showing reduced weather icon size Pressed kweather button Makes sure the button is resized in horizontal and ShowAll modes

Description Unknown 2004-12-19 15:50:39 UTC

Version:           2.1.0 (using KDE KDE 3.3.90)
Installed from:    Compiled From Sources
Compiler:          gcc 3.3.4 
OS:                Linux

Officially KDE reports version 3.3.90 alpha1 cvs>=20041206
Icon display for current weather is very small compared to applet height. The icon height is approx 50% of panel height and should be bigger. This error is relatively new, about 1 month. Coincides with problems seen with bug 73093. Screen shot attached.

Comment 1 Unknown 2004-12-19 15:53:56 UTC

Created attachment 8722 [details]
Screen shot showing reduced weather icon size

Relative to Panel Height, icon size is around 50%. Should be larger and used to
be!

Comment 2 mcamen 2004-12-21 21:55:01 UTC

This happens since http://lists.kde.org/?l=kde-cvs&m=110210327907998

Comment 3 mcamen 2004-12-21 21:58:14 UTC

Created attachment 8757 [details]
Pressed kweather button

Another screenshot showing the true size of the kweather button.

Comment 4 Michael Nottebrock 2005-03-16 02:51:58 UTC

Confirmed on FreeBSD.

Comment 5 Michael Nottebrock 2005-03-21 21:11:35 UTC

Workaround: Open kweather's configuration dialog and cycle around the 'Panel Display Options'. KWeather sometimes does funky miscalculations of the needed fontsize in Icon and Temperature mode, too.

Comment 6 Michael Nottebrock 2005-03-21 21:12:05 UTC

Workaround: Open kweather's configuration dialog and cycle around the 'Panel Display Options' (and apply in between). KWeather sometimes does funky miscalculations of the needed fontsize in Icon and Temperature mode, too.

Comment 7 Simon Koch 2005-03-22 06:29:49 UTC

Created attachment 10262 [details]
Makes sure the button is resized in horizontal and ShowAll modes

This still exists in the 3.4.0 release.  Here is a patch that fixes it for me.

Comment 8 Stefan Borggraefe 2005-06-06 07:57:17 UTC

Aaron, can you evaluate the attached patch and check it in if it's the correct fix? Comment 2 indicates that you may have caused this regression.

Thanks! :-)

Comment 9 Aaron J. Seigo 2005-06-06 16:09:10 UTC

SVN commit 422797 by aseigo:

ensure button geometry set properly. patch by Simon Koch.
BUG:95460


 M  +1 -0      dockwidget.cpp  


--- trunk/KDE/kdetoys/kweather/dockwidget.cpp #422796:422797
@@ -169,6 +169,7 @@
             m_lblTemp->setGeometry(h+1, 0, w-h, h/3);
             m_lblWind->setGeometry(h+1, h/3, w-h, h/3);
             m_lblPres->setGeometry(h+1, 2*h/3, w-h, h/3);
+            m_button->setGeometry(0, 0, h, h);
         }
         else if ( m_mode == ShowTempOnly)
         {

Comment 10 Aaron J. Seigo 2005-06-06 16:12:51 UTC

SVN commit 422799 by aseigo:

backport button geom fix
CCBUG:95460


 M  +1 -0      dockwidget.cpp  


--- branches/KDE/3.4/kdetoys/kweather/dockwidget.cpp #422798:422799
@@ -169,6 +169,7 @@
             m_lblTemp->setGeometry(h+1, 0, w-h, h/3);
             m_lblWind->setGeometry(h+1, h/3, w-h, h/3);
             m_lblPres->setGeometry(h+1, 2*h/3, w-h, h/3);
+            m_button->setGeometry(0, 0, h, h);
         }
         else if ( m_mode == ShowTempOnly)
         {

Comment 11 Thiago Macieira 2005-06-07 07:03:13 UTC

*** Bug 102237 has been marked as a duplicate of this bug. ***

Comment 12 Paweł Goleniowski 2005-06-15 17:53:36 UTC

This bug is still present in KDE 3.4.1 :(

Comment 13 Aaron J. Seigo 2005-06-15 19:57:46 UTC

the bug would still be present in 3.4.1 because it was backported to the 3.4 branch after 3.4.1 was released.