Bug 86683

Chris: you're aware what you're doing right now? :)

Yea, I installed ubuntu linux on my laptop, which uses gnome only. It uses the xscreensaver daemon to run its screensaver and has nice options to fade in-and-out  of the screensaver blanking

xscreensaver-4.16 definitely has this option.

Please add to KDE!!

CVS commit by howells: 

Fade to black before starting screensaver. It works, though it breaks "manipulate screen" screensavers.
we can bitBlt() the original screen back after the fade, but then this means it goes back to full brightness for a second or two before starting the screensaver.

Also the fade animation isn't silky smooth.

I'm going to leave this in for a few days to get comments before reverting/fixing.

Any comments coolo? :)

CCBUG: 86683
~


  M +13 -2     lockprocess.cc   1.46
  M +2 -0      lockprocess.h   1.23


--- kdebase/kdesktop/lock/lockprocess.cc  #1.45:1.46
@@ -34,4 +34,6 @@
 #include <kpushbutton.h>
 #include <kstdguiitem.h>
+#include <kpixmapeffect.h>
+#include <kpixmap.h>
 
 #include <qframe.h>
@@ -733,4 +734,12 @@ bool LockProcess::startLock()
 bool LockProcess::startHack()
 {
+    mOriginal = QPixmap::grabWindow(winId());
+
+    for (double i = 0; i < 1.0; i = i + 0.08)
+    {    
+        KPixmap pixmap = mOriginal;
+        KPixmapEffect::fade(pixmap, i, Qt::black);
+        bitBlt(this, 0, 0, &pixmap);
+    }
     if (mSaverExec.isEmpty())
     {
@@ -773,4 +783,5 @@ bool LockProcess::startHack()
                         setpriority(PRIO_PROCESS, mHackProc.pid(), mPriority);
 #endif
+                        //bitBlt(this, 0, 0, &mOriginal);
                         return true;
                 }

--- kdebase/kdesktop/lock/lockprocess.h  #1.22:1.23
@@ -13,4 +13,5 @@
 
 #include <kprocess.h>
+#include <kpixmap.h>
 
 #include <qwidget.h>
@@ -125,4 +126,5 @@ private:
     int         mAutoLogoutTimeout;
     bool        mAutoLogout;
+    KPixmap     mOriginal;
 };
 

is this in KDE 3.4?

No.

were this bits removed from trunk ?
it doesn't seem to work on my machine

yeah, I can see it's being removed from trunk.
Can't we just get inspiration from gnome folks on that, also log out thingie requires similar smooth animation. This also works for gnome ppl.

*cough*

Chris Howells patch somehow didn't make it, what's wrong?
Since it's probably too late for 3.5 already KDE won't have such a slick thing until KDE 4 which is years away?

Here's a patch for this same at logout: 
http://www.kde-apps.org/content/show.php?content=20652
(someone adapted it for 3.4: http://www.kde-apps.org/content/show.php?content=22557)

Some competent KDE coder might even merge both and have such code just once.

So, honestly, what's wrong with this feature? Are there any usability issues we didn't think about?

I really really hope it's not some kind of "not invented here" or something like that.

Ok, forget the part about merging both fade effects. The screenshot and description show that this logout effect works differently - it's much like the current KDE effect but good looking and smooth.

That's even better imo, but somewhat misplaced here. I'll look for an appropriate bug report and post it there.

Still I wonder why there's no screensaver fading (which should be a good usability improvement from all I can tell).

Put up a thread on the kde-usability mailing list about this issue titled "Issues of fade to black effect before screensaver?".

Also I made a new bug report (no current one about this available) with the fade-to-grey effect at logout: bug 112547

related to bug 183119

*** This bug has been marked as a duplicate of bug 183119 ***