| Summary: | hardcoded strings output in crypto plugin | ||
|---|---|---|---|
| Product: | [Unmaintained] kopete | Reporter: | Marcin Orlowski <carlos-spam> |
| Component: | Cryptography Plugin | Assignee: | Kopete Developers <kopete-bugs-null> |
| Status: | RESOLVED FIXED | ||
| Severity: | wishlist | CC: | antonio.merker, carsten.schlipf, cartan, cweiske, ivansanchez, languitar, lofi, matthias.laabs, Merlin-TC, meyerm, stefan, sven.burmeister, taccu, thorgal, yojoe |
| Priority: | NOR | ||
| Version: | SVN | ||
| Target Milestone: | --- | ||
| Platform: | unspecified | ||
| OS: | Linux | ||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | patch againts kopete (kde 3.5) silencing crypto-plugin | ||
|
Description
Marcin Orlowski
2004-03-13 16:54:47 UTC
*** Bug 75407 has been marked as a duplicate of this bug. *** I think that bug #96494 is a duplicate of this one. 2 things are needed : - XSLT style support to define the way outgoing/incoming encrypted message are displayed - a preview of the way an XSLT style formats encrypted message in Kopete's style chooser dialog I think that this way, people will be able to replace heavy displays by lock icons or lighter colors :) *** Bug 96494 has been marked as a duplicate of this bug. *** *** Bug 106417 has been marked as a duplicate of this bug. *** Indeed, this behavior is quite annoying and still there in Kopete 0.10.4, after 4 dupes. Additionally, the redundant messages are saved in the history, which makes it almost unusable. I guess have to go back to Psi for the time being. Please do something about it, thanks! Created attachment 13934 [details]
patch againts kopete (kde 3.5) silencing crypto-plugin
the following patch removes the hardcoded crypto-output. A new attribute
("encrypted") is sent to the XSL styles, which can now react accordingly.
Drawback: if the style doesn't handle the 'encrypted'-attribute then encrypted
messages won't look different (I looked into it, but unless Kopete knows
about the crypto-plugin this is not easily solved).
The chosen approach actually lets any plugin add its attributes.
Forgot to say: as plugins can add their attributes, styles might not always implement all possible plugin-attributes. I'm therefore proposing a special tag (for instance <demo />) which is sent during the preview. Style-programmers could then demonstrate all their capabilities (and maybe even some personal art). I think in the next version of Kopete we will use the new XML+CSS style engine which works pretty good. We can also use Adium themes then, not sure if they have an attribute for encryption in there already but it should be easy to add. In my opinion, even if encrypted messages look just like regular messages, it is not a problem. There are users (like myself) that use encryption whenever possible, just because we like privacy, and so we consider encrypted message as the standard. Of course, the suggested "encrypted" attribute is the best way of solving this :-) I made a patch that shows an icon and not that buggy "Encrypted message" text. But I've made it for 0.11.1. I can add it if you want... Ups :) never mind about me kde@florian.loitsch.com allready made the patch... (sorry for not reading the messages first...) http://kde-apps.org/content/show.php?content=40844 fix for kopete 0.12.0 Anyone with powers could please take a look a this patch? The v0.12 still spits this string out (and the bug is over 2 year old now ;( *** Bug 140196 has been marked as a duplicate of this bug. *** Somebody of the developers still reading this? It's REALLY annoying. And I would love to see a small lock icon... Fixed for trunk. We may consider doing text coloring instead of icons...less obtrusive. For now it's an icon. Someone please close bug, I don't have permission. *** Bug has been marked as fixed ***. *** Bug 149778 has been marked as a duplicate of this bug. *** *** Bug 122310 has been marked as a duplicate of this bug. *** *** Bug 157787 has been marked as a duplicate of this bug. *** Since one year this issue is fixed in trunk. Does somebody know in what kopete version this issue is resolved or what version it's planned to be released. In my kopete version (0.12.7, KDE 3.5.9) it's still missing :( Or do I have to enable a special flag before compiling kopete? Will this be released in 3.5.1x? |