Bug 67689

Indeed none of the toolbar manipulation options for any toolbar survives opening a new window or closing the current one and then opening a new window. that includes changing icon sizes and location, collapsing("flattening") a toolbar, changing toolbar location/orientation, floating a toolbar and adding or removing a toolbar.

Using current CVS HEAD (3.1.93 and a bit)

Note - configuration is being saved if I use "Settings->save profile" and overwrite the "webbrowsing" profile. 
maybe this is a feature ?

Hi,

FYI: There seems to be a duplicate of this bug at 67743.

http://bugs.kde.org/show_bug.cgi?id=67743

We can close the other bug (I am the reporter of that bug -  6743) and combine the votes of them both.

Osho

Hi,

I can confirm that this bug is present in 3.1.94 (3.2 beta2).

Osho

*** Bug 67743 has been marked as a duplicate of this bug. ***

*** Bug 71095 has been marked as a duplicate of this bug. ***

I agree that my bug report #71095 is a dup (never saw this current one)....but the difference that I experienced compared to this one is that even maually saving and overwriting the "webbrowsing" profile still had no effect after logging out or rebbooting. But I am sure it is still basically the same bug nonetheless.

Cap

CVS commit by kalass: 

if not hasDefault ; then 
  restoreToDefault

simply does not make sense :-)  

Fixes wrong optimization of default values

CCMAIL: 67689-done@bugs.kde.org


  M +6 -6      ktoolbar.cpp   1.369.2.2


--- kdelibs/kdeui/ktoolbar.cpp  #1.369.2.1:1.369.2.2
@@ -1122,5 +1122,5 @@ void KToolBar::saveSettings(KConfig *con
     KConfigGroupSaver saver(config, configGroup);
 
-    if(!config->hasDefault("Position") && position == d->PositionDefault )
+    if(config->hasDefault("Position") && position == d->PositionDefault )
       config->revertToDefault("Position");
     else
@@ -1129,5 +1129,5 @@ void KToolBar::saveSettings(KConfig *con
     //kdDebug(220) << name() << "                icontext=" << icontext << " hasDefault:" << config->hasDefault( "IconText" ) << " d->IconTextDefault=" << d->IconTextDefault << endl;
 
-    if(!config->hasDefault("IconText") && icontext == d->IconTextDefault )
+    if(config->hasDefault("IconText") && icontext == d->IconTextDefault )
     {
       //kdDebug(220) << name() << "                reverting icontext to default" << endl;
@@ -1140,10 +1140,10 @@ void KToolBar::saveSettings(KConfig *con
     }
 
-    if(!config->hasDefault("IconSize") && iconSize() == d->IconSizeDefault )
+    if(config->hasDefault("IconSize") && iconSize() == d->IconSizeDefault )
       config->revertToDefault("IconSize");
     else
       config->writeEntry("IconSize", iconSize());
 
-    if(!config->hasDefault("Hidden") && isHidden() == d->HiddenDefault )
+    if(config->hasDefault("Hidden") && isHidden() == d->HiddenDefault )
       config->revertToDefault("Hidden");
     else
@@ -1162,10 +1162,10 @@ void KToolBar::saveSettings(KConfig *con
     config->writeEntry("Index", index);
 
-    if(!config->hasDefault("Offset") && offset() == d->OffsetDefault )
+    if(config->hasDefault("Offset") && offset() == d->OffsetDefault )
       config->revertToDefault("Offset");
     else
       config->writeEntry("Offset", offset());
 
-    if(!config->hasDefault("NewLine") && newLine() == d->NewLineDefault )
+    if(config->hasDefault("NewLine") && newLine() == d->NewLineDefault )
       config->revertToDefault("NewLine");
     else

I applied this patch against KDE 3.2.1 sources and recompiled kdelibs. I can confirm that the bug is fixed with this patch.

Many many thanks Klas.
Osho