Bug 59927

Summary:	add keyboard shortcut to view email (example: preview pane deactivated)
Product:	[Unmaintained] kmail	Reporter:	Chris Horn <irrationality>
Component:	general	Assignee:	kdepim bugs <kdepim-bugs>
Status:	RESOLVED FIXED
Severity:	normal	CC:	rgawenda, webmaster
Priority:	NOR
Version:	unspecified
Target Milestone:	---
Platform:	Debian testing
OS:	Linux
Latest Commit:		Version Fixed In:
Sentry Crash Report:

Description Chris Horn 2003-06-17 05:20:22 UTC

Version:            (using KDE KDE 3.1.2)
Installed from:    Debian testing/unstable Packages
OS:          Linux

I can't figure out how to bind a key to simply view a message.  Also, on a related note, it would be nice if pushing a key twice brought up a window and then closed it if the same message was selected.

My desired behaviour is this:

1. You select a message
2. You press something like 'V' to view the message
3. You're done reading it, so you press 'V' again to make the new window disappear
4 - configurable both ways
4a. If you selected another message and pressed 'V' it would bring up that new message in a new window, leaving the old window alone (the only way to close that window is now with CTRL-W or the window manager control)
4b. If you selected another message it would bring up that new message in the existing view window (which can be closed by pressing 'V')

Comment 1 Michael Jahn 2004-07-26 21:44:00 UTC

*** Bug 80514 has been marked as a duplicate of this bug. ***

Comment 2 Michael Jahn 2004-07-26 21:50:09 UTC

IMHO a missing keybinding for such an essential action is a bug. And no, I wouldn't use it so I'm pretty objective here :-)

Comment 3 Michael Jahn 2004-09-12 03:55:35 UTC

*** Bug 82193 has been marked as a duplicate of this bug. ***

Comment 4 Till Adam 2004-09-12 14:51:35 UTC

CVS commit by tilladam: 

Finally fix KMail's number one a11y problem by making a KAction which
displays the current message in a separate reader window and assigning
the Return key to it by default.

CCMAIL: 59927-done@bugs.kde.org


  M +11 -1     kmmainwidget.cpp   1.260
  M +1 -0      kmmainwidget.h   1.74


--- kdepim/kmail/kmmainwidget.cpp  #1.259:1.260
@@ -1992,4 +1992,10 @@ void KMMainWidget::slotPrevImportantMess
 }
 
+void KMMainWidget::slotDisplayCurrentMessage()
+{
+  if ( mHeaders->currentMsg() )
+    slotMsgActivated( mHeaders->currentMsg() );
+}
+
 //-----------------------------------------------------------------------------
 //called from headers. Message must not be deleted on close
@@ -2737,4 +2743,8 @@ void KMMainWidget::setupActions()
                                    "view_source" );
 
+  ( void ) new KAction( i18n("&Display Message"), Key_Return, this,
+                        SLOT( slotDisplayCurrentMessage() ), actionCollection(),
+                        "display_message" );
+
   //----- Go Menu
   new KAction( KGuiItem( i18n("&Next Message"), QString::null,

--- kdepim/kmail/kmmainwidget.h  #1.73:1.74
@@ -324,4 +324,5 @@ protected slots:
 
   /** etc. */
+  void slotDisplayCurrentMessage();
   void slotMsgActivated(KMMessage*);

Comment 5 Rob Kaper 2004-09-20 01:02:23 UTC

On Sunday 12 September 2004 2:51pm, Till Adam wrote:
> Finally fix KMail's number one a11y problem by making a KAction which
> displays the current message in a separate reader window and assigning
> the Return key to it by default.

Thanks Till! Will this be in 3.3.1 or just in HEAD?

Rob

Comment 6 Till Adam 2004-09-20 08:27:35 UTC

> On Sunday 12 September 2004 2:51pm, Till Adam wrote:
> > Finally fix KMail's number one a11y problem by making a KAction which
> > displays the current message in a separate reader window and assigning
> > the Return key to it by default.
>
> Thanks Till! Will this be in 3.3.1 or just in HEAD?

Ingo? I would think it's worth backporting.