Bug 508491

Summary:	Translation in systemsettings - wallpaper
Product:	[Applications] systemsettings	Reporter:	Victor Ryzhykh <victorr2007>
Component:	kcm_wallpaper	Assignee:	Plasma Bugs List <plasma-bugs-null>
Status:	RESOLVED FIXED
Severity:	normal	CC:	meven, nate
Priority:	NOR	Keywords:	regression
Version First Reported In:	6.4.80
Target Milestone:	---
Platform:	ROSA RPMs
OS:	Linux
Latest Commit:	https://invent.kde.org/plasma/plasma-workspace/-/commit/32f8d9ee2bc3bcad49c406aca86d7f4db1dd666d	Version Fixed/Implemented In:	6.5.0
Sentry Crash Report:
Attachments:	fix.kcm_wallpaper.patch

Description Victor Ryzhykh 2025-08-19 20:07:05 UTC

Created attachment 184271 [details]
fix.kcm_wallpaper.patch

There are problems in /kcms/wallpaper/.
In the file /plasma-workspace/kcms/wallpaper/CMakeLists.txt it is specified add_definitions(-DTRANSLATION_DOMAIN="kcm_wallpaper")
And translation and Messages.sh do not exist.
I also had to edit the file /plasma-workspace/kcms/wallpaper/ui/main.qml so that the translation would be detected.
I fixed it in the package with this patch.fix.kcm_wallpaper.patch

In fact, all these manipulations and the patch itself seem unnecessary.
Basically, the translation is visible everywhere.
I noticed that in the main window there was this line without translation https://invent.kde.org/plasma/plasma-workspace/-/blob/master/kcms/wallpaper/ui/main.qml?ref_type=heads#L27

Here https://invent.kde.org/plasma/plasma-workspace/-/blob/master/kcms/wallpaper/ui/main.qml?ref_type=heads#L27 it is specified,
title: i18ndc("plasma_shell_org.kde.plasma.desktop", "@title:window", "Wallpaper").
But if you look in the file for plasma_shell_org.kde.plasma.desktop, there are lines of a different type.
name: i18nd("plasma_shell_org.kde.plasma.desktop", "Wallpaper")
https://invent.kde.org/plasma/plasma-desktop/-/blob/master/desktoppackage/contents/configuration/ContainmentConfiguration.qml?ref_type=heads#L27
And this line remains untranslated.


Operating System: ROSA Fresh Desktop 13
KDE Plasma Version: 6.4.80
KDE Frameworks Version: 6.17.0
Qt Version: 6.9.1
Kernel Version: 6.16.1-generic-1rosa13-x86_64 (64-bit)
Graphics Platform: Wayland
Processors: 8 × Intel® Core™ i7-7700K CPU @ 4.20GHz
Memory: 32 ГиБ of RAM (31.2 ГиБ usable)
Graphics Processor: NVIDIA GeForce RTX 3050
Manufacturer: Gigabyte Technology Co., Ltd.
Product Name: B250M-D3H

Comment 1 Nate Graham 2025-08-20 18:34:50 UTC

Thanks, can you submit a patch via invent.kde.org?

Comment 2 Victor Ryzhykh 2025-08-21 09:10:05 UTC

(In reply to Nate Graham from comment #1)
> Thanks, can you submit a patch via invent.kde.org?

https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5778

Comment 3 Bug Janitor Service 2025-10-02 20:05:14 UTC

A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5884

Comment 4 Nicolas Fella 2025-10-06 10:31:52 UTC

Git commit 1c6fe363c646379bff089d8c3da467203a17eda1 by Nicolas Fella, on behalf of Nate Graham.
Committed on 06/10/2025 at 10:31.
Pushed by nicolasfella into branch 'master'.

kcms/wallpaper: fix localization

Messages.sh was missing, and the domain was set incorrectly for some
strings.

Amends 779e2d07ddee2fc3c3fe20568fc2a77484073d27
Related: bug 505122
FIXED-IN: 6.5.0

I'm assuming cherry-picking is fine since this fixes a localization bug, and doesn't change any strings that have already been localized. But please correct me if that's wrong.

A  +2    -0    kcms/wallpaper/Messages.sh
M  +4    -4    kcms/wallpaper/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/1c6fe363c646379bff089d8c3da467203a17eda1

Comment 5 Nicolas Fella 2025-10-06 10:32:17 UTC

Git commit 32f8d9ee2bc3bcad49c406aca86d7f4db1dd666d by Nicolas Fella, on behalf of Nate Graham.
Committed on 06/10/2025 at 10:32.
Pushed by nicolasfella into branch 'Plasma/6.5'.

kcms/wallpaper: fix localization

Messages.sh was missing, and the domain was set incorrectly for some
strings.

Amends 779e2d07ddee2fc3c3fe20568fc2a77484073d27
Related: bug 505122
FIXED-IN: 6.5.0

I'm assuming cherry-picking is fine since this fixes a localization bug, and doesn't change any strings that have already been localized. But please correct me if that's wrong.

(cherry picked from commit 1c6fe363c646379bff089d8c3da467203a17eda1)

A  +2    -0    kcms/wallpaper/Messages.sh
M  +4    -4    kcms/wallpaper/ui/main.qml

https://invent.kde.org/plasma/plasma-workspace/-/commit/32f8d9ee2bc3bcad49c406aca86d7f4db1dd666d