| Summary: | Adding or removing images does not cause KCM to think there are unsaved changes | ||
|---|---|---|---|
| Product: | [Applications] systemsettings | Reporter: | Daniel Cleaver <daninshed> |
| Component: | kcm_wallpaper | Assignee: | Nate Graham <nate> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | kdedev, meven, nate, notmart |
| Priority: | HI | ||
| Version First Reported In: | 6.4.4 | ||
| Target Milestone: | --- | ||
| Platform: | Fedora RPMs | ||
| OS: | Linux | ||
| See Also: |
https://bugs.kde.org/show_bug.cgi?id=499808 https://bugs.kde.org/show_bug.cgi?id=489087 |
||
| Latest Commit: | https://invent.kde.org/plasma/plasma-workspace/-/commit/f288adb9a2b27f738f1fc5dd48035f3712d34058 | Version Fixed In: | 6.4.6 |
| Sentry Crash Report: | |||
| Attachments: |
vid1: systemsettings
vid2: desktop |
||
|
Description
Daniel Cleaver
2025-08-15 21:15:08 UTC
Created attachment 184116 [details]
vid1: systemsettings
Created attachment 184117 [details]
vid2: desktop
I can reproduce this using the provided steps in git-master Can also reproduce. It would appear that adding (and removing) images does not set the dirty state properly, so the KCM doesn't realize there are unsaved changes, and lets you leave without prompting you to save them. Raising to HI since the wallpaper KCM is a frequently-used KCM and this is basic usage. A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/5833 Git commit 10383b2047c9db6c657ab4a51c33e22e9dad38c5 by Nate Graham. Committed on 22/09/2025 at 21:21. Pushed by ngraham into branch 'master'. kcms/wallpapers: mark as dirty when the user adds or removes an image The KCM needs to handle ConfigurationChanged signals that come from the embedded component, which is where the signal comes from when you add or remove images. FIXED-IN: 6.4.6 M +6 -0 kcms/wallpaper/ui/main.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/10383b2047c9db6c657ab4a51c33e22e9dad38c5 Git commit 7c5e7e4201002ea3ce7a2cc254872a2eb779a577 by Nate Graham. Committed on 22/09/2025 at 23:37. Pushed by ngraham into branch 'Plasma/6.5'. kcms/wallpapers: mark as dirty when the user adds or removes an image The KCM needs to handle ConfigurationChanged signals that come from the embedded component, which is where the signal comes from when you add or remove images. FIXED-IN: 6.4.6 (cherry picked from commit 10383b2047c9db6c657ab4a51c33e22e9dad38c5) Co-authored-by: Nate Graham <nate@kde.org> M +6 -0 kcms/wallpaper/ui/main.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/7c5e7e4201002ea3ce7a2cc254872a2eb779a577 Git commit f288adb9a2b27f738f1fc5dd48035f3712d34058 by Nate Graham. Committed on 22/09/2025 at 23:38. Pushed by ngraham into branch 'Plasma/6.4'. kcms/wallpapers: mark as dirty when the user adds or removes an image The KCM needs to handle ConfigurationChanged signals that come from the embedded component, which is where the signal comes from when you add or remove images. FIXED-IN: 6.4.6 (cherry picked from commit 10383b2047c9db6c657ab4a51c33e22e9dad38c5) Co-authored-by: Nate Graham <nate@kde.org> M +6 -0 kcms/wallpaper/ui/main.qml https://invent.kde.org/plasma/plasma-workspace/-/commit/f288adb9a2b27f738f1fc5dd48035f3712d34058 so, this is pretty much by design. from the code, it saves additions and removals only when sometimes is applied, which might be worth reconsidering if is the most intuitive way. What should at least happen for sure is at least the apply button being enabled (In reply to Marco Martin from comment #9) > What should at least happen for sure is at least the apply button being > enabled Yeah, that's what the bug report was about, and what was fixed with the above commit. Thank you Nate! |