Bug 505902

Summary: TerminalRows is one less than requested
Product: [Applications] konsole Reporter: witekfl
Component: generalAssignee: Konsole Bugs <konsole-bugs-null>
Status: REPORTED ---    
Severity: normal    
Priority: NOR    
Version First Reported In: 25.04.2   
Target Milestone: ---   
Platform: Other   
OS: Linux   
Latest Commit: Version Fixed/Implemented In:
Sentry Crash Report:
Attachments: Do not change vertical margins

Description witekfl 2025-06-21 08:38:24 UTC 
SUMMARY
TerminalRows is one less than requested. For example for 25 is 24.

STEPS TO REPRODUCE
1. konsole -p TerminalRows=25 -p TerminalColumns=80
2. tput lines
3. 

OBSERVED RESULT
tput lines displays 24

EXPECTED RESULT
ought to be 25
Comment 1 witekfl 2025-06-22 12:59:50 UTC 
Created attachment 182513 [details]
Do not change vertical margins

The bug is in TerminalDisplay::calcGeometry()
I don't know what is better. Instead of margin and -margin, 0 as in patch. or -margin replace by margin.