| Summary: | Layout is reset when starting lokalize | ||
|---|---|---|---|
| Product: | [Applications] lokalize | Reporter: | Christophe Marin <christophe> |
| Component: | general | Assignee: | Simon Depiets <sdepiets> |
| Status: | RESOLVED FIXED | ||
| Severity: | normal | CC: | aacid, fin-w, shafff |
| Priority: | NOR | ||
| Version: | 25.03.80 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| Latest Commit: | https://invent.kde.org/sdk/lokalize/-/commit/3caf17be59318d6cf0ebf77b18c0278bf8cf5fa0 | Version Fixed In: | |
| Sentry Crash Report: | |||
|
Description
Christophe Marin
2025-03-20 10:01:11 UTC
Thanks for reporting. This is known, and is an unfortunate side-effect of the current changes to the underlying tab structure. I think, at least- I have tried to make the layout state system more robust, without much luck. I don't think a fix will be ready for the 25.04 branch unfortunately. The plan is, first fully move to a more sensible tab structure, then I'll ensure that the state saving and restoring works well. Once I start working on this I'll make sure I let you know! A possibly relevant merge request was started @ https://invent.kde.org/sdk/lokalize/-/merge_requests/212 The problem was simpler than I had anticipated. Christophe, are you able to test the merge request? Git commit 7286d371a0f969884ddd8800e1008dd11011dde5 by Finley Watson. Committed on 23/03/2025 at 11:50. Pushed by finw into branch 'master'. Fix editor tab state save / restore There was a mix-up with converting to and from base64 encoding, and more broadly there are two slightly conflicting state-saving mechanisms, one using the field "DockWidgets" within a project to store the editor tab's QMainWindow state, and the other using the "EditorStates" global state storage section for project agnostic editor tab states linked only to the file name the editor tab is editing. I've gotten rid of use of the "DockWidgets" fields in favour of the "EditorStates" section in the hopes that this creates more robust and longer-term state saving, and have fixed the state saving to at least as good as it was a few months ago (issues still remain). Related: bug 412819 M +1 -1 src/editortab.cpp M +2 -2 src/editortab.h M +10 -23 src/lokalizemainwindow.cpp https://invent.kde.org/sdk/lokalize/-/commit/7286d371a0f969884ddd8800e1008dd11011dde5 (In reply to fin-w from comment #3) > The problem was simpler than I had anticipated. Christophe, are you able to > test the merge request? Tested successfully Git commit 3caf17be59318d6cf0ebf77b18c0278bf8cf5fa0 by Finley Watson. Committed on 23/03/2025 at 13:19. Pushed by finw into branch 'release/25.04'. Fix editor tab state save / restore There was a mix-up with converting to and from base64 encoding, and more broadly there are two slightly conflicting state-saving mechanisms, one using the field "DockWidgets" within a project to store the editor tab's QMainWindow state, and the other using the "EditorStates" global state storage section for project agnostic editor tab states linked only to the file name the editor tab is editing. I've gotten rid of use of the "DockWidgets" fields in favour of the "EditorStates" section in the hopes that this creates more robust and longer-term state saving, and have fixed the state saving to at least as good as it was a few months ago (issues still remain). Related: bug 412819 (cherry picked from commit 7286d371a0f969884ddd8800e1008dd11011dde5) M +1 -1 src/editortab.cpp M +2 -2 src/editortab.h M +10 -23 src/lokalizemainwindow.cpp https://invent.kde.org/sdk/lokalize/-/commit/3caf17be59318d6cf0ebf77b18c0278bf8cf5fa0 |