| Summary: | No KDE styling for Qt's QML MessageDialog component | ||
|---|---|---|---|
| Product: | [Plasma] plasma-integration | Reporter: | Eamonn Rea <eamonnrea> |
| Component: | general | Assignee: | Plasma Bugs List <plasma-bugs> |
| Status: | CONFIRMED --- | ||
| Severity: | minor | CC: | cwo.kde, jgrulich, joey.joey586, justin, kde, nate, nicolas.fella, postix, quarro, realkpavel, tamaskrall42 |
| Priority: | NOR | Keywords: | qt6, regression |
| Version First Reported In: | 6.0.0 | ||
| Target Milestone: | --- | ||
| Platform: | Other | ||
| OS: | Linux | ||
| See Also: |
https://bugs.kde.org/show_bug.cgi?id=503332 https://bugs.kde.org/show_bug.cgi?id=507315 |
||
| Latest Commit: | Version Fixed In: | ||
| Sentry Crash Report: | |||
| Attachments: | Current Remove Connection Dialogue Example Screenshot | ||
|
Description
Eamonn Rea
2025-02-05 20:32:44 UTC
Confirmed on Operating System: KDE Linux 202502050256 KDE Plasma Version: 6.3.80 KDE Frameworks Version: 6.11.0 Qt Version: 6.8.2 Kernel Version: 6.13.1-arch1-1 (64-bit) Graphics Platform: Wayland Processors: 8 x Intel(R) Core(TM) i5-10210U CPU @ 1.60GHz Memory: 7.5 GiB of RAM Graphics Processor: Intel(R) UHD Graphics What do you mean with "doesn't follow theming? It certainly looks a bit off but colors etc. are correct for me. Can you provide a screenshot? I was referring to the Breeze theming, around buttons, the black border around the window, and the general layout does not really match the rest of the system. Comparing it with other dialogues it is a bit off. I will attach a screenshot after posting this comment. Created attachment 178035 [details]
Current Remove Connection Dialogue Example Screenshot
Thanks. I will take a look A possibly relevant merge request was started @ https://invent.kde.org/plasma/xdg-desktop-portal-kde/-/merge_requests/358 Sorry mixed up bug numbers *** Bug 500060 has been marked as a duplicate of this bug. *** *** Bug 502589 has been marked as a duplicate of this bug. *** *** Bug 504095 has been marked as a duplicate of this bug. *** *** Bug 504603 has been marked as a duplicate of this bug. *** This is mostly a Qt issue; in Qt 6, QML dialogs come from Qt directly, and don't use our theming. We need to either redirect the requests in our own code so we can show a KDE-provided dialog, or else work upstream with the Qt people to make their dialog respect our theming. *** Bug 505436 has been marked as a duplicate of this bug. *** The issue here seems to be MessageDialog. (We have separate bugs for ColorDialog and FontDialog, and File/FolderDialog we already get good dialogs). This isn't a particularly heavily used component in the first place: https://lxr.kde.org/search?%21v=kf6-qt6&_filestring=.qml&_string=MessageDialog Most of them are the Kirigami.Addons MessageDialog, and some completely custom things named MessageDialog. I think the QtQuick.Dialogs version is only used in - The Networks kcm to remove connections - Sticky Notes widget for removing notes - colord-kcm (which is X11 only) And a few times in apps: - Elisa in Settings and Track dialogs - KDE Connect SMS - DayKountdown - (and Cutehmi uses the Platform version, which is deprecated in favor of the QtQuick.Dialogs version) Seems like these could just be ported to Kirigami.PromptDialog or similar (except maybe Sticky Notes?). That's one option, yeah — except for Sticky Notes which could use a QtWidgets-based dialog. Another option, I believe, is adding our own styling for this in Plasma Integration, overriding the junky upstream styling from Qt. |